Maneage - Tasks: task #15643, Add valgrind and patch to maneage
You are not allowed to post comments on this tracker with your current authentication level.
task #15643: Add valgrind and patch to maneage
Submitter: | Boud Roukema <boud> | ||
Submitted: | Fri 15 May 2020 02:51:05 AM UTC | ||
Should Start On: | Fri 15 May 2020 12:00:00 AM UTC | Should be Finished on: | Fri 15 May 2020 12:00:00 AM UTC |
Category: | Software | Priority: | 5 - Normal |
Status: | Done | Privacy: | Public |
Assigned to: | None | Percent Complete: | 100% |
Open/Closed: | Closed | Effort: | 0.00 |
Jump to the original submission
Sat 23 May 2020 06:29:23 PM UTC, comment #6: |
Mohammad Akhlaghi <makhlaghi> |
Sat 23 May 2020 05:03:22 PM UTC, comment #5: Thanks Boud, I have good news! :-)
|
Raul Infante-Sainz <infantesainz> |
Fri 22 May 2020 02:22:34 PM UTC, comment #4: Valgrind is very useful, but not urgent. We have a small enough
|
Boud Roukema <boud> |
Fri 22 May 2020 08:33:00 AM UTC, comment #3: I tried but it didn't work. My laptop is a macOS High Sierra, v10.13.6. You can have a look at the error in the attached file `valgrind-crash-macOS.tar.gz'.
|
Raul Infante-Sainz <infantesainz> |
Fri 15 May 2020 07:24:38 PM UTC, comment #2: Raul, just one correction: you don't need to add valgrind to TARGETS.conf, its already there :-).
|
Mohammad Akhlaghi <makhlaghi> |
Fri 15 May 2020 07:21:27 PM UTC, comment #1: Thanks Boud, I just tried them and with some minor corrections it worked cleanly. As explained in the commit message, I just had to stop 'make check' breaking Maneage.
|
Mohammad Akhlaghi <makhlaghi> |
Fri 15 May 2020 02:51:05 AM UTC, original submission:
The maneage branch at
|
Boud Roukema <boud> |
No files currently attached
Depends on the following items: None found
Items that depend on this one: None found
There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.
Follow 7 latest changes.
Date | Changed by | Updated Field | Previous Value | => | Replaced by |
---|---|---|---|---|---|
2020-05-23 | makhlaghi | Status | Ready For Test | Done | |
Percent Complete | 90% | 100% | |||
Open/Closed | Open | Closed | |||
2020-05-15 | makhlaghi | Percent Complete | 0% | 90% | |
Carbon-Copy | - | Added -email is unavailable- | |||
2020-05-15 | boud | Category | None | Software | |
Status | None | Ready For Test |
Powered by Savane 3.13-f8d8.
Corresponding source code
This was an impressive catch! Thanks a lot Raul. Our three commits have now been "squashed" into one and rebased over the most recent Maneage branch and pushed to the main repo.
I tried to merge all the necessary components of the three commit messages into one complete commit message.
I am really proud of this commit, each one of us tested it, committed something to operate more smoothly for our particular case and it is finally merged into Maneage as one commit (so the Maneage user's don't have to get involved in the testing discussions ;-))!
Just one tiny thing Boud: for valgrind, there was no need to set 'mergenames=0' (the URL before the tarball didn't involve the version number), so I corrected it to the standard one-line statement like 'patch', I tested it and it worked like this :-).
I am now closing this task :-D.