taskSavannah Administration - Tasks: task #15711, Submission of Machine Learning...

 
 

task #15711: Submission of Machine Learning system VKF

Submitted by:  Dmitry V. Vinogradov <krrguest>
Submitted on:  Tue 30 Jun 2020 01:10:43 PM UTC  
 
Should Start On:  Tue 30 Jun 2020 12:00:00 AM UTC Should be Finished on:  Fri 10 Jul 2020 12:00:00 AM UTC
Category:  Project Approval Priority:  5 - Normal
Status:  In Progress Privacy:  Public
Percent Complete:  0% Assigned to:  Ineiev <ineiev>
Open/Closed:  Open Effort:  0.00

Add a New Comment (Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

( Jump to the original submission)

Mon 14 Sep 2020 10:22:38 AM UTC, comment #15: 

comment #14:

>
> No, I don't understand.


Good; I'll try to explain.

Copyright and license notices in every file help avoid uncertainty about what rights are given to the user. If a tarball has one statement about it in a central place like README, it makes the situation clear for that tarball; however, programmers often copy files from one package to another. If a file contains no notices, that information is lost, https://www.gnu.org/licenses/gpl-howto.html.

Now, from user's point of view, it doesn't matter whether the file was written by the original package maintainer (in fact, the term itself may have little sense): the users get the whole tarball, and they get it from the person who releases it. It's that person who is responsible for its full contents. In other words, whenever you put a file into your tarball, it becames your file. As I already pointed out, you can't include proprietary software in your tarball, even when it's written by other people.

> Do I also need to change the included dependencies files by addition of legal notices to each of them? Does it violate their licence terms?


I can see nothing in those terms that would prohibit adding that data to the covered files. Do I miss anything?

Ineiev <ineiev>
Site AdministratorIn charge of this item.
Fri 11 Sep 2020 09:13:14 AM UTC, comment #14: 

comment #13:

> Thank you!
>
> Now, in terms of Savannah hosting, "to work" for a package implies having valid copyright and license notices in all copyrightable files; in this sense, your included dependencies don't work.
>
> Do you see my point?


No, I don't understand.
There are the LICENSE files in every subfolder for different sources (the root contains the MIT license for my sources, mariadbpp has the BOOST license notification, and pybind11 contains Wenzel Jakob's BSD-style license).
I hope that all these licenses allow us to use their code without modification.
According to  https://savannah.nongnu.org/maintenance/ValidNotices/ I need to cover my own source files by some license notification. In my case it is the MIT one.
Do I also need to change the included dependencies files by addition of legal notices to each of them? Does it violate their licence terms?
I prefer to untouched sources of dependencies.

Dmitry V. Vinogradov <krrguest>
Thu 10 Sep 2020 05:37:31 PM UTC, comment #13: 

Thank you!

Now, in terms of Savannah hosting, "to work" for a package implies having valid copyright and license notices in all copyrightable files; in this sense, your included dependencies don't work.

Do you see my point?

Ineiev <ineiev>
Site AdministratorIn charge of this item.
Tue 08 Sep 2020 04:47:53 PM UTC, comment #12: 

comment #11:

> comment #10:
> >
> > The new tarball contains only my source files extended by the license text, sources of auxiliary libraries are excluded. The full distribution will contain these auxiliary sources too without docs and test subfolders to compile the CPython shared object library through the usual Python procedure.
>
> Please attach a sample full distribution.

OK, I've done. Now it contains all essential code. I just verified its successful build 

(file #49767)

Dmitry V. Vinogradov <krrguest>
Tue 08 Sep 2020 01:47:20 PM UTC, comment #11: 

comment #10:

>
> The new tarball contains only my source files extended by the license text, sources of auxiliary libraries are excluded. The full distribution will contain these auxiliary sources too without docs and test subfolders to compile the CPython shared object library through the usual Python procedure.


Please attach a sample full distribution.

Ineiev <ineiev>
Site AdministratorIn charge of this item.
Sat 05 Sep 2020 10:34:43 AM UTC, comment #10: 

comment #9:

I presented a talk on the VKF system at 8th Workshop 'FCA4AI' as a part of ECAI2020. I hoped to include a reference to the sources at savannah.nongnu, since one of the reviewers has indicated me. Now I hope to provide it into a full version of the paper.

> When the license is short like X11 License, its complete text should be included in the licensed files, not just a reference, unlike CMakeList.txt and other files do (please check https://savannah.nongnu.org/maintenance/ValidNotices/).
>


I prepared and attach an archive with sources extended by the complete text of MIT license.

>
> Then, your new tarball contains much fewer files; what will be actually included in your distribution?
>


The new tarball contains only my source files extended by the license text, sources of auxiliary libraries are excluded. The full distribution will contain these auxiliary sources too without docs and test subfolders to compile the CPython shared object library through the usual Python procedure.

Dmitry V. Vinogradov <krrguest>
Fri 04 Sep 2020 08:38:09 AM UTC, comment #9: 

When the license is short like X11 License, its complete text should be included in the licensed files, not just a reference, unlike CMakeList.txt and other files do (please check https://savannah.nongnu.org/maintenance/ValidNotices/).

Then, your new tarball contains much fewer files; what will be actually included in your distribution?

Ineiev <ineiev>
Site AdministratorIn charge of this item.
Thu 27 Aug 2020 06:25:39 PM UTC, comment #8: 

[comment #7]

> If there is no further interest, I'll cancel this submission.

I had my holidays, sorry for my long silence.

comment #6:

>
> comment #4:
> > I do not change the sources of dependencies, of course.
>
> This "of course" isn't obvious.  I'm responsible for the full contents of my tarballs; in particular, I shan't put any proprietary software there, shall I?


I follow famous engineering slogan "Do not change anything, if it is working correctly!"
Now dependencies for my project work perfectly. Of course, I'll check a quality of next versions of these software and freeze the sources of them or adapt the my own sources, if some problems occur.

Dmitry V. Vinogradov <krrguest>
Thu 27 Aug 2020 05:44:34 PM UTC, comment #7: 

If there is no further interest, I'll cancel this submission.

Ineiev <ineiev>
Site AdministratorIn charge of this item.
Mon 03 Aug 2020 07:02:31 AM UTC, comment #6: 

comment #4:

> I do not change the sources of dependencies, of course.


This "of course" isn't obvious.  I'm responsible for the full contents of my tarballs; in particular, I shan't put any proprietary software there, shall I?

Ineiev <ineiev>
Site AdministratorIn charge of this item.
Wed 01 Jul 2020 09:22:52 AM UTC, comment #5: 

Thank you, Dmitry.

I hope a more detailed evaluation comment will come in a day or several.

Svetlana T <svetlana>
Wed 01 Jul 2020 08:59:47 AM UTC, comment #4: 

Hi, Svetlana

Thank you for the advice!
I just have added copyright notices to all sources of VKF (*.cpp, *.hpp, setup.py and CMakeLists.txt). I do not change the sources of dependencies, of course. Attached vkf_src_mit.tar.gz contains modified files.

Best regards,
Dmitry

comment #2:

> Hi Dmitry
>
> Thank you for the addition.
>
> I haven't reviewed the licensing of the dependencies, however having a quick look at the files inside of the archive, there is one issue. For hosting at this site there is a requirement to include valid copyright notices in all files. An introduction to this procedure is provided at <https://www.gnu.org/prep/maintain/html_node/Copyright-Notices.html>, which is linked from the register page, <https://savannah.nongnu.org/register/>.
>
> For instance, a copyright notice is missing in setup.py and in src/Attributes.hpp.
>
> It is my understanding that you may wish to write the correct copyright notice, and go through the archive to include it in all files - including both code and documentation.
>
> Svetlana

Dmitry V. Vinogradov <krrguest>
Wed 01 Jul 2020 08:46:07 AM UTC, comment #3: 

I copied these terms from pybind11 author's declaration. This is 3-clause Modified BSD license, as I understand. Sources of the pybind11 library are included in my submissions together with the corresponding LICENSE file.

comment #1:

> "BSD-style" and even "BSD" when speaking about a license is ambiguous: https://www.gnu.org/licenses/bsd.html


comment #2:

> Hi Dmitry
>
> Thank you for the addition.
>
> I haven't reviewed the licensing of the dependencies, however having a quick look at the files inside of the archive, there is one issue. For hosting at this site there is a requirement to include valid copyright notices in all files. An introduction to this procedure is provided at <https://www.gnu.org/prep/maintain/html_node/Copyright-Notices.html>, which is linked from the register page, <https://savannah.nongnu.org/register/>.
>
> For instance, a copyright notice is missing in setup.py and in src/Attributes.hpp.
>
> It is my understanding that you may wish to write the correct copyright notice, and go through the archive to include it in all files - including both code and documentation.
>
> Svetlana


comment #2:

> Hi Dmitry
>
> Thank you for the addition.
>
> I haven't reviewed the licensing of the dependencies, however having a quick look at the files inside of the archive, there is one issue. For hosting at this site there is a requirement to include valid copyright notices in all files. An introduction to this procedure is provided at <https://www.gnu.org/prep/maintain/html_node/Copyright-Notices.html>, which is linked from the register page, <https://savannah.nongnu.org/register/>.
>
> For instance, a copyright notice is missing in setup.py and in src/Attributes.hpp.
>
> It is my understanding that you may wish to write the correct copyright notice, and go through the archive to include it in all files - including both code and documentation.
>
> Svetlana


comment #1:

> "BSD-style" and even "BSD" when speaking about a license is ambiguous: https://www.gnu.org/licenses/bsd.html

(file #49403)

Dmitry V. Vinogradov <krrguest>
Wed 01 Jul 2020 06:18:21 AM UTC, comment #2: 

Hi Dmitry

Thank you for the addition.

I haven't reviewed the licensing of the dependencies, however having a quick look at the files inside of the archive, there is one issue. For hosting at this site there is a requirement to include valid copyright notices in all files. An introduction to this procedure is provided at <https://www.gnu.org/prep/maintain/html_node/Copyright-Notices.html>, which is linked from the register page, <https://savannah.nongnu.org/register/>.

For instance, a copyright notice is missing in setup.py and in src/Attributes.hpp.

It is my understanding that you may wish to write the correct copyright notice, and go through the archive to include it in all files - including both code and documentation.

Svetlana

Svetlana T <svetlana>
Wed 01 Jul 2020 05:03:33 AM UTC, comment #1: 

"BSD-style" and even "BSD" when speaking about a license is ambiguous: https://www.gnu.org/licenses/bsd.html

Ineiev <ineiev>
Site AdministratorIn charge of this item.
Tue 30 Jun 2020 01:10:43 PM UTC, original submission:  

A new project has been registered at Savannah
This project account will remain inactive until a site admin approves
or discards the registration.

Registration Administration

While this item will be useful to track the registration process,
approving or discarding the registration must be done using the specific Group Administration page, accessible only to site administrators,
effectively logged as site administrators (superuser):

Registration Details

  • Name: Machine Learning system VKF
  • System Name:  vkf
  • Type: non-GNU software and documentation
  • License: Expat License (sometime refered to as MIT License)

Description:

It is a shared object library to make Machine Learning based on Lattice Theory.
It was written on C++11 with usage the MariaDB++ free library to connect to MariaDB databases and the pybind11 free library to convert it into CPython library
It was created as a result of Dr.Science degree research conducted at Dorodnicyn Computing Center of Russian Academy of Science.

Other Software Required:

mariadb++
Boost Software License 1.0
https://github.com/viaduck/mariadbpp
pybind11
BSD-style license
https://github.com/pybind/pybind11

Other Comments:

use
python3 ./setup.py build
to build the library
vkf.cpython-36m-x86_64-linux-gnu.so
where 36m corresponds to version of Python
Under OS Windows 10 the name is
vkf.cpython-36m.pyd

Tarball URL:

https://savannah.nongnu.org/submissions_uploads/vkf.tar.gz

Dmitry V. Vinogradov <krrguest>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #49767:  vkf_src_full.tar.gz added by krrguest (255KiB - application/gzip)
file #49743:  vkf_src_mit.tar.gz added by krrguest (35KiB - application/gzip)
file #49403:  vkf_src_mit.tar.gz added by krrguest (33KiB - application/gzip - I have added X11 (MIT) License terms to each VKF source file. Other files are untouched)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by svetlana (Posted a comment)
  • -email is unavailable- added by ineiev (Posted a comment)
  • -email is unavailable- added by krrguest (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

     

     

    Follow 5 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2020-09-08 krrguest Attached File- => Added vkf_src_full.tar.gz, #49767
    2020-09-05 krrguest Attached File- => Added vkf_src_mit.tar.gz, #49743
    2020-07-01 krrguest Attached File- => Added vkf_src_mit.tar.gz, #49403
    2020-07-01 ineiev StatusNone => In Progress
        Assigned toNone => ineiev

    Back to the top


    Powered by Savane 3.5