bugrdiff-backup - Bugs: bug #14545, Security(?) problem with remote...

 
 

bug #14545: Security(?) problem with remote backup

Submitter:  None
Submitted:  Thu 15 Sep 2005 11:49:00 AM UTC
   
 
Category:  None Severity:  3 - Normal
Item Group:  None Status:  Fixed
Privacy:  Public Assigned to:  None
Open/Closed:  Closed
* Mandatory Fields

Add a New Comment Rich Markup
   

Sat 09 Sep 2006 08:22:17 AM UTC, comment #3: 

Thanks, the Security.py patched worked for me.

Anonymous
Thu 15 Sep 2005 10:33:18 PM UTC, comment #2: 
Benedict Escoto <bescoto>
Group administrator
Thu 15 Sep 2005 12:38:47 PM UTC, comment #1: 

Apparently it's just FilenameMapping.set_init_quote_vals missing from the list of allowed remote function calls... or at least, the following patch fixes the problem for me...


--- Security.py 2005-09-15 14:36:52.000000000 +0200
+++ Security.py.new     2005-09-15 14:36:34.000000000 +0200
@@ -126,6 +126,7 @@
                 "Globals.get", "Globals.is_not_None", "Globals.get_dict_val",
                 "log.Log.open_logfile_allconn", "log.Log.close_logfile_allconn",
                 "Log.log_to_file", "FilenameMapping.set_init_quote_vals_local",
+                "FilenameMapping.set_init_quote_vals",
                 "SetConnections.add_redirected_conn", "RedirectedRun",
                 "sys.stdout.write", "robust.install_signal_handlers"]
        if (sec_level == "read-only" or sec_level == "update-only" or

Anonymous
Thu 15 Sep 2005 11:49:00 AM UTC, original submission:  

I'm using rdiff-backup 1.0.1 with Python 2.3 on Mac OS X 10.3.9, and if I try to do a remote backup (even to localhost) I get an error message (apparently) related to a wrong number of arguments passed to a funcion. To reproduce it, just run

  rdiff-backup /tmp/xx localhost::/tmp/yy

the returned error is

Traceback (most recent call last):
  File "/usr/bin/rdiff-backup", line 24, in ?
    rdiff_backup.Main.Main(sys.argv[1:])
  File "/usr/local/lib/python2.3/site-packages/rdiff_backup/Main.py", line 283, in Main
    take_action(rps)
  File "/usr/local/lib/python2.3/site-packages/rdiff_backup/Main.py", line 253, in take_action
    elif action == "backup": Backup(rps[0], rps[1])
  File "/usr/local/lib/python2.3/site-packages/rdiff_backup/Main.py", line 294, in Backup
    backup_set_fs_globals(rpin, rpout)
  File "/usr/local/lib/python2.3/site-packages/rdiff_backup/Main.py", line 440, in backup_set_fs_globals
    conn.FilenameMapping.set_init_quote_vals()
  File "/usr/local/lib/python2.3/site-packages/rdiff_backup/connection.py", line 445, in _call_
    return apply(self.connection.reval, (self.name,) + args)
  File "/usr/local/lib/python2.3/site-packages/rdiff_backup/connection.py", line 367, in reval
    if isinstance(result, Exception): raise result
rdiff_backup.Security.Violation:
Warning Security Violation!
Bad request for function: FilenameMapping.set_init_quote_vals
with arguments: []

Traceback (most recent call last):
[santini@Zorn rdiff_backup]$   File "/usr/bin/rdiff-backup", line 24, in ?
    rdiff_backup.Main.Main(sys.argv[1:])
  File "/usr/local/lib/python2.3/site-packages/rdiff_backup/Main.py", line 283, in Main
    take_action(rps)
  File "/usr/local/lib/python2.3/site-packages/rdiff_backup/Main.py", line 251, in take_action
    connection.PipeConnection(sys.stdin, sys.stdout).Server()
  File "/usr/local/lib/python2.3/site-packages/rdiff_backup/connection.py", line 352, in Server
    self.get_response(-1)
  File "/usr/local/lib/python2.3/site-packages/rdiff_backup/connection.py", line 314, in get_response
    try: req_num, object = self._get()
  File "/usr/local/lib/python2.3/site-packages/rdiff_backup/connection.py", line 230, in _get
    raise ConnectionReadError("Truncated header string (problem "
rdiff_backup.connection.ConnectionReadError: Truncated header string (problem probably originated remotely)

Anonymous

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

CC list is empty

 

There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

Only logged-in users can vote.

 

Follow 2 latest changes.

Date Changed by Updated Field Previous Value => Replaced by
2005-09-15 bescoto StatusNone Fixed
    Open/ClosedOpen Closed

Back to the top

Powered by Savane 3.13-f8d8.
Corresponding source code