mldonkey, a multi-networks file-sharing client - Bugs: bug #17618, Reassigned to another tracker...
You are not allowed to post comments on this tracker with your current authentication level.
bug #17618: Reassigned to another tracker [was: Incorrect charset used for some locales]
Submitter: | Gang Chen <gangchen> | ||
Submitted: | Wed 06 Sep 2006 03:42:00 AM UTC | ||
Category: | HTTP interface | Severity: | 4 - Important |
Item Group: | i18n issues | Status: | Ready For Test |
Assigned to: | None | Open/Closed: | Closed |
Release: | 2.7.7 | Release: | |
Operating System: | Linux | Binaries Origin: | CVS / Self compiled |
CPU type: | Intel x86 |
Jump to the original submission
Mon 13 Nov 2006 10:13:30 AM UTC, comment #14: |
spiralvoice <spiralvoice> |
Mon 13 Nov 2006 05:54:31 AM UTC, comment #13: The patch works fine for me, thanks. |
Gang Chen <gangchen> |
Wed 08 Nov 2006 09:30:41 PM UTC, comment #12: Updated patch for current CVS, please test and report back if it works for you |
spiralvoice <spiralvoice> |
Sat 07 Oct 2006 03:40:57 PM UTC, comment #11: ping |
spiralvoice <spiralvoice> |
Thu 14 Sep 2006 05:42:10 PM UTC, comment #10: Applied the language detection to CVS, for the display problems
|
spiralvoice <spiralvoice> |
Tue 12 Sep 2006 10:37:40 PM UTC, comment #9: To fix conversion problems enclose the string variable, which
|
spiralvoice <spiralvoice> |
Tue 12 Sep 2006 06:45:08 PM UTC, comment #8: I updated two places of code with an UTF8-conv function
|
spiralvoice <spiralvoice> |
Tue 12 Sep 2006 09:01:49 AM UTC, comment #7: The problem about tip is the filename are not converted to UTF-8 encoding properly when it displayed in the tip window.
|
Gang Chen <gangchen> |
Tue 12 Sep 2006 07:09:22 AM UTC, comment #6: Hi
|
Gang Chen <gangchen> |
Mon 11 Sep 2006 08:15:31 AM UTC, comment #5: Please test the updated patch, it converts all string to uppercase before analyzing them. |
spiralvoice <spiralvoice> |
Mon 11 Sep 2006 03:39:06 AM UTC, comment #4: I have tested your patch but unfortunately it doesn't works.
|
Gang Chen <gangchen> |
Thu 07 Sep 2006 11:38:06 AM UTC, comment #3: "The normalize_language method should also be changed since it will trim the "_CC" in the locale string."
|
spiralvoice <spiralvoice> |
Thu 07 Sep 2006 06:15:50 AM UTC, comment #2: --Buildinfo--
|
Gang Chen <gangchen> |
Wed 06 Sep 2006 12:29:47 PM UTC, comment #1: Please post output of "buildinfo" and "runinfo" |
spiralvoice <spiralvoice> |
Wed 06 Sep 2006 03:42:00 AM UTC, original submission:
THIS ITEM WAS REASSIGNED TO PATCH #5547. HiI found a bug that the charset is incorrect in some environment. For example, when the locale is set to "zh_CN" or "zh_CN.GBK" for Simplified Chinese, the mldonkey should use charset GB2312 or GBK charset to convert filenames, but it indeed using the BIG5 charset to convert filenames. This will result in filenames with incorrect characters displayed on webpages. I found the root cause of this problem is in src/utils/lib/charset.ml: The charsets list are always set to "BIG5, ..., GBK" when the language is "zh" | "SH" | "SR" -> li := central_european :: cyrillic ::!li | "ZH" -> li := chinese_traditional :: chinese_simplified :: !li | "BE" But please note the charset BIG5 for zh_TW is totally different from GBK for zh_CN, it's not a good idea to assume charsets for same language should always be compatible with rests. To workaround this problem, we can remove the chinese_traditional from above code, but it's bad for poeple who using Traditional Chinese. My suggestion is to match the locale in ll_CC format, while not only the language tag. For example: "zh_CN" -> li := chinese_simplified :: !li "zh_TW" -> li := chinese_traditional :: !li The normalize_language method should also be changed since it will trim the "_CC" in the locale string. A better solution for this issue may be that try to use the encoding for current locale provided by glibc, such as nl_langinfo(), it will returns the charset for current locale, same as result of the command: locale charmap Thanks |
Gang Chen <gangchen> |
No files currently attached
Depends on the following items: None found
Items that depend on this one: None found
There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.
Follow 15 latest changes.
Date | Changed by | Updated Field | Previous Value | => | Replaced by |
---|---|---|---|---|---|
2006-11-13 | spiralvoice | Reassign Item | mldonkey, a multi-networks file-sharing client, bug #17618 | mldonkey, a multi-networks file-sharing client, patch #5547 | |
2006-11-08 | spiralvoice | Status | In Progress | Ready For Test | |
Attached File | - | Added lang_tw_cn.patch, #11202 | |||
2006-11-08 | spiralvoice | Attached File | #10737 | Removed | |
2006-09-12 | spiralvoice | Status | Ready For Test | In Progress | |
2006-09-12 | spiralvoice | Attached File | - | Added lang_tw_cn.patch, #10737 | |
2006-09-12 | spiralvoice | Attached File | #10729 | Removed | |
2006-09-11 | spiralvoice | Attached File | - | Added lang_tw_cn.patch, #10729 | |
2006-09-11 | spiralvoice | Attached File | #10710 | Removed | |
2006-09-07 | spiralvoice | Severity | 3 - Normal | 4 - Important | |
Status | None | Ready For Test | |||
Release | None | 2.7.7 | |||
Operating System | None | Linux | |||
CPU type | None | Intel x86 | |||
Attached File | - | Added lang_tw_cn.patch, #10710 |
Powered by Savane 3.13-02a9.
Corresponding source code
THIS ITEM WAS REASSIGNED TO PATCH #5547.
Please, do not post any new comments to this item.