bugConcurrent Versions System - Bugs: bug #18147, Using -R makes pserver violate...


bug #18147: Using -R makes pserver violate protocol

Submitted by:  Jeffrey Hutzelman <jhutz>
Submitted on:  Mon 30 Oct 2006 04:50:03 AM UTC  
Category: Bug Fix (patch attached)Severity: 3 - Normal
Item Group: NoneStatus: None
Privacy: PublicAssigned to: None
Open/Closed: OpenRelease: 
Fixed Release: NoneFixed Feature Release: None

Add a New Comment(Rich Markup)

You are not logged in

Please log in, so followups can be emailed to you.


Mon 30 Oct 2006 04:50:03 AM UTC, original submission:

When cvs is invoked with -R to treat the repository as read-only, it prints out a message warning about the dangers of doing this with repositories to which other users might write(*). Unfortunately, it does this before the command has been identified, with the result that when a server mode is in use, the warning is emitted without encapsulation, which violates the protocol.

The attached patch defers the warning until after server_active has been initialized, and omits it entirely in that case (doing this right would be somewhat harder, and for little gain -- if the server admin has forced use of -R, it seems safe to assume (s)he understands the consequences, and if the command was 'server' as invoked by ext or fork, then the client should have already printed the warning anyway.

(*) Really, this is somewhat overstated. There is no danger of
corrupting the repository or even the user's working
directory. True, an update might get only some changed files
from a simultaneous commit, but this can easily be corrected
by running the update again, and atomicity has never been
CVS's strong suit.

Jeffrey Hutzelman <jhutz>


(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):

Attached Files
file #11103:  cvs_readonly_warning.patch added by jhutz (911B - text/x-patch - Don't warn about a read-only repository when acting as server)


Depends on the following items: None found

Items that depend on this one: None found


CC list is empty


Do you think this task is very important?
If so, you can click here to add your encouragement to it.
This task has 0 encouragements so far.

Only logged-in users can vote.


Please enter the title of George Orwell's famous dystopian book (it's a date):



Follows 1 latest change.

Date Changed By Updated Field Previous Value => Replaced By
Mon 30 Oct 2006 04:50:03 AM UTCjhutzAttached File-=>Added cvs_readonly_warning.patch, #11103

Back to the top

Powered by Savane 3.1-cleanup1