bugTransport Sample Protocol - Bugs: bug #19718, Include file tsp_rpc.h not...

 
 

bug #19718: Include file tsp_rpc.h not installed

Submitted by:  Robert de Vries <rhdv>
Submitted on:  Fri 27 Apr 2007 07:44:57 AM UTC  
 
Category: CoreSeverity: 5 - Blocker
Status: FixedPrivacy: Public
Assigned to: Frederik Deweerdt <deweerdt>Open/Closed: Closed
Release: 0.8.3Fixed Release: 0.8.3

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

(Jump to the original submission Jump to the original submission)

Fri 27 Apr 2007 11:31:53 AM UTC, comment #10:

So how does that work configuration control wise?
Is it broken in 0.8.3 or fixed?
Or put in another way, in which version 0.8.3 is this problem solved? In version 0.8.3 or in version 0.8.3?
Though one eh? :-)

Robert de Vries <rhdv>
Project Member
Fri 27 Apr 2007 11:25:37 AM UTC, comment #9:

You read it clearly
discovered in 0.8.3 and fixed in 0.8.3 how is that :))

Eric NOULARD <erk>
Project Administrator
Fri 27 Apr 2007 09:25:28 AM UTC, comment #8:

It works, thanks Frederik.

Robert de Vries <rhdv>
Project Member
Fri 27 Apr 2007 09:21:28 AM UTC, comment #7:

Ok I see.
You are right.
I should have tested it before talking.
Bad day for me today :))
The TSP_XINCLUDE should handle the generated case.
I will fix the macro later in order to make
it usable even in the generated file case.

Let it go this for 0.8.3 (The Real Issue :=)

Eric NOULARD <erk>
Project Administrator
Fri 27 Apr 2007 09:02:44 AM UTC, comment #6:

> Instead of using "plain" CMake INSTALL command
> you may well add:


> TSP_XINCLUDE(${CMAKE_CURRENT_BINARY_DIR}/include/tsp_prjcfg.h)

But it's tsp_rpc.h and the problem is that tsp_rpc.h is not present when the TSP_XINCLUDE macro runs because tsp_rpc.h is generated.
So cmake fails if we just TSP_XINCLUDE it (I think it's the CONFIGURE_FILE that screams about tsp_rpc.h not being available)
That's why I think that plain INSTALL is the way to go there.

Frederik Deweerdt <deweerdt>
Project AdministratorIn charge of this item.
Fri 27 Apr 2007 08:53:53 AM UTC, comment #5:

Fred,

Instead of using "plain" CMake INSTALL command
you may well add:

TSP_XINCLUDE(${CMAKE_CURRENT_BINARY_DIR}/include/tsp_prjcfg.h)

it should work the same and does some small
things besides the INSTALL statement.

In particular it puts the header in
<BUILD_TREE>/SYSTEM_NAME/include

The idea behind TSP_XSCRIPT, TSP_XINCLUDE, TSP_PROGRAM_INSTALL,
TSP_LIBRARY_INSTALL
and the like defined in make/TSPCMakeTools.cmake
is to hide some TSP specific handling
moreover it is a good place to handle platform specific
things we don't want to see in CMakeLists.txt

there is already some IF(WIN32) code in TSPCMakeTools.

Eric NOULARD <erk>
Project Administrator
Fri 27 Apr 2007 08:45:07 AM UTC, comment #4:

Culprit is :
revision 1.12
date: 2007-04-22 21:12:38 +0000; author: deweerdt; state: Exp; lines: +1 -2
Remove tsp_rpc.h from dependencies (tsp_rpc.h is generated)
----------------------------
I've added an INSTALL call for tsp_rpc.h (I missed that TSP_XINCLUDE does the install).
Can you try latests CVS an confirm it fixes it for you?

Frederik Deweerdt <deweerdt>
Project AdministratorIn charge of this item.
Fri 27 Apr 2007 08:42:22 AM UTC, comment #3:

My eye are not as accurate as they should to be :))

Sorry about that.

Eric NOULARD <erk>
Project Administrator
Fri 27 Apr 2007 08:37:38 AM UTC, comment #2:

tsp_rpc.h is missing, not tsp_prj.h

Robert de Vries <rhdv>
Project Member
Fri 27 Apr 2007 08:33:10 AM UTC, comment #1:

Hi Robert,

You are right tsp_prj.h IS necessary
for ANY TSP applications.

Howeever, I did try to:

1) Download pristine tsp-0.8.3 tarball
http://download.savannah.nongnu.org/releases/tsp/tsp-0.8.x/tsp-0.8.3/sources/tsp-0.8.3-Source.tar.gz

2) Build binary RPM in the usual way:

tar zxvf tsp-0.8.3-Source.tar.gz
mkdir build-0.8.3
cd build-0.8.3
cmake ../tsp-0.8.3-Source
make tsp_rpm

3) Check for tsp_prj.h and I see it is in the RPM

rpm -qpl RPM/RPMS/i386/tsp-0.8.3-1.i386.rpm | grep prj
/opt/tsp-0.8.3/include/tsp_prjcfg.h

My test was done on Fedora Core 6 / i686
what's your test box config?

Eric NOULARD <erk>
Project Administrator
Fri 27 Apr 2007 07:44:57 AM UTC, original submission:

When this include file is not installed I cannot compile my TSP provider.

It is also not present in the RPM file (as a consequence).

Robert de Vries <rhdv>
Project Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by erk (Posted a comment)
  • -unavailable- added by deweerdt (Updated the item)
  • -unavailable- added by rhdv (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 6 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Tue 01 May 2007 09:28:27 PM UTCdeweerdtStatusReady For Test=>Fixed
      Open/ClosedOpen=>Closed
    Fri 27 Apr 2007 11:25:37 AM UTCerkFixed ReleaseUnknown=>0.8.3
    Fri 27 Apr 2007 08:45:07 AM UTCdeweerdtStatusIn Progress=>Ready For Test
    Fri 27 Apr 2007 07:52:57 AM UTCdeweerdtAssigned toNone=>deweerdt
    Fri 27 Apr 2007 07:52:56 AM UTCdeweerdtStatusNone=>In Progress

    Back to the top


    Powered by Savane 3.1-cleanup