bugrdiff-backup - Bugs: bug #20528, rdiff-backup --compare-full fails...

 
 

bug #20528: rdiff-backup --compare-full fails with big directories

Submitter:  None
Submitted:  Thu 19 Jul 2007 04:36:30 AM UTC
   
 
Category:  None Severity:  3 - Normal
Item Group:  None Status:  Fixed
Privacy:  Public Assigned to:  None
Open/Closed:  Closed
* Mandatory Fields

Add a New Comment Rich Markup
   

Thu 26 Jul 2007 02:12:35 PM UTC, comment #1: 

Excellent catch, and thanks for the patch.

Patch applied in CVS, and will be a part of 1.1.13 and subsequent releases.

Andrew Ferguson <owsla>
Group administrator
Thu 19 Jul 2007 04:36:30 AM UTC, original submission:  

rdiff-backup 1.1.12 on gentoo/x86 bails out with a python exception indicating too many files are open when you attempt to do a full compare on a directory containing thousands of files.

INSTRUCTIONS TO REPRODUCE:
1. Make a directory with ~ 5000 files (mine has about 5320, each a few megs a pop)
2. rdiff-backup to another directory (I used an external usb drive, XFS filesystem)
3. 'rdiff-backup --compare-full' the resultant directories

SUGGESTED FIX:
I've attached a diff that fixes the problem for me.

Thanks for writing a great piece of software.
Andrew

Anonymous

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #13390:  rdiff-backup-fix-open-files.diff.txt added by None (732B - application/x-txt - suggested patch to fix problem)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by owsla (Posted a comment)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

    Follow 3 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2007-07-26 owsla StatusNone Fixed
        Open/ClosedOpen Closed
    2007-07-19 None Attached File- Added rdiff-backup-fix-open-files.diff.txt, #13390

    Back to the top

    Powered by Savane 3.13-02a9.
    Corresponding source code