bugaudio convert - Bugs: bug #23141, Mistaking Wave File for WMA File

 
 

bug #23141: Mistaking Wave File for WMA File

Submitted by:  None
Submitted on:  Fri 02 May 2008 05:14:51 PM UTC  
 
Category:  None Severity:  3 - Normal
Item Group:  None Status:  None
Privacy:  Public Assigned to:  None
Open/Closed:  Open

Add a New Comment (Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Fri 02 May 2008 05:32:12 PM UTC, comment #1: 

Just thought of it more. A better way maybe, would be the modify the is_wma check, to just check if the filename ends in ".wma" (case-insensitive) without checking if the file brief contains the word "Microsoft".

i.e. line 455 of the script:

echo $1 | grep -i '\.wma$'

instead of

file -b "$1" | grep 'Microsoft' || echo $1 | grep -i '\.wma$'

(file #15589)

Anonymous
Fri 02 May 2008 05:14:51 PM UTC, original submission:  

The logic for checking if the input file is of the WMA format is by looking for the word "Microsoft" in the file brief (file -b) (line 455 in the script).

Unfortunately, this particular wave file that i have has a file brief of

"RIFF (little-endian) data, WAVE audio, Microsoft PCM, 16 bit, stereo 44100 Hz"

This in itself is still not an issue. However, in lines 1272 to 1276 of the script, it checks that if you do not have mplayer installed, and your input file is a WMA file, it pops out a warning and exits.

Well, i do not have mplayer installed, and my file is a wave file wrongly classified as a WMA file, so the script fails for me when it shouldn't.

The workaround for me, since i do not work with WMA files at all, is to comment out lines 1270 to 1281 (checking for mplayer) altogether. (Attached is the script with those lines commented out.)

Anonymous

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #15589:  audio-convert added by None (41KiB - application/octet-stream - Script with the is_wma check modified.)
file #15588:  audio-convert added by None (41KiB - application/octet-stream - Script with checks for mplayer commented out.)

 

Depends on the following items: None found

Items that depend on this one: None found

 

CC list is empty

 

Do you think this task is very important?
If so, you can add your encouragement to it.
This task has 0 encouragements so far.

Only logged-in users can vote.

 

 

 

Follow 2 latest changes.

Date Changed by Updated Field Previous Value => Replaced by
2008-05-02 None Attached File- => Added audio-convert, #15589
2008-05-02 None Attached File- => Added audio-convert, #15588

Back to the top


Powered by Savane 3.5