bugrdiff-backup - Bugs: bug #24192, Allow --exclude-if-present to work...

 
 

bug #24192: Allow --exclude-if-present to work with directories

Submitter:  Vadim Zeitlin <zeitlin>
Submitted:  Tue 02 Sep 2008 11:43:01 PM UTC
   
 
Category:  None Severity:  3 - Normal
Item Group:  None Status:  Fixed
Privacy:  Public Assigned to:  None
Open/Closed:  Closed
* Mandatory Fields

Add a New Comment Rich Markup
   

Thu 04 Sep 2008 11:30:11 PM UTC, comment #1: 

Hi Vadim,

Good suggestion. I am going to change .isreg() at the end to .lstat() which will simply check if the path exists. It can be a dir, file, symlink, device, etc.

I would appreciate if you could test the change (if you're comfortable editing python, which I assume is the case).

Thanks,
Andrew

Andrew Ferguson <owsla>
Group administrator
Tue 02 Sep 2008 11:43:01 PM UTC, original submission:  

Currently the implementation of this option explicitly checks that its argument is a regular file, see presence_get_sf function in selection.py:

def sel_func(rp):
    if rp.isdir() and rp.readable() and rp.append(presence_filename).isreg(): return include
    return None


But I'd like to use it with directories to exclude backup of CVS and svn checkouts, e.g. --exclude-if-present=.svn. Would it be possible to relax this check to also work with directories?

Thanks in advance!

Vadim Zeitlin <zeitlin>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by owsla (Posted a comment)
  • -email is unavailable- added by zeitlin (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

    Follow 2 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2008-09-04 owsla StatusNone Fixed
        Open/ClosedOpen Closed

    Back to the top

    Powered by Savane 3.13-02a9.
    Corresponding source code