bugConcurrent Versions System - Bugs: bug #24268, echo is off in terminal after...

 
 

bug #24268: echo is off in terminal after interrupting the password entry using :ext and ssh

Submitted by:  Johannes Dewender <jonnyjd>
Submitted on:  Mon 15 Sep 2008 01:47:45 PM UTC  
 
Category: Bug ReportSeverity: 2 - Minor
Item Group: NoneStatus: Need Info
Privacy: PublicAssigned to: None
Open/Closed: OpenRelease: 
Fixed Release: NoneFixed Feature Release: None

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

(Jump to the original submission Jump to the original submission)

Thu 18 Sep 2008 09:56:14 PM UTC, comment #8:

some text got lost with copy and paste.. the second log snipped I posted, with "ERESTARTNOHAND" is from strace_ubuntu_load, while compiling in the background and being close to 100 % cpu load.

Johannes Dewender <jonnyjd>
Thu 18 Sep 2008 09:40:47 PM UTC, comment #7:

I was told about a tool called "strace", so I was playing around with this a bit and found something interesting.

There was this other system I tested with:
Ubuntu Linux, 2.6.24-19 kernel
cvs 1.12.13 and openssh 4.7p1

I could not reproduce the bug on that system before BUT:

When the machine is on high load (like compiling cvs), the bug also occurs at this machine.
I did a strace while idle (strace_ubuntu_idle)
and one with load, when the bug occurs (strace_ubuntu_load)

characteristic lines in idle:
select(6, [5], NULL, NULL, NULL) = 1 (in [5])
--- SIGINT (Interrupt) @ 0 (0) ---
rt_sigprocmask(SIG_SETMASK, ~[RTMIN RT_1], [INT], 8) = 0
write(2, "cvs [update aborted]: received i"..., 48) = 48
close(1) = 0
exit_group(1) = ?

while the first mention line has an "ERESTARTNOHAND" error befor the sigint:
select(6, [5], NULL, NULL, NULL) = ? ERESTARTNOHAND (To be restarted)
--- SIGINT (Interrupt) @ 0 (0) ---
rt_sigprocmask(SIG_SETMASK, ~[RTMIN RT_1], [INT], 8) = 0
write(2, "cvs [update aborted]: received i"..., 48) = 48
close(1) = 0
exit_group(1) = ?

I also did a strace of my system, which is still:
Arch Linux, kernel 2.26.5, on a PIII800Mhz
cvs 1.11.23
last part of strace_arch_piii800:
read(5, 0xb7f6e000, 4096) = ? ERESTARTSYS (To be restarted)
--- SIGINT (Interrupt) @ 0 (0) ---
write(2, "cvs", 3) = 3
write(2, " ", 1) = 1
write(2, "[", 1) = 1
write(2, "update", 6) = 6
write(2, " aborted]", 9) = 9
write(2, ": ", 2) = 2
write(2, "received ", 9) = 9
write(2, "interrupt", 9) = 9
write(2, " signal", 7) = 7
write(2, "\n", 1) = 1
exit_group(1) = ?

So I don't see much in the strace, but I suspect that this is a timeout issue, which occurs when not much computing power is available. Like it is the case while on 100% usage or just having an PIII 800 MHz?

I attached the 2 mentioned straces.

(file #16521, file #16522, file #16523)

Johannes Dewender <jonnyjd>
Wed 17 Sep 2008 05:46:48 PM UTC, comment #6:

I did some more testing:
(open)ssh is not running after interrupting with ^C. However, trying the same thing with ssh2, it is still running after ^C. It is not responding to a normal kill and I have to do a "kill -9" in order to stop it.

Hope this helps.

Additionally: I am running a 2.6.26.5 kernel on i686. It might also be related to this, not many systems run on this one yet.
(Arch Linux has rolling releases)

I also asked in the Arch community if somebody has an idea what could be wrong or if they can reproduce it on their systems:
http://bbs.archlinux.org/viewtopic.php?id=55368
I will tell if I found out more.

Johannes Dewender <jonnyjd>
Mon 15 Sep 2008 08:26:06 PM UTC, comment #5:

I checked ps. I can find entries for ssh when I run "cvs update", but they vanish right after I interrupt.

I also checked an ubuntu machine with cvs 1.12.13 and there was no problem with echo. However, this is not about the version. Installing cvs 1.12.13 on my system didn't help.

So this is something somewhat system dependent.

I don't know if it helps or not, but:

(I am testing with a local test repo now)
$ cvs -t update
-> main loop with CVSROOT=:ext:localhost:/home/jonnyjd/cvsroot
-> Starting server: ssh localhost cvs server
jonnyjd@localhost's password: cvs [update aborted]: received interrupt signal
-> Lock_Cleanup()
cvs [update aborted]: received interrupt signal
-> Lock_Cleanup()

$gdb --args cvs update
...
0xb7fd4424 in __kernel_vsyscall ()
cvs [update aborted]: received interrupt signal
(gdb) bt
#0 0xb7fd4424 in __kernel_vsyscall ()
#1 0xb7c66073 in __read_nocancel () from /lib/libc.so.6
#2 0xb7c0f8de in _IO_new_file_underflow () from /lib/libc.so.6
#3 0xb7c1128b in _IO_default_uflow_internal () from /lib/libc.so.6
#4 0xb7c12698 in __uflow () from /lib/libc.so.6
#5 0xb7c0c1bf in getc () from /lib/libc.so.6
#6 0x080503ea in stdio_buffer_input ()
#7 0x0805095f in buf_read_line ()
#8 0x0805406d in read_line ()
#9 0x08054528 in get_server_responses ()
#10 0x080594b4 in start_server ()
#11 0x080a0df3 in update ()
#12 0x08076a4b in main ()

gdb catches the interrupt and the echo problem doesn't occur, while running with gdb, by the way.

I compiled a package from source myself, so I wouldn't have a problem testing a patched version with some debug info or similar on my system.
I am not really experienced with interrupts/signals, though.

Johannes Dewender <jonnyjd>
Mon 15 Sep 2008 06:41:25 PM UTC, comment #4:

The enter-thing might make sense, since CVS as the parent process gets the first chance to handle the interrupt and its interrupt handler exits immediately, as opposed to SSH's, which I presume allows the handling of ^C as input.

Anyhow, you didn't tell me if SSH is still running in the background after you interrupt CVS? (`ps -eaf |grep ssh') My current hypothesis is that somehow the SSH interrupt handler isn't getting called on your system and that on other systems we are relying on either automatic pass-through of the SIGINT after CVS's handler completes or automatic delivery of SIGKILL to children when the parent process dies. Then SSH's handler can do the correct terminal cleanup.

If the SSH process started by your CVS is still running, then that would verify this hypothesis. Of course, your SSH could still die without being given a chance to process any signals. Not sure how to test that, except to install a new cleanup handler that delivers a SIGKILL to the child and then waits for it (with some sort of timeout) before dying.

Derek Robert Price <dprice>
Project Administrator
Mon 15 Sep 2008 05:17:17 PM UTC, comment #3:

Since you told me to check careful, I installed ssh2 from ssh.com:

When I connect ssh-only, I have to press enter after my ^C, but the echo problem doesn't occur.
When I set CVS_RSH=ssh2 I get a different password prompt (so I am sure it is really using ssh2) but otherwise the same problem. I might note, that I cvs interrupts right after STRG+C, different to having to press enter again, when I run ssh2-only.

So I am quite sure it is not a problem on ssh/ssh2 side, but of course, I can't be sure that it isn't something else on my system. Some console library cvs is using, i.e.

I have heimdal 1.2, but this shouldn't be affected, since ssh2 is not using this, refering to my package dependencies and ldd on ssh2 (no libheim). Anything else to check?

Johannes Dewender <jonnyjd>
Mon 15 Sep 2008 05:03:42 PM UTC, comment #2:

Hm - forgot to tell that, but I did try to connect ssh-only "ssh username@server..."to the same server, as the same user. The problem doesn't occur.

This is why I didn't send a report to openssh.

Quite weird though, when you say that cvs is not interacting with the terminal then. It might kill ssh at the "wrong moment" or something.

Johannes Dewender <jonnyjd>
Mon 15 Sep 2008 04:43:56 PM UTC, comment #1:

I haven't seen this on any other platforms, and CVS doesn't do anything to mess with the terminal when using :ext: as a connection method, so I suspect SSH is your problem.

Please see if you can duplicate this just using your SSH client to connect to your CVS server with the same user and password and let us know the result.

Derek Robert Price <dprice>
Project Administrator
Mon 15 Sep 2008 01:47:45 PM UTC, original submission:

Okay, here is the scenario:

CVSROOT is set to :ext;CVS_RSH=ssh:username@domain....
cvs is working (co, commit etc.) with this setting.
cvs version is 1.11.23 (built with Arch Linux without extra patches)
ssh version is OpenSSH 5.0p1

Now I run "cvs update" in my terminal (tried in urxvt and konsole). I get asked for a password and I interrupt using STRG+C to stop the action.

result:
Password: cvs [update aborted]: received interrupt signal
cvs [update aborted]: received interrupt signal

Then my prompt appears, my cursor already in the next line and echo is still off.
I have to run "stty echo" or "reset" to see me typing again.

Johannes Dewender <jonnyjd>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #16521:  strace_ubuntu_idle added by jonnyjd (17kB - application/octet-stream - These are the 3 strace runs from running "strace -o stracelog.. cvs update")
file #16522:  strace_ubuntu_load added by jonnyjd (17kB - application/octet-stream - These are the 3 strace runs from running "strace -o stracelog.. cvs update")
file #16523:  strace_arch_piii800 added by jonnyjd (12kB - application/octet-stream - These are the 3 strace runs from running "strace -o stracelog.. cvs update")

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by dprice (Posted a comment)
  • -unavailable- added by jonnyjd (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 5 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Thu 18 Sep 2008 09:40:47 PM UTCjonnyjdAttached File-=>Added strace_ubuntu_idle, #16521
      Attached File-=>Added strace_ubuntu_load, #16522
      Attached File-=>Added strace_arch_piii800, #16523
    Mon 15 Sep 2008 04:43:56 PM UTCdpriceSeverity3 - Normal=>2 - Minor
      StatusNone=>Need Info

    Back to the top


    Powered by Savane 3.1-cleanup