bugtpb -- ThinkPad Buttons - Bugs: bug #26346, MANY hardcoded

 
 

bug #26346: MANY hardcoded

Submitted by:  None
Submitted on:  Sun 26 Apr 2009 05:09:25 AM UTC  
 
Category: NoneSeverity: 3 - Normal
Item Group: NoneStatus: None
Privacy: PublicAssigned to: None
Open/Closed: Open

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Sun 26 Apr 2009 05:09:25 AM UTC, original submission:

It seems that few people cares about this project?

182c182
< vol = thinkpad_state.volume_level * 100 / 14;
---

> vol = thinkpad_state.volume_level * 100 / 15;

526c526
< printf(_("Brightness changed: Level %d\n"), thinkpad_state.brightness_level * 100 / 7);
---

> printf(_("Brightness changed: Level %d\n"), thinkpad_state.brightness_level * 100 / 15);

529c529
< snprintf(callback_cmd, sizeof(callback_cmd), "%s brightness %d", cfg.callback, thinkpad_state.brightness_level * 100 / 7);
---

> snprintf(callback_cmd, sizeof(callback_cmd), "%s brightness %d", cfg.callback, thinkpad_state.brightness_level * 100 / 15);

540c540
< xosd_display(osd_ptr, 1, XOSD_percentage, thinkpad_state.brightness_level * 100 / 7);
---

> xosd_display(osd_ptr, 1, XOSD_percentage, thinkpad_state.brightness_level * 100 / 15);

559c559
< vol = thinkpad_state.volume_level * 100 / 14;
---

> vol = thinkpad_state.volume_level * 100 / 15;

1034c1034
< thinkpad_state->brightness_level = (( buffer[0x5E] & 0x07) );
---

> thinkpad_state->brightness_level = (( buffer[0x5E] & 0x0f) );


< thinkpad_state->volume_level = 0x07; /* set volume_level to the value we write back to nvram */
---

> // thinkpad_state->volume_level = 0x0f; /* set volume_level to the value we write back to nvram */


(I comment out the xxx because I want to change volume in /proc/acpi/ibm/volume and do not want tpb to unmute sound, this does nothing harmful)

Anonymous

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

CC list is empty

 

Do you think this task is very important?
If so, you can click here to add your encouragement to it.
This task has 0 encouragements so far.

Only logged-in users can vote.

 

Please enter the title of George Orwell's famous dystopian book (it's a date):

 

 

No Changes Have Been Made to This Item

Back to the top


Powered by Savane 3.1-cleanup