bugtpb -- ThinkPad Buttons - Bugs: bug #26346, MANY hardcoded

 
 

bug #26346: MANY hardcoded

Submitter:  None
Submitted:  Sun 26 Apr 2009 05:09:25 AM UTC
   
 
Category:  None Severity:  3 - Normal
Item Group:  None Status:  None
Privacy:  Public Assigned to:  None
Open/Closed:  Open
* Mandatory Fields

Add a New Comment Rich Markup
   

Sun 26 Apr 2009 05:09:25 AM UTC, original submission:  

It seems that few people cares about this project?

182c182
<     vol = thinkpad_state.volume_level * 100 / 14;
---

>     vol = thinkpad_state.volume_level * 100 / 15;

526c526
< printf(_("Brightness changed: Level %d\n"), thinkpad_state.brightness_level * 100 / 7);
---

> printf(_("Brightness changed: Level %d\n"), thinkpad_state.brightness_level * 100 / 15);

529c529
< snprintf(callback_cmd, sizeof(callback_cmd), "%s brightness %d", cfg.callback, thinkpad_state.brightness_level * 100 / 7);
---

> snprintf(callback_cmd, sizeof(callback_cmd), "%s brightness %d", cfg.callback, thinkpad_state.brightness_level * 100 / 15);

540c540
< xosd_display(osd_ptr, 1, XOSD_percentage, thinkpad_state.brightness_level * 100 / 7);
---

> xosd_display(osd_ptr, 1, XOSD_percentage, thinkpad_state.brightness_level * 100 / 15);

559c559
< vol = thinkpad_state.volume_level * 100 / 14;
---

> vol = thinkpad_state.volume_level * 100 / 15;

1034c1034
<   thinkpad_state->brightness_level  =                                               (( buffer[0x5E] & 0x07)     );
---

>   thinkpad_state->brightness_level  =                                               (( buffer[0x5E] & 0x0f)     );



<     thinkpad_state->volume_level = 0x07; /* set volume_level to the value we write back to nvram */
---

>     //    thinkpad_state->volume_level = 0x0f; /* set volume_level to the value we write back to nvram */


(I comment out the xxx because I want to change volume in /proc/acpi/ibm/volume and do not want tpb to unmute sound, this does nothing harmful)

Anonymous

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

CC list is empty

 

There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

Only logged-in users can vote.

 

No changes have been made to this item

Back to the top

Powered by Savane 3.13-cf05.
Corresponding source code