bugTraverso: A Multitrack Audio Recorder and Editor - Bugs: bug #26376, option for sse optimization when...

 
 

bug #26376: option for sse optimization when DETECT_HOST_CPU_FEATURES is OFF

Submitted by:  Orcan Ogetbil <oget>
Submitted on:  Tue 28 Apr 2009 02:53:55 AM UTC  
 
Category: Feature RequestSeverity: 3 - Normal
Priority: 5 - NormalItem Group: New Feature
Status: NonePrivacy: Public
Assigned to: NoneOpen/Closed: Open

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Thu 14 Jan 2010 08:57:57 PM UTC, comment #3:

pushed the "include ARCH_X86_64 in the conditional check for sse support" to git, the other part of your patch I'm not sure about.

Could you please look into the PACKAGERS file, and let me know if the solution detailed there fits your needs in an equally comfortable way?

Thanks!

Remon Sijrier <r_sijrier>
Project Administrator
Thu 14 Jan 2010 08:43:52 PM UTC, comment #2:

Hello Orcan,

Sorry for replying so late to this issue, the spam filter probably has eaten the notification email.

Anyways, since 0.49.1 there is a PACKAGERS file, with a description how to enable certain optimizations with the DETECT_HOST_CPU_FEATURES = OFF, and only turn on the optimizations you know will work for the cpu's your package is targeted for.

Good catch for the ARCH_X86_64 case, since I indeed forgot about that, will merge those bits.

Thanks, Remon

Remon Sijrier <r_sijrier>
Project Administrator
Tue 28 Apr 2009 03:00:19 AM UTC, comment #1:

Sorry, there is a little typo in the patch. In line 62 of the patch file,

ARCH_x86_64
should be
ARCH_X86_64

Orcan Ogetbil <oget>
Tue 28 Apr 2009 02:53:55 AM UTC, original submission:

Hi,
The current CMakelists.txt file supports the auto-detection of cpu features very well and enables SSE optimizations accordingly.

However this feature is not suitable for packaging. But turning off the DETECT_HOST_CPU_FEATURES simultaneously disables SSE optimizations and there is no convenient way of enabling them.

I am attaching this patch I made against traverso-0.49.1. It modifies CMakelists.txt and adds the option WANT_SSE. This option is only effective when DETECT_HOST_CPU_FEATURES is OFF, so everybody is safe.

Would you please consider applying it to your sources as it will make the lives of packagers easier?

---
I have one more question: The files

src/common/Mixer.h
src/traverso/Traverso.cpp

contain the code for enabling SSE optimizations, but as is, they only enable it for x86, not for x86_64.

The patch I attached modifies these two files so that the SSE optimizations are also effective for x86_64 architecture.

If there is a mistake in the patch, could you please let me know?

Thanks!

Orcan Ogetbil <oget>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #18030:  traverso-sseopt.patch added by oget (3kB - text/x-patch - WANT_SSE option to the CMakeLists.txt file)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by r_sijrier (Posted a comment)
  • -unavailable- added by oget (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follows 1 latest change.

    Date Changed By Updated Field Previous Value => Replaced By
    Tue 28 Apr 2009 02:53:56 AM UTCogetAttached File-=>Added traverso-sseopt.patch, #18030

    Back to the top


    Powered by Savane 3.1-cleanup