bugutil-vserver - Bugs: bug #27134, [PATCH] vsomething does not work...

 
 

You are not allowed to post comments on this tracker with your current authentification level.

bug #27134: [PATCH] vsomething does not work when called without VSOMETHING_PKGMGMT set

Submitted by:  Matthijs Kooijman <matthijs>
Submitted on:  Wed 29 Jul 2009 11:35:01 AM UTC  
 
Category: NoneSeverity: 3 - Normal
Item Group: NoneStatus: None
Privacy: PublicAssigned to: None
Open/Closed: OpenComponent Version: alpha
Release: trunk (r2844)

Wed 29 Jul 2009 11:42:14 AM UTC, comment #1:

Hmm, on second thought, this might not be exactly the right fix. I was updating the --help output, I noticed that the behaviour this patch "fixes" is exactly what is documented:

"Execute <cmd> <vserver> <params>* foreach vserver."

It is mostly not what I had expected, and not what happens when VSOMETHING_PKGMGMT is set, which still makes vsomething a bit inconsistent. However, it does make it more powerful, since it allows running custom scripts in the host for each vserver, but still allows for running things inside a vserver by using "vserver" as the <cmd> and "exec" as the first <param>.

So, I guess we can close this report... I do feel that the stuff that happens in vsomething related to package management would better be extracted in some other script(s)...

Matthijs Kooijman <matthijs>
Wed 29 Jul 2009 11:35:01 AM UTC, original submission:

When trying to use vsomething directly (which is handy, since it supports --all, as opposed to vserver exec), vsomething doesn't work. It runs the command, but inside the host instead of the vserver, and adds the vserver name as the first argument.

Looking at the code, this is really broken (assuming this weird behaviour is not intentional, in which case it is really not documented anywhere). It seems this has been broken since the initial checkin in 2005.

The attached patch fixes this issue by calling vserver exec when VSOMETHING_PKGMGMT is not set. It slightly restructures the control flow to have only two cases instead of three left.

Matthijs Kooijman <matthijs>

 

Attached Files
file #18492:  vsomething.diff added by matthijs (1kB - text/x-diff)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by matthijs (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follows 1 latest change.

    Date Changed By Updated Field Previous Value => Replaced By
    Wed 29 Jul 2009 11:35:02 AM UTCmatthijsAttached File-=>Added vsomething.diff, #18492

    Back to the top


    Powered by Savane 3.1-cleanup