bugAVR C Runtime Library - Bugs: bug #27243, malloc: small error in comment

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #27243: malloc: small error in comment

Submitter:  Stefan Ernst <sternst>
Submitted:  Thu 13 Aug 2009 01:51:45 PM UTC
   
 
Category:  Documentation Severity:  3 - Normal
Priority:  5 - Normal Item Group:  libc code
Status:  Fixed Assigned to:  joerg_wunsch
Percent Complete:  0% Open/Closed:  Closed
Release:  1.7.* Fixed Release:  None

Mon 07 Jun 2010 03:22:56 PM UTC, comment #2: 

Good catch, thanks!

Joerg Wunsch <joerg_wunsch>
Group administrator
Wed 26 Aug 2009 08:57:36 PM UTC, comment #1: 

Joerg, you're the most familiar with malloc stuff. Assigning to you.

Eric Weddington <arcanum>
Group administrator
Thu 13 Aug 2009 01:51:45 PM UTC, original submission:  


        /*
         * First, walk the free list and try finding a chunk that
         * would match exactly.  If we found one, we are done.  While
         * walking, note down the size of the largest chunk we found
         * that would still fit the request -- we need it for step 2.
         *
         */
         ...
                        if (s == 0 || fp1->sz < s)
                                s = fp1->sz;


Shouldn't the "largest" actually be a "smallest" (due to the code)?

Stefan Ernst <sternst>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attached Files
file #19336:  bug27243.patch added by aboyapati (2KiB - application/octet-stream - Patch for bug 27243. Comment in mallo.c modified.)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by joerg_wunsch (Posted a comment)
  • -email is unavailable- added by aboyapati (Updated the item)
  • -email is unavailable- added by arcanum (Posted a comment)
  • -email is unavailable- added by sternst (Submitted the item)
  •  

    Follow 6 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2010-06-07 joerg_wunsch Item GroupNone libc code
        StatusNone Fixed
        Open/ClosedOpen Closed
    2010-01-13 arcanum CategoryNone Documentation
    2009-12-22 aboyapati Attached File- Added bug27243.patch, #19336
    2009-08-26 arcanum Assigned toNone joerg_wunsch

    Back to the top

    Powered by Savane 3.13-02a9.
    Corresponding source code