bugrdiff-backup - Bugs: bug #29808, --max-file-size does not combine...

 
 

bug #29808: --max-file-size does not combine with --include and --exclude

Submitted by:  Peter McGill <pamcgill>
Submitted on:  Thu 06 May 2010 03:52:14 PM UTC  
 
Category: NoneSeverity: 3 - Normal
Item Group: NoneStatus: None
Privacy: PublicAssigned to: None
Open/Closed: Open

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Thu 06 May 2010 03:52:14 PM UTC, original submission:

I'm running version 1.2.8 (On Windows 7 for this example test)

Given the following Source directory:
Directory of C:\Users\Peter\Test\Source

06/05/2010 10:59 AM <DIR> .
06/05/2010 10:59 AM <DIR> ..
06/05/2010 10:59 AM <DIR> Include
06/05/2010 10:54 AM 99,528 large.txt
06/05/2010 10:53 AM 12 small.txt
2 File(s) 99,540 bytes

Directory of C:\Users\Peter\Test\Source\Include

06/05/2010 10:59 AM <DIR> .
06/05/2010 10:59 AM <DIR> ..
06/05/2010 10:55 AM <DIR> Exclude
06/05/2010 10:54 AM 99,528 large.txt
06/05/2010 10:53 AM 12 small.txt
2 File(s) 99,540 bytes

Directory of C:\Users\Peter\Test\Source\Include\Exclude

06/05/2010 10:55 AM <DIR> .
06/05/2010 10:55 AM <DIR> ..
06/05/2010 10:54 AM 99,528 large.txt
06/05/2010 10:53 AM 12 small.txt
2 File(s) 99,540 bytes

And the include file test.txt:
- C:/Users/Peter/Test/Source/Include/Exclude
C:/Users/Peter/Test/Source/Include

Running either of the following two commands results in the following backup directory:
"C:\Program Files\rdiff-backup\rdiff-backup.exe" --max-file-size 50000 --include-globbing-filelist C:/Users/Peter/Test/test.txt --exclude ** C:/Users/Peter/Test/Source C:/Users/Peter/Test/Dest
"C:\Program Files\rdiff-backup\rdiff-backup.exe" --max-file-size 50000 --exclude C:/Users/Peter/Test/Source/Include/Exclude --include C:/Users/Peter/Test/Source/Include --exclude ** C:/Users/Peter/Test/Source C:/Users/Peter/Test/Dest

Directory of C:\Users\Peter\Test\Dest

06/05/2010 10:59 AM <DIR> .
06/05/2010 10:59 AM <DIR> ..
06/05/2010 10:59 AM <DIR> Include
06/05/2010 11:28 AM <DIR> rdiff-backup-data
06/05/2010 10:53 AM 12 small.txt
1 File(s) 12 bytes

Directory of C:\Users\Peter\Test\Dest\Include

06/05/2010 10:59 AM <DIR> .
06/05/2010 10:59 AM <DIR> ..
06/05/2010 10:55 AM <DIR> Exclude
06/05/2010 10:53 AM 12 small.txt
1 File(s) 12 bytes

Directory of C:\Users\Peter\Test\Dest\Include\Exclude

06/05/2010 10:55 AM <DIR> .
06/05/2010 10:55 AM <DIR> ..
06/05/2010 10:53 AM 12 small.txt
1 File(s) 12 bytes

Which completely ignores the include/exclude options.

Conversely running either of the following two commands produces the following backup directory:
"C:\Program Files\rdiff-backup\rdiff-backup.exe" --include-globbing-filelist C:/Users/Peter/Test/test.txt --exclude ** --max-file-size 50000 C:/Users/Peter/Test/Source C:/Users/Peter/Test/Dest
"C:\Program Files\rdiff-backup\rdiff-backup.exe" --exclude C:/Users/Peter/Test/Source/Include/Exclude --include C:/Users/Peter/Test/Source/Include --exclude ** --max-file-size 50000 C:/Users/Peter/Test/Source C:/Users/Peter/Test/Dest

Directory of C:\Users\Peter\Test\Dest

06/05/2010 10:59 AM <DIR> .
06/05/2010 10:59 AM <DIR> ..
06/05/2010 10:59 AM <DIR> Include
06/05/2010 11:35 AM <DIR> rdiff-backup-data
0 File(s) 0 bytes

Directory of C:\Users\Peter\Test\Dest\Include

06/05/2010 10:59 AM <DIR> .
06/05/2010 10:59 AM <DIR> ..
06/05/2010 10:54 AM 99,528 large.txt
06/05/2010 10:53 AM 12 small.txt
2 File(s) 99,540 bytes

Completely ignoring the max-file-size option.

A much more desirable result would be to match both the include/exclude options and the max-file-size option resulting in a directory as follows:
Directory of C:\Users\Peter\Test\Dest

06/05/2010 10:59 AM <DIR> .
06/05/2010 10:59 AM <DIR> ..
06/05/2010 10:59 AM <DIR> Include
06/05/2010 11:35 AM <DIR> rdiff-backup-data
0 File(s) 0 bytes

Directory of C:\Users\Peter\Test\Dest\Include

06/05/2010 10:59 AM <DIR> .
06/05/2010 10:59 AM <DIR> ..
06/05/2010 10:53 AM 12 small.txt
1 File(s) 12 bytes

Peter

Peter McGill <pamcgill>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by pamcgill (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    No Changes Have Been Made to This Item

    Back to the top


    Powered by Savane 3.1-cleanup1