bugmldonkey, a multi-networks file-sharing client - Bugs: bug #30830, Reassigned to another tracker...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #30830: Reassigned to another tracker [was: GTK1 oldgui does not compile with Ocaml 3.1*]

Submitter:  spiralvoice <spiralvoice>
Submitted:  Sat 21 Aug 2010 09:37:42 AM UTC
   
 
Category:  GUI GTK1 oldgui Severity:  4 - Important
Item Group:  Compilation problem Status:  Ready For Test
Assigned to:  ygrek Open/Closed:  Closed
Release:  3.0.4 Release: 
Operating System:  None Binaries Origin:  None
CPU type:  None

Mon 23 Aug 2010 04:26:49 AM UTC, comment #5: 

THIS ITEM WAS REASSIGNED TO PATCH #7287


Please, do not post any new comments to this item.

spiralvoice <spiralvoice>
Group administrator
Mon 23 Aug 2010 04:26:48 AM UTC, comment #4: 

CouldnĀ“t wait much longer ;-) It works! Moved to patch tracker.

spiralvoice <spiralvoice>
Group administrator
Mon 23 Aug 2010 04:22:59 AM UTC, comment #3: 

Regarding gui_queries_base.ml there is an old, known problem with "make maintainerclean". The file exists in CVS

http://cvs.savannah.gnu.org/viewvc/mldonkey/src/gtk/gui/gui_queries_base.ml?root=mldonkey&view=markup

and is used during compile, but deleted by that make target.

I will test your patch later, thanks!

spiralvoice <spiralvoice>
Group administrator
Sun 22 Aug 2010 09:58:52 PM UTC, comment #2: 

Here is a dirty patch. After fixing pa_zog the build failed with missing gui_queries_base.ml
Looks like nobody ever tried to build it or what?
Anyway, I copied it from newgui and commented some labels to compile. Now oldgui compiles and starts. Please review, I will cleanup the patch later.

(file #21276)

ygrek <ygrek>
Group Member
Sat 21 Aug 2010 09:43:08 AM UTC, comment #1: 

To test GTK1 oldgui compilation with Ocaml 3.1* use this patch:

--- config/configure.in 2010-08-16 21:17:06.000000000 +0200
+++ config/configure.in 2010-08-21 11:35:21.000000000 +0200
@@ -650,10 +650,6 @@
 REBUILD_OCAML=no
 case "$OCAMLVERSION" in
     3.1*)
-      if test "$GUI" = "oldgui"; then
-        OLDGUI_NO_31=yes
-        GUI=no
-      fi
       ;;
     "$REQUIRED_OCAML"*|3.09.*|3.08.4*|3.08.3*) ;;
     *)

spiralvoice <spiralvoice>
Group administrator
Sat 21 Aug 2010 09:37:42 AM UTC, original submission:  

THIS ITEM WAS REASSIGNED TO PATCH #7287
During "make depend", called by config/configure this happens:

/usr/local/bin/ocamlc.opt -I tools/zoggy -I +camlp4 -pp "/usr/local/bin/camlp4 pa_o.cmo pr_dump.cmo -loc loc" -a -o pa_zog.cma  tools/zoggy/zog_types.ml tools/zoggy/zog_messages.ml tools/zoggy/zog_misc.ml tools/zoggy/pa_zog.ml
File "tools/zoggy/pa_zog.ml", line 659, characters 1-3:
Parse error: [expr level ;] expected after "in" (in [expr])
File "tools/zoggy/pa_zog.ml", line 1, characters 0-1:
Error: Preprocessor error

spiralvoice <spiralvoice>
Group administrator

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by ygrek (Updated the item)
  • -email is unavailable- added by spiralvoice (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

     

    Follow 5 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2010-08-23 spiralvoice Reassign Itemmldonkey, a multi-networks file-sharing client, bug #30830 mldonkey, a multi-networks file-sharing client, patch #7287
    2010-08-22 ygrek Attached File- Added zoggy_camlp4.diff, #21276
        StatusNone Ready For Test
        Assigned toNone ygrek
    2010-08-21 spiralvoice Dependencies- patch #7144 is dependent

    Back to the top

    Powered by Savane 3.13-4b48.
    Corresponding source code