Gnome Chemistry Utils - Bugs: bug #42977, gchem3d 0.14.8 buggy molecule...
You are not allowed to post comments on this tracker with your current authentication level.
bug #42977: gchem3d 0.14.8 buggy molecule rotation
Submitter: | Toni Andjelkovic <andjelkovic> | ||
Submitted: | Wed 13 Aug 2014 06:55:44 PM UTC | ||
Category: | None | Severity: | 3 - Normal |
Item Group: | None | Status: | Fixed |
Privacy: | Public | Assigned to: | jean_brefort |
Open/Closed: | Closed |
Jump to the original submission
Mon 08 Sep 2014 08:33:46 PM UTC, comment #13: |
Jean Bréfort <jean_brefort> |
Mon 08 Sep 2014 08:01:16 PM UTC, comment #12: I have found that the linear transformation code (in libs/gcu/matrix.cc) is a terrible mess.
|
Toni Andjelkovic <andjelkovic> |
Sun 31 Aug 2014 07:59:52 AM UTC, comment #11: Closed after 0.14.9 release. |
Jean Bréfort <jean_brefort> |
Sat 30 Aug 2014 09:12:39 AM UTC, comment #10: Patch commited. Thanks. |
Jean Bréfort <jean_brefort> |
Fri 29 Aug 2014 07:20:46 PM UTC, comment #9: GLView::Rotation() does not support 0,0 as arguments (divide by 0 and we get NAN), I'll fix that too, but there is no need to update the view if no change occured. |
Jean Bréfort <jean_brefort> |
Fri 29 Aug 2014 07:01:38 PM UTC, comment #8: OK, I have not commited anything yet. I applied locally your patch with some minor modifications, but not tested yet. I intend to commit tomorrow if time permits. |
Jean Bréfort <jean_brefort> |
Fri 29 Aug 2014 06:41:05 PM UTC, comment #7: In my patch, I left out these two lines, because they looked like a workaround:
|
Toni Andjelkovic <andjelkovic> |
Thu 21 Aug 2014 12:05:06 PM UTC, comment #6: I see, I should replace all gdouble instances in the code, I suppose. Thanks. |
Jean Bréfort <jean_brefort> |
Thu 21 Aug 2014 11:16:26 AM UTC, comment #5: Because of consistency with the signature of void GLView::Rotate (gdouble x, gdouble y) in libs/gcu/glview.cc. Also, because the x and y coordinates in GdkEventMotion are gdouble. |
Toni Andjelkovic <andjelkovic> |
Thu 21 Aug 2014 11:10:03 AM UTC, comment #4: While >I'm here, why did you replace double with gdouble? |
Jean Bréfort <jean_brefort> |
Thu 21 Aug 2014 11:07:01 AM UTC, comment #3: I am unable to reproduce using current debian (unstable). Anyway, I understand the logic of the patch and will apply it (or may be alightly modified version) a soon as possible. |
Jean Bréfort <jean_brefort> |
Thu 21 Aug 2014 10:47:36 AM UTC, comment #2: The bug is easily reproducible on Fedora 19 and 20 with the latest packaged gtk3 versions (gtk3-3.10.9-1 on Fedora 20). It occurs accidentally when you try to rotate a molecule quickly along any axis.
|
Toni Andjelkovic <andjelkovic> |
Wed 13 Aug 2014 07:56:54 PM UTC, comment #1: I'm unable to reproduce. Does this happen with any Gtk+-3.0 version? Which one are you using? |
Jean Bréfort <jean_brefort> |
Wed 13 Aug 2014 06:55:44 PM UTC, original submission:
There is a bug with molecule rotation in the gchem3d viewing window:
|
Toni Andjelkovic <andjelkovic> |
Depends on the following items: None found
Items that depend on this one: None found
There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.
Follow 5 latest changes.
Date | Changed by | Updated Field | Previous Value | => | Replaced by |
---|---|---|---|---|---|
2014-08-31 | jean_brefort | Open/Closed | Open | Closed | |
2014-08-30 | jean_brefort | Status | None | Fixed | |
Assigned to | None | jean_brefort | |||
2014-08-29 | jean_brefort | Attached File | - | Added rotation.patch, #31997 | |
2014-08-13 | andjelkovic | Attached File | - | Added patch-rotation.txt, #31898 |
Powered by Savane 3.13-f8d8.
Corresponding source code
The code comes from an old study I made about rotation arond a fixed point about twenty years ago.
I'll add comments when can remember how it wors.
I never intended to allow translation of the molecule.