bugAVR C Runtime Library - Bugs: bug #57154, iom1284p.h: typo of...

 
 

bug #57154: iom1284p.h: typo of OCR1BL0:OCR1BL7, OCR1BH0:OCR1BH7, OCR3BL0:OCR3BL7 and OCR3AH0:OCR3AH7

Submitted by:  Jan Jurzitza <webfreak>
Submitted on:  Sat 02 Nov 2019 04:34:47 PM UTC  
 
Category:  Header Severity:  3 - Normal
Priority:  5 - Normal Item Group:  Header files
Status:  None Assigned to:  None
Percent Complete:  0% Open/Closed:  Open
Release:  2.0.0 Fixed Release:  None

Add a New Comment (Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Sat 02 Nov 2019 04:34:47 PM UTC, original submission:  

the registers OCR1BL0:OCR1BL7, OCR1BH0:OCR1BH7, OCR3BL0:OCR3BL7 and OCR3AH0:OCR3AH7 are missing from the header file and where they should be defined there are the registers with the names An instead of Bn defined. (lines 693-710 and 802-819)

I'm not sure if the same code was copy-pasted to/from some other header files because I have only looked at this file so far. I noticed this because it redefined an already existing define for all the A values with the same value.

What I also noticed but where I don't know if it's an issue: OCR2_0:OCR2_7 is also defined twice. (once below OCR2A and once below OCR2B) I'm not sure if this was intended because all other memory addresses usually have a different naming and in the data sheet in 17.11.4 OCR2A – Output Compare Register A and 17.11.5 OCR2A – Output Compare Register B they are named OCR2A[7:0] and OCR2B[7:0] respectively instead of OCR2[7:0] (though changing these might break programs relying on those defines)

I have also attached a patch (diff -rupN) which fixes the naming of the macros mentioned in the bug title here but not the OCR2_n macros.

Jan Jurzitza <webfreak>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #47780:  patch.txt added by webfreak (2KiB - text/plain)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by webfreak (Submitted the item)
  •  

     

     

    Follows 1 latest change.

    Date Changed by Updated Field Previous Value => Replaced by
    2019-11-02 webfreak Attached File- => Added patch.txt, #47780

    Back to the top


    Powered by Savane 3.5