bugmldonkey, a multi-networks file-sharing client - Bugs: bug #9213, Rename problem to any filename...

 
 

You are not allowed to post comments on this tracker with your current authentification level.

bug #9213: Rename problem to any filename with % (percent)

Submitted by:  Artifex Maximus <artifex>
Submitted on:  Fri Jun 4 07:36:37 2004  
Votes:  1  
 
Category: CoreSeverity: 4 - Important
Item Group: Program malfunctionStatus: None
Assigned to: NoneOpen/Closed: Open
Release: Release: 2.8.2
Operating System: FreeBSDBinaries Origin: CVS / Self compiled
CPU type: Intel x86

(Jump to the original submission Jump to the original submission)

Sat Mar 24 16:35:29 2007, comment #19:

You mean patch 5775? Doesn't help:

rename "foo bar baz.quux" to "foo+bar%2Bbaz.quux" -> web interface reports that file was successfully renamed to "foo bar+baz.quux"

Sergey Svishchev <shattered>
Mon Mar 19 00:07:03 2007, comment #18:

Please try again with current CVS, some work has been done on this problem.

spiralvoice <spiralvoice>
Project Administrator
Thu Jan 25 22:59:42 2007, comment #17:

"+ and % are allowed and possible, but if you use the html gui the command to rename the file are send via the http proto where the url is encoded, so + is an space and %2b is an +, thats not an mldonkey bug"

How's that not a mldonkey bug? Web interface is a part of mldonkey. These chars should be just URL-escaped, that's all.

Sergey Svishchev <shattered>
Thu Jan 18 19:41:28 2007, comment #16:

" and \ are illegal chars on some filesystems and are not allowed, they are renamed to _
+ and % are allowed and possible, but if you use the html gui the command to rename the file are send via the http proto where the url is encoded, so + is an space and %2b is an +, thats not an mldonkey bug
if you want to use such chars then rename the file with sancho i.e

the filename_rename.patch only rename the " chars to _ at the html input box before sending it to core to prevent the 'Bad number of args' error

Schlumpf <schlumpf_>
Project Member
Sun Jan 14 12:27:04 2007, comment #15:

bug 17116 may be related too.

Sergey Svishchev <shattered>
Sun Jan 14 12:25:39 2007, comment #14:

OK, built 2.8.2 with filename_rename.patch and string2_tokens_quoting_fix.patch.

I guess they were intended to solve different problem, because the one I've reported is still there -- I'm still unable to use literal ", \ and + chars. % still acts as an escape char (try entering %2b).

Sergey Svishchev <shattered>
Sun Jan 14 10:44:29 2007, comment #13:

check out patch #5679

Schlumpf <schlumpf_>
Project Member
Mon Jan 2 16:09:04 2006, comment #12:

Tried 2.7.1 + this patch. # and & are ok, but:

" causes an error: 'Bad number of arguments'
\ acts as an escape char (has to be doubled)
+ inserts space (however, %2b inserts +)
% is not escaped

Sergey Svishchev <shattered>
Mon Jan 2 00:18:21 2006, comment #11:

Please test patch #4748

spiralvoice <spiralvoice>
Project Administrator
Sun Nov 27 18:59:09 2005, comment #10:

Perhaps this is the same bug...

mldonkey 2.6.5, ocaml 3.08.4, built from NetBSD pkgsrc on NetBSD/i386 3.99.10.

- connect to the web interface
- click "Transfers", "Downloads"
- click any file name in the list
- in the "Filename" edit box, insert '"', '#' or '&' character in existing file name, then press Enter to commit the change
- file is not renamed, and error message is displayed:
For '#', '&':
Unknown type for content :
Exception Failure("Unterminated delim \"")
For '"':
Bad number of arguments

Sergey Svishchev <shattered>
Sat Oct 30 11:17:18 2004, comment #9:

Does your filesystem allow you letters like the one you mentioned?

spiralvoice <spiralvoice>
Project Administrator
Wed Aug 11 13:31:33 2004, comment #8:

I try on the freshly compiled CVS (2.5-27) on a FreeBSD with ocaml3.08. I try to rename with % in it and it works great. But when I try to rename a file with "&" within web interface's pull down menu or input box (anything -> anythin&g):
Exception Failure("Unterminated delim \"")
If I try the same with double-quotes in input box ("anythin&g") following error occured:
Bad number of arguments

Artifex Maximus <artifex>
Tue Aug 10 18:48:17 2004, comment #7:

Changing severity to 1 because this bug might be solved in current CVS release.

spiralvoice <spiralvoice>
Project Administrator
Tue Aug 10 14:53:15 2004, comment #6:

Please try CVS 2-5-27 and report if the bugs is solved

spiralvoice <spiralvoice>
Project Administrator
Tue Aug 10 10:57:22 2004, comment #5:

On Windows platforms filenames are not allowed to have a % character, so I think they will get filtered along with other letters. Please have a look at this thread:
http://mldonkey.berlios.de/modules.php?name=Forums&file=viewtopic&p=14445#14445

spiralvoice <spiralvoice>
Project Administrator
Tue Aug 10 10:51:53 2004, comment #4:

Havin the same problem with CVS 2-5-26 when putting a % into an existing filename:
HTTPSERVER: Exception Failure(_) in request_handler

spiralvoice <spiralvoice>
Project Administrator
Fri Jul 23 09:29:08 2004, comment #3:

Hm. I'm the only one who see the filled form values? I give my system, version and how I obtain it.

But here it again:
- FreeBSD 4-STABLE
- ocaml 3.07p2
- MLD 2-5-21e self compiled
- enough free space (~1GB)
- enough free memory (~10MB of 192MB)
- i don't make any log sorry
- problem happens when i go into a download on web interface and choose any name from list or write the new name into the input box (i tried without double-quotes)

Artifex Maximus <artifex>
Thu Jul 22 23:22:02 2004, comment #2:

The information you provided for this bug is not suffisant to
track it and solve it. Please, you need at least to give the
following information:

- mldonkey version ?
- downloaded from Savannah or compiled ?
- your system ? (OS, memory, free disk space)
- when did the bug appeared ?
- have you a log file (mldonkey output obtained by
./mldonkey &> mldonkey.log
with option 'verbose' set to true) ?

spiralvoice <spiralvoice>
Project Administrator
Tue Jun 15 01:00:35 2004, comment #1:

Using what interface, have you tried using double-quotes,...
That report is severely lacking.

Anonymous
Fri Jun 4 07:36:37 2004, original submission:
Artifex Maximus <artifex>

 

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by spiralvoice (Posted a comment)
  • -unavailable- added by shattered (Posted a comment)
  • -unavailable- added by schlumpf_ (Posted a comment)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 1 encouragement so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 9 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Tue Aug 7 21:15:26 2007schlumpf_StatusReady For Test=>None
    Sun Jan 14 10:44:29 2007schlumpf_Release2.7.1=>2.8.2
    Mon Jan 2 00:18:54 2006spiralvoiceSeverity1 - Wish=>4 - Important
    Mon Jan 2 00:18:21 2006spiralvoiceStatusNeed Info=>Ready For Test
      Releasee=>
      Release2-5-21=>2.7.1
    Sun Nov 27 18:59:09 2005shatteredCarbon-Copy-=>Added shattered
    Mon Jul 18 23:41:57 2005beedauchonStatusNone=>Need Info
    Tue Aug 10 18:48:17 2004spiralvoiceSeverity3 - Normal=>1 - Wish

    Back to the top


    Powered by Savane 3.1-cleanup