buglwIP - A Lightweight TCP/IP stack - Bugs: bug #20531, cs8900 driver in c16x port cannot...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #20531: cs8900 driver in c16x port cannot handle pbufs with odd number of bytes

Submitter:  Mike Kleshov <kleshov>
Submitted:  Thu 19 Jul 2007 09:54:54 AM UTC
   
 
Category:  Contrib Severity:  3 - Normal
Item Group:  Change Request Status:  Fixed
Privacy:  Public Assigned to:  None
Open/Closed:  Closed Planned Release:  None
lwIP version:  None

Jump to the original submission

Mon 10 Sep 2007 12:17:40 PM UTC, comment #16: 

Put in a request to join the lwip group through savannah.  I can then add you as a member, and this will give you CVS write access.

We ask that all changes to CVS are first mentioned as either a bug, patch or task on savannah so that other developers can contribute.  In your case this is unlikely to be much of an issue as you'll mostly be dealing with the cs8900 driver rather than the core code.

If you want me to move the cs8900 driver code in the contrib module out of the "old" section, let me know which directories I should be looking at and I can make this change.

Kieran Mansley <kieranm>
Group Member
Thu 06 Sep 2007 08:38:02 AM UTC, comment #15: 

There is some informations in contrib.txt doc file, but I think it's better that Kieran answer you...

Thank you for your help...

Frédéric Bernon <fbernon>
Group Member
Thu 06 Sep 2007 08:32:37 AM UTC, comment #14: 

Frédéric, I would like to be the maintainer of the cs8900 driver. I don't have a lot of free time, but I should be able to devote some time to it every week or so. Where should I post questions such as what are my functions as a maintainer, how to discuss proposed modifications of the driver, how to commit changes and so on?

Mike Kleshov <kleshov>
Group Member
Wed 05 Sep 2007 05:59:18 PM UTC, comment #13: 

Ok, I have update the "old" port, and I close this bug.

Mike, if you want to be the maintainer for this driver tell me, we will put it in a upper level in contrib folder.

Frédéric Bernon <fbernon>
Group Member
Wed 05 Sep 2007 02:27:24 PM UTC, comment #12: 

As long as it is documented, and either (i) has no dependency on the version of lwIP it's used with or (ii) if it does have a dependency then someone is willing to actively maintain it, I'm happy to have it included in the contrib folder at the same level as apps and ports.  Otherwise, we could just apply this patch to the version currently in the "old" unmaintained directory in contrib.

Kieran Mansley <kieranm>
Group Member
Fri 31 Aug 2007 05:09:31 PM UTC, comment #11: 

So, provide it "outside" any port seems to be a good idea? Since cs8900 is an ethernet chip very popular, perhaps add a folder "driver" in "contrib" (at the same level than "apps" and "ports") ?

Mike, if Kieran and other developers are agree with that, could you provide a little text file to give some tips to port it, with you architecture as sample?

Frédéric Bernon <fbernon>
Group Member
Fri 31 Aug 2007 05:03:39 PM UTC, comment #10: 

About the driver being tied to the c16x architecture, I'd say it's very much architecture-independent. I am using the driver with the cs8900 connected to an ARM-based microcontroller, and I didn't have to make any changes to make it work, except providing the base address to access the chip's registers.

Mike Kleshov <kleshov>
Group Member
Fri 31 Aug 2007 04:45:50 PM UTC, comment #9: 

Hi Mike,

comments I like was more from Roland, with his last problems. I just hope than he or you provide a fixed driver, so, now, it's done !!!

Can you tell me if this driver is very closed with c16x port, or is it independant? Perhaps in this last case, we could add in "contrib" a "driver" folder ?

Frédéric Bernon <fbernon>
Group Member
Fri 31 Aug 2007 04:37:26 PM UTC, comment #8: 

Frédéric, I believe you are referring to this email:
http://lists.nongnu.org/archive/html/lwip-users/2007-08/msg00051.html
I followed the discussion. Indeed, the bug in the cs8900 driver must have caused the problem. I am attaching the cs8900 driver from CVS with the patch applied. I am not sure what kind of comments you'd like to see here, but I would be happy to provide them.

(file #13845)

Mike Kleshov <kleshov>
Group Member
Wed 29 Aug 2007 09:50:54 AM UTC, comment #7: 

There was a problem last week, posted on "[lwip-users] Problem with socket send()", which seems to be a bug of tcp segment merging, but which finally was fixed by this patch.

Roland, if you have upgrade your code to last CVS HEAD, perhaps you can post here the cs8900 driver with the patch integrated, and your comments? Or Mike?


Frédéric Bernon <fbernon>
Group Member
Thu 19 Jul 2007 01:02:29 PM UTC, comment #6: 

The reason for the change is precisely so that those parts don't become part of a release, and so that they don't prevent a release being made because no one is keeping them in sync with the rest of the tree.

I am also hoping that by removing support for it altogether we might get someone to stand up and take it on.  If it's popular as you say someone must be using it who could keep it up to date!

Kieran Mansley <kieranm>
Group Member
Thu 19 Jul 2007 12:57:46 PM UTC, comment #5: 

I must say I'm new to this. I didn't realize that there are unmaintained parts in the lwip tree. It's fine as long as those parts don't become part of a release, otherwise they should be marked somewhere in docs as 'MAY CONTAIN BUGS'.
Actually the cs8900 driver worked for me out of the box with the 1.2.0 release as well as with recent CVS code, until I hit this bug. I imagine this ethernet chip is popular, so it's a shame the driver does not have a maintainer. I would be able to test some code on a target board now and then, but I'm not sure I have enough time to become a proper maintainer...

Mike Kleshov <kleshov>
Group Member
Thu 19 Jul 2007 12:41:41 PM UTC, comment #4: 

I'd rather leave it open as a bug.  I've no problems with bugs existing for a long time, and it makes sure that such problems remain visible rather than being forgotten.

Kieran Mansley <kieranm>
Group Member
Thu 19 Jul 2007 12:34:50 PM UTC, comment #3: 

Perhaps we could close as "wont fix" the record, copy the patch file and add a link (to https://savannah.nongnu.org/bugs/?20531) in "contrib\ports\old\c16x" folder?

I think such "bug" could stay here during a long long time if there is any new maintainer...

Frédéric Bernon <fbernon>
Group Member
Thu 19 Jul 2007 12:29:05 PM UTC, comment #2: 

We need someone to maintain the driver - it will be broken in many more ways than this now as a result of all the API changes between 1.2 and the forthcoming 1.3. 

We should keep this patch in case someone does step forward to take over the running of that driver, but no point applying it without a maintainer.

Kieran Mansley <kieranm>
Group Member
Thu 19 Jul 2007 12:02:16 PM UTC, comment #1: 

Hi Mike,

I think there the driver is not yet supported (since there is no maintainer for). It is now in contrib\ports\old\c16x. So, I don't know what you should do in this case. Kieran, for such request, what to do ?

Frédéric Bernon <fbernon>
Group Member
Thu 19 Jul 2007 09:54:54 AM UTC, original submission:  

The cs8900 driver in contrib\ports\c16x\netif does not handle chained pbuf's with odd numberof bytes correctly. It has a warning comment 'this routine assumes 16-bit boundary pbufs', but the comment is too vague, since it can be understood as 'pbuf's must be aligned at 16-bit boundaries'.
Many real-world applications will use chained pbuf's with odd number of bytes.
Proposed change: remove the limitation. Attaching a patch. The patch has been tested on a target board.

Mike Kleshov <kleshov>
Group Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attached Files
file #13845:  cs8900if.c added by kleshov (28KiB - text/x-csrc - CS8900 driver from CVS (31 Aug 2007) with the patch applied)
file #13396:  cs8900if.c.patch added by kleshov (2KiB - application/octet-stream)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by kieranm (Posted a comment)
  • -email is unavailable- added by fbernon (Posted a comment)
  • -email is unavailable- added by kleshov (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

     

    Follow 6 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2007-09-05 fbernon StatusPostponed Fixed
        Open/ClosedOpen Closed
        Planned Release 1.3.0
    2007-08-31 kleshov Attached File- Added cs8900if.c, #13845
    2007-07-19 kieranm StatusNone Postponed
    2007-07-19 kleshov Attached File- Added cs8900if.c.patch, #13396

    Back to the top

    Powered by Savane 3.13-3230.
    Corresponding source code