lwIP - A Lightweight TCP/IP stack - Bugs: bug #20531, cs8900 driver in c16x port cannot...
You are not allowed to post comments on this tracker with your current authentication level.
bug #20531: cs8900 driver in c16x port cannot handle pbufs with odd number of bytes
Submitter: | Mike Kleshov <kleshov> | ||
Submitted: | Thu 19 Jul 2007 09:54:54 AM UTC | ||
Category: | Contrib | Severity: | 3 - Normal |
Item Group: | Change Request | Status: | Fixed |
Privacy: | Public | Assigned to: | None |
Open/Closed: | Closed | Planned Release: | None |
lwIP version: | None |
Jump to the original submission
Mon 10 Sep 2007 12:17:40 PM UTC, comment #16: |
Kieran Mansley <kieranm> |
Thu 06 Sep 2007 08:38:02 AM UTC, comment #15: There is some informations in contrib.txt doc file, but I think it's better that Kieran answer you...
|
Frédéric Bernon <fbernon> |
Thu 06 Sep 2007 08:32:37 AM UTC, comment #14: Frédéric, I would like to be the maintainer of the cs8900 driver. I don't have a lot of free time, but I should be able to devote some time to it every week or so. Where should I post questions such as what are my functions as a maintainer, how to discuss proposed modifications of the driver, how to commit changes and so on? |
Mike Kleshov <kleshov> |
Wed 05 Sep 2007 05:59:18 PM UTC, comment #13: Ok, I have update the "old" port, and I close this bug.
|
Frédéric Bernon <fbernon> |
Wed 05 Sep 2007 02:27:24 PM UTC, comment #12: As long as it is documented, and either (i) has no dependency on the version of lwIP it's used with or (ii) if it does have a dependency then someone is willing to actively maintain it, I'm happy to have it included in the contrib folder at the same level as apps and ports. Otherwise, we could just apply this patch to the version currently in the "old" unmaintained directory in contrib. |
Kieran Mansley <kieranm> |
Fri 31 Aug 2007 05:09:31 PM UTC, comment #11: So, provide it "outside" any port seems to be a good idea? Since cs8900 is an ethernet chip very popular, perhaps add a folder "driver" in "contrib" (at the same level than "apps" and "ports") ?
|
Frédéric Bernon <fbernon> |
Fri 31 Aug 2007 05:03:39 PM UTC, comment #10: About the driver being tied to the c16x architecture, I'd say it's very much architecture-independent. I am using the driver with the cs8900 connected to an ARM-based microcontroller, and I didn't have to make any changes to make it work, except providing the base address to access the chip's registers. |
Mike Kleshov <kleshov> |
Fri 31 Aug 2007 04:45:50 PM UTC, comment #9: Hi Mike,
|
Frédéric Bernon <fbernon> |
Fri 31 Aug 2007 04:37:26 PM UTC, comment #8: Frédéric, I believe you are referring to this email:
|
Mike Kleshov <kleshov> |
Wed 29 Aug 2007 09:50:54 AM UTC, comment #7: There was a problem last week, posted on "[lwip-users] Problem with socket send()", which seems to be a bug of tcp segment merging, but which finally was fixed by this patch.
|
Frédéric Bernon <fbernon> |
Thu 19 Jul 2007 01:02:29 PM UTC, comment #6: The reason for the change is precisely so that those parts don't become part of a release, and so that they don't prevent a release being made because no one is keeping them in sync with the rest of the tree.
|
Kieran Mansley <kieranm> |
Thu 19 Jul 2007 12:57:46 PM UTC, comment #5: I must say I'm new to this. I didn't realize that there are unmaintained parts in the lwip tree. It's fine as long as those parts don't become part of a release, otherwise they should be marked somewhere in docs as 'MAY CONTAIN BUGS'.
|
Mike Kleshov <kleshov> |
Thu 19 Jul 2007 12:41:41 PM UTC, comment #4: I'd rather leave it open as a bug. I've no problems with bugs existing for a long time, and it makes sure that such problems remain visible rather than being forgotten. |
Kieran Mansley <kieranm> |
Thu 19 Jul 2007 12:34:50 PM UTC, comment #3: Perhaps we could close as "wont fix" the record, copy the patch file and add a link (to https://savannah.nongnu.org/bugs/?20531) in "contrib\ports\old\c16x" folder?
|
Frédéric Bernon <fbernon> |
Thu 19 Jul 2007 12:29:05 PM UTC, comment #2: We need someone to maintain the driver - it will be broken in many more ways than this now as a result of all the API changes between 1.2 and the forthcoming 1.3.
|
Kieran Mansley <kieranm> |
Thu 19 Jul 2007 12:02:16 PM UTC, comment #1: Hi Mike,
|
Frédéric Bernon <fbernon> |
Thu 19 Jul 2007 09:54:54 AM UTC, original submission:
The cs8900 driver in contrib\ports\c16x\netif does not handle chained pbuf's with odd numberof bytes correctly. It has a warning comment 'this routine assumes 16-bit boundary pbufs', but the comment is too vague, since it can be understood as 'pbuf's must be aligned at 16-bit boundaries'.
|
Mike Kleshov <kleshov> |
Depends on the following items: None found
Items that depend on this one: None found
There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.
Follow 6 latest changes.
Date | Changed by | Updated Field | Previous Value | => | Replaced by |
---|---|---|---|---|---|
2007-09-05 | fbernon | Status | Postponed | Fixed | |
Open/Closed | Open | Closed | |||
Planned Release | 1.3.0 | ||||
2007-08-31 | kleshov | Attached File | - | Added cs8900if.c, #13845 | |
2007-07-19 | kieranm | Status | None | Postponed | |
2007-07-19 | kleshov | Attached File | - | Added cs8900if.c.patch, #13396 |
Powered by Savane 3.13-3230.
Corresponding source code
Put in a request to join the lwip group through savannah. I can then add you as a member, and this will give you CVS write access.
We ask that all changes to CVS are first mentioned as either a bug, patch or task on savannah so that other developers can contribute. In your case this is unlikely to be much of an issue as you'll mostly be dealing with the cs8900 driver rather than the core code.
If you want me to move the cs8900 driver code in the contrib module out of the "old" section, let me know which directories I should be looking at and I can make this change.