lwIP - A Lightweight TCP/IP stack - Bugs: bug #46384, Segment size calculation bug with...
You are not allowed to post comments on this tracker with your current authentication level.
bug #46384: Segment size calculation bug with MSS != TCP_MSS
Submitter: | Deomid Ryabkov <rojer> | ||
Submitted: | Thu 05 Nov 2015 11:59:35 PM UTC | ||
Category: | TCP | Severity: | 3 - Normal |
Item Group: | Faulty Behaviour | Status: | Fixed |
Privacy: | Public | Assigned to: | goldsimon |
Open/Closed: | Closed | Planned Release: | None |
lwIP version: | git head |
Wed 16 Mar 2016 07:42:04 PM UTC, comment #5: |
Simon Goldschmidt <goldsimon> |
Wed 16 Mar 2016 03:43:40 PM UTC, comment #4: Oh, now I see: this could happen when writing segments in state SYN_SENT, before the peer SYN (including the MSS option) arrived... |
Simon Goldschmidt <goldsimon> |
Fri 04 Mar 2016 09:41:33 PM UTC, comment #3: You're wrong there: the mss option must only be sent with syn and you're not allowed to enqueue data on a PCB that is not yet established.
|
Simon Goldschmidt <goldsimon> |
Thu 19 Nov 2015 09:12:57 AM UTC, comment #2: please correct me if i'm wrong, but it seems that pcb->mss could be adjusted at any time via an option from the peer, when buffer has already been allocated. thus, we need the limit here anyway, just in case.
|
Deomid Ryabkov <rojer> |
Thu 19 Nov 2015 06:47:25 AM UTC, comment #1:
|
Simon Goldschmidt <goldsimon> |
Thu 05 Nov 2015 11:59:35 PM UTC, original submission:
tcp_write() performs segmentation in 3 phases: (1) filling remaining portion of the last segment's pbuf, then (2) filling the segment with a new pbuf up to MSS (- headers), then (3) creating a new segment.
|
Deomid Ryabkov <rojer> |
No files currently attached
Depends on the following items: None found
Items that depend on this one: None found
There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.
Follow 5 latest changes.
Date | Changed by | Updated Field | Previous Value | => | Replaced by |
---|---|---|---|---|---|
2016-03-16 | goldsimon | Status | In Progress | Fixed | |
Open/Closed | Open | Closed | |||
2016-03-16 | goldsimon | Status | Works For Me | In Progress | |
2016-03-04 | goldsimon | Status | None | Works For Me | |
Assigned to | None | goldsimon |
Powered by Savane 3.13-02a9.
Corresponding source code
Fixed like proposed in OP, thanks for reporting.