lwIP - A Lightweight TCP/IP stack - Bugs: bug #19161, lwip_select mishandles sub 500us...
You are not allowed to post comments on this tracker with your current authentication level.
bug #19161: lwip_select mishandles sub 500us delays
Submitter: | Rob Stedman <robstedman1> | ||
Submitted: | Tue 27 Feb 2007 07:14:29 AM UTC | ||
Category: | sockets/netconn | Severity: | 2 - Minor |
Item Group: | Faulty Behaviour | Status: | Fixed |
Privacy: | Public | Assigned to: | kieranm |
Open/Closed: | Closed | Planned Release: | None |
lwIP version: | None |
Jump to the original submission
Mon 26 Mar 2007 11:53:30 AM UTC, comment #6: |
Jonathan Larmour <jifl> |
Mon 26 Mar 2007 11:49:59 AM UTC, comment #5: Okay, it's probably best I assign a new bug for this and take it rather than overload this one.
|
Jonathan Larmour <jifl> |
Mon 26 Mar 2007 10:57:48 AM UTC, comment #4: I'm not sure I understand quite what the problem is here, but documenting that anything less than 1ms in timeout will be rounded up is a good idea. Rounding it down to 0 (as it was) was clearly incorrect behaviour.
|
Kieran Mansley <kieranm> |
Fri 23 Mar 2007 06:14:17 AM UTC, comment #3: I see the fix is to tweak it to 1ms, which is fair enough in the current context. The same thing happens in api_lib.c in two places - a 1ms timeout is used in order to be interpreted as a poll. I'd be concerned that ports may unnecessarily wait 1ms though. I know in my port I map 1ms waits to a poll. Perhaps we should just do the right thing and either:
|
Jonathan Larmour <jifl> |
Wed 28 Feb 2007 12:54:02 PM UTC, comment #2: Fixed checked in to CVS. Please review and update if there's still a problem. |
Kieran Mansley <kieranm> |
Tue 27 Feb 2007 08:54:36 AM UTC, comment #1: Sounds like we need to guarantee that a non-zero timeout results in a non-zero value passed to sys_sem_wait_timeout. Should be a straightforward fix. |
Kieran Mansley <kieranm> |
Tue 27 Feb 2007 07:14:29 AM UTC, original submission:
My understanding is lwip_select uses sys_sem_wait_timeout when pending the caller.
|
Rob Stedman <robstedman1> |
No files currently attached
Depends on the following items: None found
Items that depend on this one: None found
There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.
Follow 4 latest changes.
Date | Changed by | Updated Field | Previous Value | => | Replaced by |
---|---|---|---|---|---|
2007-02-28 | kieranm | Status | None | Fixed | |
Open/Closed | Open | Closed | |||
2007-02-27 | kieranm | Severity | 3 - Normal | 2 - Minor | |
Assigned to | None | kieranm |
Powered by Savane 3.13-d3ae.
Corresponding source code
Oh scratch that - all the API code has changed in the last week and this aspect has gone. Forget it :-).