lwIP - A Lightweight TCP/IP stack - Bugs: bug #21655, DHCP doesn't work reliably with...
You are not allowed to post comments on this tracker with your current authentication level.
bug #21655: DHCP doesn't work reliably with multiple netifs
Submitter: | Simon Goldschmidt <goldsimon> | ||
Submitted: | Tue 27 Nov 2007 09:21:24 PM UTC | ||
Category: | UDP | Severity: | 3 - Normal |
Item Group: | Faulty Behaviour | Status: | Fixed |
Privacy: | Public | Assigned to: | goldsimon |
Open/Closed: | Closed | Planned Release: | None |
lwIP version: | None |
Jump to the original submission
Tue 04 Dec 2007 09:16:14 PM UTC, comment #16: |
Simon Goldschmidt <goldsimon> |
Mon 03 Dec 2007 08:35:24 PM UTC, comment #15: Checked in. The only thing missing now is a real-world-test. Hope I'll be able to do this with a virtual machine... |
Simon Goldschmidt <goldsimon> |
Mon 03 Dec 2007 04:51:21 PM UTC, comment #14: Sorry, of course it does. Seems like I mixed up 'inp' and 'netif_list'...
|
Simon Goldschmidt <goldsimon> |
Mon 03 Dec 2007 03:09:30 PM UTC, comment #13: Oh, I didn't think it was the same - I thought the version I gave would skip inp in netif_list.
|
Jonathan Larmour <jifl> |
Mon 03 Dec 2007 07:26:51 AM UTC, comment #12: Your code does the same as my code, but your coed it's a little better to read! |
Simon Goldschmidt <goldsimon> |
Sun 02 Dec 2007 10:49:14 PM UTC, comment #11: I'm not clear on why the first conditional is anything other than:
|
Jonathan Larmour <jifl> |
Sun 02 Dec 2007 02:45:16 PM UTC, comment #10:
|
Simon Goldschmidt <goldsimon> |
Fri 30 Nov 2007 03:30:58 PM UTC, comment #9: I'm not sure, but what it might be is to allow multiple netifs on the same underlying hardware interface, i.e. IP aliases. The hardware interface doesn't know about matching IPs, so it would have to just pick one netif to pass it up with. But ip_input would need to sort it out and get a proper match on the interface.
|
Jonathan Larmour <jifl> |
Fri 30 Nov 2007 08:52:06 AM UTC, comment #8: The UDP patch works kind of nice, I'll check it in.
|
Simon Goldschmidt <goldsimon> |
Thu 29 Nov 2007 07:49:07 AM UTC, comment #7:
|
Simon Goldschmidt <goldsimon> |
Thu 29 Nov 2007 01:33:16 AM UTC, comment #6: The first patch looks good, thanks (although I can't test it :-| ).
|
Jonathan Larmour <jifl> |
Wed 28 Nov 2007 09:48:30 PM UTC, comment #5: Here's patch for udp_input (first file).
|
Simon Goldschmidt <goldsimon> |
Wed 28 Nov 2007 12:07:43 PM UTC, comment #4:
|
Simon Goldschmidt <goldsimon> |
Wed 28 Nov 2007 08:54:26 AM UTC, comment #3: But we already have the netif in udp_input. Searching it based on the transaction ID seems kind of weird... We only have to find the correct pcb. And keep in mind that udp_input also includes a hack to receive DHCP messages, I only would make that hack a little bit 'better' :-) |
Simon Goldschmidt <goldsimon> |
Wed 28 Nov 2007 08:49:03 AM UTC, comment #2: Can't we use the dhcp's transaction id (which is 32bits) to initialize it with the netif* value or a netif index ? (but I doesn't read the code)
|
Frédéric Bernon <fbernon> |
Wed 28 Nov 2007 06:51:53 AM UTC, comment #1: Just an idea (as a reminder for later):
|
Simon Goldschmidt <goldsimon> |
Tue 27 Nov 2007 09:21:24 PM UTC, original submission:
This is from reading the code only but I'm pretty sure:
|
Simon Goldschmidt <goldsimon> |
Depends on the following items: None found
Items that depend on this one: None found
There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.
Follow 7 latest changes.
Date | Changed by | Updated Field | Previous Value | => | Replaced by |
---|---|---|---|---|---|
2007-12-04 | goldsimon | Status | In Progress | Fixed | |
Open/Closed | Open | Closed | |||
2007-12-02 | goldsimon | Attached File | - | Added ip_input_search_netif.patch, #14535 | |
2007-11-29 | goldsimon | Status | None | In Progress | |
Assigned to | None | goldsimon | |||
2007-11-28 | goldsimon | Attached File | - | Added udp.c_dhcpinput.patch, #14504 | |
Attached File | - | Added ip.c_ip_input_dhcp_faster.patch, #14505 |
Powered by Savane 3.13-f8d8.
Corresponding source code
Tested with 2 pktif-interfaces running under win32 (each with a different MAC address but connected to the same physical network). They both get an IP so everything seems to be fine.