patchSkencil - Patches: patch #3568, SVG 1.1 Styling support

 
 

You are not allowed to post comments on this tracker with your current authentication level.

patch #3568: SVG 1.1 Styling support

Submitted by:  None
Submitted on:  Sun 12 Dec 2004 10:58:47 AM UTC  
 
Category:  0.7.x Priority:  1 - Later
Status:  None Privacy:  Public
Assigned to:  None Originator Email:  -email is unavailable-
Open/Closed:  Open

Tue 28 Dec 2004 05:59:02 PM UTC, comment #2: 

Thanks for your comments.

In short, i'll revamp my changes and the patch and post it again.

I figured, that the method which handles all the style properties would become large if I continue to implement other svg style properties SVG 1.1 [1] defines.

[1] - http://www.w3.org/TR/SVG11/styling.html#SVGStylingProperties

Roman Joost <romanofski>
Sun 19 Dec 2004 01:05:12 AM UTC, comment #1: 

The main issue I have with this patch is that it makes the
svg import filter worse.  Some things that were supported by
the old code don't work anymore:

  - the "style" attribute leads to exceptions ("SVGHandler
    instance has no attribute 'try_add_style'").  So it's
    basically broken for SVG 1.0 files and SVG 1.1 files
    that use the style attribute which is perfectly valid in
    1.1, too.

  - The old code supported some style attributes that are
    not implemented in the patch yet (e.g. stroke-linecap,
    stroke-linejoin, font-family, font-size and text-anchor)

  - It doesn't handle the transformations correctly anymore.
    Transformation have to affect the stroke width, for
    example.

Also, I'm not sure the style handling needs to be in a
separate class in the first place.  What's the motivation
for this?

Some other things that can be improved in this patch:

 - Patches should do only one thing.  This patch contains
   not only code to handle the styling attributes, it also
   has code that appears to deal with gradient stops and
   rounded rectangles.  Those parts shoud be removed from
   this patch.  They could be submitted as separate patches,
   of course.

 - A ChangeLog entry and perhaps even some test cases that
   exercise the new features would make it easier for me to
   review and apply the patch.

Bernhard Herzog <bh>
Project Administrator
Sun 12 Dec 2004 10:58:47 AM UTC, original submission:  

I moved the styling of the svloader into another class, which should keep track of all the styling necessary for an element. This patch adds not much new, but it's at least now possible to import SVG files with colors and such.

Anonymous

 

Attached Files
file #8162:  svgloader.py.patch added by None (15KiB - text/x-patch - svgloader.py patch)

 

Depends on the following items: None found

Items that depend on this one: None found

 

CC list is empty

 

Do you think this task is very important?
If so, you can add your encouragement to it.
This task has 0 encouragements so far.

Only logged-in users can vote.

 

 

 

Follow 3 latest changes.

Date Changed by Updated Field Previous Value => Replaced by
2004-12-19 bernhard Carbon-Copy- => Added bernhard
    Carbon-Copy- => Added bh
2004-12-12 None Attached File- => Added svgloader.py.patch, #3937

Back to the top


Powered by Savane 3.5