mldonkey, a multi-networks file-sharing client - Patches: patch #3717, Improvement of patch 3672...
You are not allowed to post comments on this tracker with your current authentication level.
patch #3717: Improvement of patch 3672 (additonally bugfix for wrong Hi/Lo-ID in serverlist)
Submitter: | Fritz Mock <surround> | ||
Submitted: | Thu 03 Feb 2005 11:39:51 PM UTC | ||
Category: | Bug fixes | Priority: | 5 - Normal |
Status: | Done | Assigned to: | None |
Open/Closed: | Closed |
Jump to the original submission
Sat 05 Mar 2005 12:41:45 AM UTC, comment #15: |
Amorphous <amorphous> |
Fri 04 Mar 2005 08:03:53 PM UTC, comment #14:
|
Fritz Mock <surround> |
Fri 04 Mar 2005 02:10:00 PM UTC, comment #13: ---
|
Amorphous <amorphous> |
Fri 04 Mar 2005 10:04:14 AM UTC, comment #12:
let send_this_id = if not (!!force_high_id || !!force_client_high_id) && low_id server_cid && Ip.any <> server_cid then server_cid else client_ip None This code derives "I am firewaleld" from the combination of force_high_id and force_client_high_id. And indeed, the code has nothing nothing to do with connecting to servers, but it has something in common with it. Both things have in common that the must differ between firewalled/non-firewalled and your condition is insufficent to do that for both situations. Your aproach to decide about firewalled/non-firewalled might solve one specific problem, but is unusable in the other place(s). Why would we want to use different aproaches to decided about the firewalled-thingy in different places of the code? Show me how you are going to fix mldonkey, without throwing in ever more options for each individual location and show me how you are going to create something rock-solid. Your changes are certainly not a basis for further attempt to fix the other problems mldonkey has as firewalled client. |
Fritz Mock <surround> |
Fri 04 Mar 2005 12:38:43 AM UTC, comment #11: ---
|
Amorphous <amorphous> |
Thu 03 Mar 2005 11:33:40 PM UTC, comment #10:
|
Anonymous |
Wed 02 Mar 2005 03:37:37 PM UTC, comment #9: I adapted your patch a bit. Please check the link for the changes:
|
Amorphous <amorphous> |
Sun 20 Feb 2005 02:56:33 AM UTC, comment #8: applied 2-5-28-1 |
spiralvoice <spiralvoice> |
Mon 07 Feb 2005 10:24:40 AM UTC, comment #7:
|
Fritz Mock <surround> |
Mon 07 Feb 2005 10:21:54 AM UTC, comment #6: @devein:
|
Fritz Mock <surround> |
Mon 07 Feb 2005 05:05:08 AM UTC, comment #5: There is an option force_high_id and IMHO that should be used, instead of a new option firewalled_mode. If it is off we should autodetect if we are firewalled. Or is there something this wouldn't solve?
|
Amorphous <amorphous> |
Sun 06 Feb 2005 12:47:18 PM UTC, comment #4: imho the best solution would be to interpret assigned IP from mldonkey server (default "use_server_ip" is true, AFAIR).
|
devein |
Sun 06 Feb 2005 01:13:23 AM UTC, comment #3:
|
Fritz Mock <surround> |
Fri 04 Feb 2005 10:23:44 AM UTC, comment #2: Why not set 'client_ip' and 'force_client_ip' to fixed values as proposed when 'firewalled_mode=true' ? Would make the system some more tamper proof... |
White_FrosT |
Thu 03 Feb 2005 11:49:15 PM UTC, comment #1:
|
Fritz Mock <surround> |
Thu 03 Feb 2005 11:39:51 PM UTC, original submission:
|
Fritz Mock <surround> |
Depends on the following items: None found
Items that depend on this one: None found
There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.
Follow 3 latest changes.
Date | Changed by | Updated Field | Previous Value | => | Replaced by |
---|---|---|---|---|---|
2005-02-20 | spiralvoice | Status | None | Done | |
Open/Closed | Open | Closed | |||
2005-02-03 | surround | Attached File | - | Added lowid.patch, #4139 |
Powered by Savane 3.13-f762.
Corresponding source code
for the record: the discussion was continued on irc in private and we agreed that firewalled support for mldonkey is not realy clean and complete, but as long as there is no better patch my applied version is left as is.