patchSkencil - Patches: patch #3844, base patch


You are not allowed to post comments on this tracker with your current authentication level.

patch #3844: base patch

Submitter:  None
Submitted:  Tue 22 Mar 2005 03:06:37 PM UTC
Category:  0.7.x Priority:  5 - Normal
Status:  None Privacy:  Public
Assigned to:  None Originator Email:  -email is unavailable-
Open/Closed:  Open

Sun 03 Apr 2005 08:16:41 PM UTC, comment #2: 

Thanks for splitting this up a little.  However, this patch is still very big.  Too big to be applied in one go.  Would it be possible to split it up further?

I did look at the menu code a bit, though.  Why is there a new file which contains large parts of  Wouldn't it have been better to simply put it all in to

In tmpmenu, ListMenu doesn't seem to be used for anything except as a base class for Menu, so it would seem a bit clearer for now to merge these classes.

In tmpmenu, build_menu_tree checks whether description is an instance of MenuNode.  AFAICT that is never the case.  All callers always pass a sequence of (string or None) as the description.

Bernhard Herzog <bh>
Group administrator
Wed 23 Mar 2005 05:45:23 PM UTC, comment #1: 

The patch was against an older cvs version. Sorry! This one should work.

Tue 22 Mar 2005 03:06:37 PM UTC, original submission:  

This is ment to be a first patch in a series of patches breaking my recent changes to skencil 0.7 into smaller more digestable pieces. It provides many changes to the gui infrastructure and also some new dialogs. The most visibile change is the inspector panel which bundles the line, fill and property dialogs. Changes in the dialog are now immediately applied to the drawing. However, this can be switched off. The modal color dialog is replaced by a color panel which is inspired by Next Steps color chooser. Colors can now be transfered between most dialogs
by drag and drop.
The patch is applied e.g. by

cd skencil-devel/
patch -p1 -l < ../base.patch
There are lots of problems and todos left over. To name only some:
- with the transition to pygtk 2.4 some problems with the fill panel appeared concerning gradients and hatching, also lots of warnings
- the property inspection card is quite unfinished
- the old color is not always set correctly in the color panel
- a drawing bug of the widget renderer (sometimes hidden widgets are drawn)
- clean up & documentation



(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attached Files
file #8607:  base.patch_rev1 added by None (121KiB - application/octet-stream - base.patch_rev1)
file #8597:  base.patch added by None (118KiB - application/octet-stream - patch)


Depends on the following items: None found

Items that depend on this one: None found


CC list is empty


There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.


Follow 3 latest changes.

Date Changed by Updated Field Previous Value => Replaced by
2005-03-23 None Attached File- Added base.patch_rev1, #4383
2005-03-22 None Attached File- Added base.patch, #4373
    Carbon-Copy- Added ecker --AT-- physik --DOT-- hu-berlin --DOT-- de

Back to the top

Powered by Savane 3.13-58d6.
Corresponding source code