patchmldonkey, a multi-networks file-sharing client - Patches: patch #3993, Enable signal handling on MinGW

 
 

You are not allowed to post comments on this tracker with your current authentication level.

patch #3993: Enable signal handling on MinGW

Submitter:  spiralvoice <spiralvoice>
Submitted:  Mon 09 May 2005 12:56:56 PM UTC
 
Category:  Bug fixes Priority:  9 - Immediate
Status:  Done Assigned to:  None
Open/Closed:  Closed
* Mandatory Fields

Add a New Comment (Rich Markup)
   

Comment Type & Canned Response:
       No canned response available

 

Tue 17 May 2005 01:19:37 PM UTC, comment #3: 

Applied 2005/05/17

spiralvoice <spiralvoice>
Project Administrator
Tue 10 May 2005 09:34:07 AM UTC, comment #2: 

Before this patch MinGW ignored all signals:

./src/config/mingw/mlUnix.ml: let set_signal signal f = ()

During patch creation I found out that those three signals
(for which one "if Autoconf.system <> "windows" then" should be enough)
do not exist on MinGW. All other platforms use

./src/config/unix/mlUnix.ml: let set_signal signal f = Sys.set_signal signal f

so you can savely assume those signals exist there as this code
is unchanged since ages.

spiralvoice <spiralvoice>
Project Administrator
Tue 10 May 2005 07:57:38 AM UTC, comment #1: 

+  if Autoconf.system <> "windows" then
+    MlUnix.set_signal  Sys.sighup

Is this a good comparison? It assumes all OS except windows accepts a special signal. There are 3 if-statements like this in the patch.

Knocker <knocker>
Mon 09 May 2005 12:56:56 PM UTC, original submission:  

CTRL+C did terminate the core without saving ini files...
This is due to disabled signal handling on MinGW by MLDonkey which
is fixed with this patch.

Sys.sigchld, Sys.sighup and Sys.sigpipe do not exist on MinGW,
if used they cause an exception on core start so I disabled
them on Windows platforms. They donĀ“t provide important
functions for the core anyway.

spiralvoice <spiralvoice>
Project Administrator

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #8739:  mingw_signal.patch added by spiralvoice (3KiB - text/x-patch)

 

Depends on the following items: None found

Items that depend on this one: None found

 

CC list is empty

 

There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

Only logged-in users can vote.

 

 

 

 

Follow 3 latest changes.

Date Changed by Updated Field Previous Value => Replaced by
2005-05-19 spiralvoice Open/ClosedOpen Closed
2005-05-19 amorphous StatusNone Done
2005-05-09 spiralvoice Attached File- Added mingw_signal.patch, #4582

Back to the top


Powered by Savane 3.9