patchmldonkey, a multi-networks file-sharing client - Patches: patch #3996, EDK: Support auxports

 
 

You are not allowed to post comments on this tracker with your current authentication level.

patch #3996: EDK: Support auxports

Submitter:  spiralvoice <spiralvoice>
Submitted:  Tue 10 May 2005 08:23:35 PM UTC
   
 
Category:  Improved interfaces Priority:  7 - High
Status:  Done Assigned to:  None
Open/Closed:  Closed

Jump to the original submission

Tue 17 May 2005 01:19:43 PM UTC, comment #10: 

Applied 2005/05/17

spiralvoice <spiralvoice>
Group administrator
Sun 15 May 2005 12:18:02 PM UTC, comment #9: 

see this link for more discussion on this patch:
http://mldonkey.berlios.de/modules.php?name=Forums&file=viewtopic&t=3542

Amorphous <amorphous>
Fri 13 May 2005 08:41:21 PM UTC, comment #8: 

Updated patch to avoid having one server multiple times in serverlist.
http://www.mldonkey.org/phpbb2/viewtopic.php?p=31364#31364

Index: src/networks/donkey/donkeyServers.ml
===================================================================
--- src/networks/donkey/donkeyServers.ml        (revision 107)
+++ src/networks/donkey/donkeyServers.ml        (working copy)
@@ -269,7 +269,7 @@
        set_server_state s (NotConnected (reason, -1));
        s.server_master <- false;
        (match !DonkeyGlobals.master_server with
-          | Some ss when s = ss ->
+          | Some ss when s == ss ->
               DonkeyGlobals.master_server := None;
           | _ -> ());

spiralvoice <spiralvoice>
Group administrator
Fri 13 May 2005 03:40:38 PM UTC, comment #7: 

I'm not sure, but the server sends all the ports it uses, right?
Then why not use an field server_ports_list where the real one is the first (so we can save and display that list)? Then we should allways display server_port and only in addition display server_ports_list.

Amorphous <amorphous>
Wed 11 May 2005 08:44:51 PM UTC, comment #6: 

Ok. I thought it would be easier to just display the real port in DonkeyInteractive.server_ops.op_server_info if it had one (which I assume doesn't affect the commonserver (server_addr field) which is the one that is saved/communicated amongst clients) if it was only for display purposes.

Anonymous
Wed 11 May 2005 04:53:49 PM UTC, comment #5: 

"What is the point of reporting the 'fake' port when there is a 'real' one?"
The "fake" one is the real one, some ISPs block this port so
Lugdunum invented auxports, to connect a server on ports 80,443,25
to circumvent this. But clients are oblidged to report the real
port (4661 for example) to other clients, so both ports have to be
stored by clients. Why Lugdunum did not switch his server from
port 4661 to 80 is a question you have to ask him.

"Shouldn't server_port store the real port?"
Users who use this feature canĀ“t connect on port 4661, so they
use port 80 which has to be stored in server_port and servers.ini.
Real_port is only used to report data about connected server to
other users.

spiralvoice <spiralvoice>
Group administrator
Wed 11 May 2005 04:48:31 PM UTC, comment #4: 

"None of the other networks use realport, so why add the field to all the networks?"
Otherwise the code does not compile as the structure of this data field has to be the same in all networks.

spiralvoice <spiralvoice>
Group administrator
Wed 11 May 2005 02:36:10 PM UTC, comment #3: 

(None of the other networks use realport, so why add the field to all the networks? This doesn't make sense)

Anonymous
Wed 11 May 2005 02:33:42 PM UTC, comment #2: 

I don't understand this. (the discussion is in french) so please explain a bit more.

What is the point of storing server_port if there is also a realport?

Why is "info.G.server_port" not reporting the real port if there is one instead of this hack?  (What is the point of reporting the 'fake' port when there is a 'real' one?)

Shouldn't server_port store the real port?

Anonymous
Tue 10 May 2005 08:26:32 PM UTC, comment #1: 

Using this feature in GUI protocol should be coded by someone with more knowledge than me;-)

spiralvoice <spiralvoice>
Group administrator
Tue 10 May 2005 08:23:35 PM UTC, original submission:  

Connect EDK servers on port 80,443 or 25 to circumvent ISP blocked ports.

Patch ported from Knocker:
https://opensvn.csie.org/viewcvs.cgi?root=mlnet&view=rev&rev=311

plus print realport in HTML and Telnet interface. I checked with ngrep, it works good.
More infos about this feature here:
http://www.ed2k.ch/modules/ipboard/index.php?showtopic=3386&hl=

spiralvoice <spiralvoice>
Group administrator

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attached Files
file #8833:  3996.patch added by spiralvoice (17KiB - text/x-patch - updated patch)

 

Depends on the following items: None found

Items that depend on this one: None found

 

CC list is empty

 

There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

 

Follow 5 latest changes.

Date Changed by Updated Field Previous Value => Replaced by
2005-06-01 spiralvoice Open/ClosedOpen Closed
2005-06-01 amorphous StatusNone Done
2005-05-13 spiralvoice Attached File#4585 Removed
2005-05-13 spiralvoice Attached File- Added 3996.patch, #4605
2005-05-10 spiralvoice Attached File- Added auxports2.patch, #4585

Back to the top

Powered by Savane 3.13-4b48.
Corresponding source code