patchmldonkey, a multi-networks file-sharing client - Patches: patch #4043, Avoid locking shared files

 
 

You are not allowed to post comments on this tracker with your current authentication level.

patch #4043: Avoid locking shared files

Submitter:  spiralvoice <spiralvoice>
Submitted:  Wed 25 May 2005 10:46:59 AM UTC
   
 
Category:  Bug fixes Priority:  5 - Normal
Status:  Done Assigned to:  amorphous
Open/Closed:  Closed

Mon 30 May 2005 12:04:48 AM UTC, comment #3: 

See also patch #4057

spiralvoice <spiralvoice>
Group administrator
Sat 28 May 2005 11:21:36 AM UTC, comment #2: 

Applied 2005/05/28

spiralvoice <spiralvoice>
Group administrator
Fri 27 May 2005 06:51:36 PM UTC, comment #1: 

Added getsize.patch for another related fix:

Without this new patch the following happens:

close_fds -> all files are closed
and are re-opened for up- and downloading files

reshare -> also not uploading files are re-opened and stay open

with this patch after close_fds and reshare only up-/downloading files are open.

These two patches here solve bug #12415.

spiralvoice <spiralvoice>
Group administrator
Wed 25 May 2005 10:46:59 AM UTC, original submission:  

Files were locked due to rw access using getsize64 function.
See bug #12415 for more details.

Quote from the bug report:
"- Files cannot be moved or renamed, but can be deleted np."
This is still the case, I believe after getsize and other functions
the file descriptor is not closed. I will further investigate.

spiralvoice <spiralvoice>
Group administrator

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attached Files
file #8885:  getsize.patch added by spiralvoice (439B - text/x-patch)
file #8878:  read.patch added by spiralvoice (21KiB - application/octet-stream)

 

Depends on the following items: None found

Items that depend on this one: None found

 

CC list is empty

 

There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

 

Follow 6 latest changes.

Date Changed by Updated Field Previous Value => Replaced by
2005-07-07 spiralvoice StatusNone Done
    Open/ClosedOpen Closed
2005-06-22 spiralvoice Assigned toNone amorphous
2005-05-27 spiralvoice SummaryAllow playing shared media files on Windows Avoid locking shared files
2005-05-27 spiralvoice Attached File- Added getsize.patch, #4652
2005-05-25 spiralvoice Attached File- Added read.patch, #4645

Back to the top

Powered by Savane 3.13-bb6a.
Corresponding source code