patchmldonkey, a multi-networks file-sharing client - Patches: patch #4184, support guarding.p2p in zip/gz/bz2...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

patch #4184: support guarding.p2p in zip/gz/bz2 format

Submitter:  None
Submitted:  Mon 18 Jul 2005 10:24:37 PM UTC
   
 
Category:  Improved interfaces Priority:  5 - Normal
Status:  Done Assigned to:  None
Originator Email:  -email is unavailable- Open/Closed:  Closed

Jump to the original submission

Sat 23 Jul 2005 02:22:03 PM UTC, comment #17: 

Committed 2005/07/23

spiralvoice <spiralvoice>
Group administrator
Sat 23 Jul 2005 01:49:36 PM UTC, comment #16: 

Howto compile on Windows:
http://www.tomms-server.org/index.php?name=PNphpBB2&file=viewtopic&t=85

Essential part: compile libbz2 yourself according to:
http://lists.gnupg.org/pipermail/gnupg-devel/2003-December/020650.html
and also replace the Cygwin version of libbz2.a with your
self-compiled file.

spiralvoice <spiralvoice>
Group administrator
Fri 22 Jul 2005 04:50:31 PM UTC, comment #15: 

Amorphous wrote:
"i haven't tested it but doesn't the http-handler already support gzipped content, so it may already work with the appropriate http headers?"
My solution does not work inline, it extracts the archives to a
temp file. Archives mentioned in web_infos are also transfered to
harddisk and then extracted there, the temp file is removed after
building the block list. But it makes it possible to use either
web_infos or a local downloaded file.

spiralvoice <spiralvoice>
Group administrator
Fri 22 Jul 2005 04:33:41 PM UTC, comment #14: 

Updated patch for current CVS, take into account that bz2 extract
segfaults on OpenBSD, also proper exception handling and nicer
logout.
Tar files won't be supported (patches welcome), but i don't see
a sense in that. But tar.ml is provided so it can be used.

This is the release version of this patch and will be applied
shortly if no one objects.

spiralvoice <spiralvoice>
Group administrator
Thu 21 Jul 2005 12:56:41 PM UTC, comment #13: 

Confirmed working on Solaris/Sparc

spiralvoice <spiralvoice>
Group administrator
Tue 19 Jul 2005 09:37:21 AM UTC, comment #12: 

I tested it with a guarding.zip in OS X. Seems to work smoothly. Ouput:
CommonWeb: QUERY URL http://www.openmedia.info/downloads/guarding.p2p.zip
CommonWeb: QUERY URL http://ocbmaurice.dyndns.org/pl/slist.pl/server.met?download/server-best.met
CommonWeb: QUERY URL http://download.overnet.org/contact.dat
[NS]: Resolving www.openmedia.info ...[NS]: done
[NS]: Resolving [ocbmaurice.dyndns.org] ...[NS]: done
[NS]: Resolving [www2.openmedia.info] ...[NS]: done
[NS]: Resolving [home.ebmnet.ch] ...[NS]: done
FILE LOADED
102 SERVERS ADDED
web_infos.file_kinds p2p /tmp/http_40e702.p2p.zip
ipset.load /tmp/http_40e702.p2p.zip
ipset.load guarding.p2p found in zip file
load_merge guarding.p2p
IP blacklist: 92243 ranges loaded

I think this is the relevant configure output:
checking zlib.h usability... yes
checking zlib.h presence... yes
checking for zlib.h... yes
checking for BZ2_bzReadOpen in -lbz2... yes
checking bzlib.h usability... yes
checking bzlib.h presence... yes
checking for bzlib.h... yes

White_FrosT
Mon 18 Jul 2005 11:57:50 PM UTC, comment #11: 

Added guarding_zip2.patch which should work for systems which lack
bzip2.
Please test this patch on Mac OS X, it is known to work on FreeBSD.
On OpenBSD I had problems detecting bzip2, have to use some Autoconf magic...

spiralvoice <spiralvoice>
Group administrator
Mon 18 Jul 2005 10:24:37 PM UTC, comment #10: 

This item has been reassigned from the project mldonkey, a multi-networks file-sharing client task tracker to your tracker.

The original report is still available at task #4387

Following are the information included in the original report:

[field #0]                  Item ID: 4387
[field #1]                 Group ID: 1409
[field #2]              Open/Closed: Open
[field #3]                 Severity: 3 - Normal
[field #4]                  Privacy: Public
[field #5]                 Category: Core
[field #6]             Submitted by: None
[field #7]              Assigned to: None
[field #8]             Submitted on: Fre 08.07.2005 um 09:34
[field #9]                  Summary: support zipped guarding.p2p
[field #10]      Original Submission: support for guarding.p2p.zip files will help both the supplies for guarding.p2p lists and the user that has to use external scripts to work with them
[field #12]               Item Group: None
[field #13]                   Status: None
[field #14]        Component Version: None
[field #15]         Platform Version: None
[field #16]          Reproducibility: None
[field #17]               Size (loc): None
[field #18]            Fixed Release: None
[field #19]          Planned Release: None
[field #20]                   Effort: 0.00
[field #24]                 Priority: 5 - Normal
[field #25]          Should Start On: Fre 08.07.2005 um 00:00
[field #26]    Should be Finished on: Fre 08.07.2005 um 00:00
[field #27]         Percent Complete: 0%
[field #29]                  Release: None
[field #54]     Custom Select Box #1: None
[field #55]     Custom Select Box #2: None
[field #56]     Custom Select Box #3: None
[field #57]     Custom Select Box #4: None
[field #58]     Custom Select Box #5: None
[field #59]     Custom Select Box #6: None
[field #60]     Custom Select Box #7: None
[field #61]     Custom Select Box #8: None
[field #62]     Custom Select Box #9: None
[field #63]    Custom Select Box #10: None

spiralvoice <spiralvoice>
Group administrator
Mon 18 Jul 2005 06:38:33 PM UTC, comment #9: 

Added support for gz files (still no tar files!), please test

spiralvoice <spiralvoice>
Group administrator
Mon 18 Jul 2005 05:52:38 PM UTC, comment #8: 

Added support for bz2 files (not tar.bz2!), please test

spiralvoice <spiralvoice>
Group administrator
Mon 18 Jul 2005 04:40:35 PM UTC, comment #7: 

Attached guarding_zip.patch, all files with web_kind "guarding.p2p"
and extension ".zip" or ".p2p.zip" are unzipped and loaded.

Use this line in web_infos:

  ("guarding.p2p", 96, "http://www.openmedia.info/downloads/guarding.p2p.zip");

or put the file mentioned above in the core directory.

spiralvoice <spiralvoice>
Group administrator
Mon 18 Jul 2005 03:23:29 PM UTC, comment #6: 

I am working on it, using zip files works already, just found this:
http://raevnos.pennmush.org/code/camlzip/
A patched version of camlzip with tar and bz2 support:-)

spiralvoice <spiralvoice>
Group administrator
Tue 12 Jul 2005 01:48:35 PM UTC, comment #5: 

Just been browsing a bit through the sources. The loading of the list is done in src/utils/net/ip_set.ml in the function 'load'. If we check here if it is a .zip and extract if needed, only the download url needs to be changed. The camlzip files can be used for extraction.

White_FrosT
Tue 12 Jul 2005 10:01:17 AM UTC, comment #4: 

We could include the code from CamlZip (http://cristal.inria.fr/~xleroy/software.html) to convert the guarding.p2p.zip to guarding.p2p.
I guess we would just need to include zip.ml/mli from this project and call it once if the downloaded file ends in '.zip' like this:

let extract zipfile =
  let ic = Zip.open_in zipfile in
  List.iter (extract_entry ic) (Zip.entries ic);
  Zip.close_in ic


White_FrosT
Sat 09 Jul 2005 07:42:46 AM UTC, comment #3: 

doesnt zlib support zip archives? the zlib website indicates it supports decompressing zip files (http://www.zlib.net)

though i agree that gzip and bzip2 are better zip is whats commonly used

Anonymous
Fri 08 Jul 2005 09:34:35 AM UTC, comment #2: 

This item has been reassigned from the project mldonkey, a multi-networks file-sharing client bugs tracker to your tracker.

The original report is still available at bugs #10464

Following are the information included in the original report:

[field #0]                  Item ID: 10464
[field #1]                 Group ID: 1409
[field #2]              Open/Closed: Open
[field #3]                 Severity: 3 - Normal
[field #4]                  Privacy: Public
[field #5]                 Category: Core
[field #6]             Submitted by: None
[field #7]              Assigned to: None
[field #8]             Submitted on: Die 21.09.2004 um 19:49
[field #9]                  Summary: support zipped guarding.p2p
[field #10]      Original Submission: support for guarding.p2p.zip files will help both the supplies for guarding.p2p lists and the user that has to use external scripts to work with them
[field #12]               Item Group: Feature request
[field #13]                   Status: Postponed
[field #14]        Component Version: None
[field #15]         Platform Version: None
[field #16]          Reproducibility: None
[field #17]               Size (loc): None
[field #18]            Fixed Release: None
[field #19]          Planned Release: None
[field #20]                   Effort: 0.00
[field #24]                 Priority: 5 - Normal
[field #27]         Percent Complete: 0%
[field #29]                  Release: None
[field #54]          Binaries Origin: None
[field #55]                 CPU type: None
[field #56]                      CPU: None
[field #57]     Custom Select Box #4: None
[field #58]     Custom Select Box #5: None
[field #59]     Custom Select Box #6: None
[field #60]     Custom Select Box #7: None
[field #61]     Custom Select Box #8: None
[field #62]     Custom Select Box #9: None
[field #63]    Custom Select Box #10: None

spiralvoice <spiralvoice>
Group administrator
Tue 15 Mar 2005 09:22:03 PM UTC, comment #1: 

ziping it as in pkzip is a bad idea (because it's an archive). compressing it with gzip or bzip2 would be better. supporting gzipped guarding.p2p would be relative easy as mldonkey already supports gzipped content for multiple things. i haven't tested it but doesn't the http-handler already support gzipped content, so it may already work with the appropriate http headers?

Amorphous <amorphous>
Mon 18 Jul 2005 10:24:37 PM UTC, original submission:  

support for guarding.p2p.zip files will help both the supplies for guarding.p2p lists and the user that has to use external scripts to work with them

Anonymous

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attached Files
file #9095:  4184.patch added by spiralvoice (97KiB - application/octet-stream)

 

Depends on the following items: None found

Items that depend on this one: None found

 

CC list is empty

 

There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

 

Follow 10 latest changes.

Date Changed by Updated Field Previous Value => Replaced by
2005-07-23 spiralvoice StatusReady For Test Done
    Open/ClosedOpen Closed
2005-07-22 spiralvoice Attached File- Added 4184.patch, #4881
2005-07-22 spiralvoice Attached File#4853 Removed
2005-07-22 spiralvoice Attached File#4855 Removed
2005-07-18 spiralvoice Attached File- Added guarding_zip2.patch, #4855
2005-07-18 spiralvoice CategoryNone Improved interfaces
    StatusNone Ready For Test
    SummaryReassigned item: support zipped guarding.p2p support guarding.p2p in zip/gz/bz2 format
2005-07-18 spiralvoice Reassign itemFrom group mldonkey, a multi-networks file-sharing client, task tracker To group mldonkey, a multi-networks file-sharing client, patch tracker

Back to the top

Powered by Savane 3.13-02a9.
Corresponding source code