patchmldonkey, a multi-networks file-sharing client - Patches: patch #4433, allow download of .torrent file...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

patch #4433: allow download of .torrent file from broken tracker

Submitted by:  Joakim Verona <jave>
Submitted on:  Mon 19 Sep 2005 08:38:22 AM UTC  
 
Category:  Bug fixes Priority:  5 - Normal
Status:  Wont Do Assigned to:  None
Open/Closed:  Closed

( Jump to the original submission)

Thu 09 Mar 2006 08:36:13 AM UTC, comment #7: 

Replaced by patch #4962 + patch #4946

spiralvoice <spiralvoice>
Project Administrator
Sun 05 Mar 2006 10:44:28 AM UTC, comment #6: 

System-wide cookies patch #4946 was applied to CVS

spiralvoice <spiralvoice>
Project Administrator
Wed 01 Mar 2006 08:22:44 PM UTC, comment #5: 

[21:15:37] <spiralvoice> jave, currently working on your BT cookies patch, in the current it can not be applied:
[21:15:42] <spiralvoice> ./configure --disable-multinet
[21:15:45] <spiralvoice> make
[21:15:46] <spiralvoice> ...
[21:15:49] <spiralvoice> File "src/daemon/driver/driverCommands.ml", line 2772, characters 54-71:
[21:15:49] <spiralvoice> Unbound value BTOptions.cookies
[21:16:15] <spiralvoice> you can never use network specific options in common or driver module, only in the network module itself
[21:17:48] <spiralvoice> did not test the H.GET -> H.HEAD patch yet but I suspect it will download the complete file, even for non-torrent files -> download a 700MB iso image with FileTP -> dllink with your patch will load the complete file in advance to parse its headers :-(

spiralvoice <spiralvoice>
Project Administrator
Tue 28 Feb 2006 07:04:24 PM UTC, comment #4: 

I'd like the functionality of this patch in CVS, so what can be done
to improve it enough to be accepted?

Joakim Verona <jave>
Project Member
Mon 06 Feb 2006 10:02:35 PM UTC, comment #3: 

Attached patch for current CVS of posted code.
Comment #1 has yet to be coded...

spiralvoice <spiralvoice>
Project Administrator
Tue 20 Sep 2005 09:02:32 AM UTC, comment #2: 

here is a small improvement, so that the initial header request will send cookies. this is ugly but works for bnbt trackers which require logon:

                H.req_request = H.GET; (* JAVE Hack H.HEAD *)
(*begin from btInteractive.ml JAVE Hack*)
            H.req_headers = (try
              let cookies = List.assoc u.Url.server !!BTOptions.cookies in
              [ ( "Cookie", List.fold_left (λ res (key, value) →
                      if res = "" then
                        key ^ "=" ^ value
                      else
                        res ^ "; " ^ key ^ "=" ^ value
                  ) "" cookies
                ) ]
            with Not_found → []);
(*end from btInteractive.ml*)

Joakim Verona <jave>
Project Member
Mon 19 Sep 2005 11:48:23 AM UTC, comment #1: 

The patch isnt entirely good.

It should first try HEAD. If that fails, it could do a special request with GET that ignores the message body.

Joakim Verona <jave>
Project Member
Mon 19 Sep 2005 08:38:22 AM UTC, original submission:  

Aparently some trackers doesnt like a HEAD request.

This tiny change makes mldonkey use GET instead:

change line 2666 in driverCommands.ml to:

       H.req_request = H.GET;

instead of                

H.req_request =  H.HEAD;

The problem was observed with a BNBT derived tracker.

Joakim Verona <jave>
Project Member

 

Attached Files
file #9546:  bt_tracker.patch added by spiralvoice (1KiB - application/octet-stream)

 

Depends on the following items: None found

Items that depend on this one: None found

 

CC list is empty

 

Do you think this task is very important?
If so, you can add your encouragement to it.
This task has 0 encouragements so far.

Only logged-in users can vote.

 

 

 

Follow 4 latest changes.

Date Changed by Updated Field Previous Value => Replaced by
2006-03-09 spiralvoice StatusPostponed => Wont Do
    Open/ClosedOpen => Closed
2006-02-06 spiralvoice Attached File- => Added bt_tracker.patch, #5900
2005-09-19 amorphous StatusNone => Postponed

Back to the top


Powered by Savane 3.5