patchmldonkey, a multi-networks file-sharing client - Patches: patch #4536, better mldonkey_submit

 
 

You are not allowed to post comments on this tracker with your current authentication level.

patch #4536: better mldonkey_submit

Submitter:  Dennis Nezic <dennisne>
Submitted:  Wed 19 Oct 2005 05:12:25 PM UTC
   
 
Category:  Improved interfaces Priority:  5 - Normal
Status:  None Assigned to:  None
Open/Closed:  Closed

Mon 12 Jun 2006 08:20:10 PM UTC, comment #5: 

moved to task tracker for later discussion

spiralvoice <spiralvoice>
Group administrator
Tue 09 May 2006 05:38:02 PM UTC, comment #4: 

test

spiralvoice <spiralvoice>
Group administrator
Thu 09 Mar 2006 11:33:07 PM UTC, comment #3: 

upon further consideration, i think the script that mldonkey outputs should only serve as a template, and each user should be expected to manually copy it to wherever he chooses, and edit it appropriately. gentoo's /etc/conf.d/mldonkey only specifies admin login info, and this may not always be what we want -- for example, in a multi-user environment, we probably don't want to give every user admin rights to mldonkey.

this is also a good idea, because (at least in my case), mldonkey runs on a separate server computer .. and i don't have it installed on my personal one (i use the web interface to control it) .. so, i would have to copy/edit my own submission script anyways.

the main point of this patch was to make other users' experiences easier (by having a pre-made script), so they don't have to waste time writing their own link submission scripts. to this day i'm not sure what the preferred method of doing this is -- i'm inclined to think that the majority of users have to jump through hoops to submit links to mldonkey. my guess is they have to manually open mldonkey's http or gui, and manually enter the links that way. i remember trying a firefox extension, but it only worked with ed2k:// files -- not with others such as regular torrent files. this script is a lot more flexible. users can use it in their own scripts to submit links, or via firefox with the downloadwith extension, etc.

so, i would suggest we make a template script for each supported platform. the attached one should work in most of the ones you listed, no? perhaps users of those other platforms could post a revised script for their own systems?..

Dennis Nezic <dennisne>
Mon 06 Feb 2006 09:52:20 PM UTC, comment #2: 

Your patch is a good idea, but

"i'm not sure how cross-platform this is =)"

thats a big problem as MLDonkey supports a big variety of platforms, like
- Windows (Cygwin, MinGW)
- Linux
- Free-/Net-/Open-BSD
- Solaris
- Mac OS X
- HP-UX
- MorphOS
- BeOS

and maybe more.

spiralvoice <spiralvoice>
Group administrator
Fri 28 Oct 2005 03:37:32 PM UTC, comment #1: 

this update makes the graphical prompt appear whenever $DISPLAY is defined. before, $TERM was checked, but i don't think there is any standard way of checking for "non-terminals" (like when the script is called via firefox). For example, when I first wrote the script, TERM was "dumb". Now it is "linux".

Dennis Nezic <dennisne>
Wed 19 Oct 2005 05:12:25 PM UTC, original submission:  

it is a shell script (instead of the previous perl script), that accepts any link (torrent, http, ftp, ed2k, etc. -- assuming the network is enabled), and sends it to a running mldonkey via the http interface.

a big advantage to it, besides accepting any link, is it can prompt the user visually of mldonkey's response, and thus can integrate well with web browsers. (btw, if using firefox, i highly recommend using the download-with extension, http://downloadwith.mozdev.org, to send links to this script).

it uses xmessage for visual prompting (if no console exists), perl to uri_escape the url, and wget to perform the http interaction.

i'm not sure how cross-platform this is =)

the main potential problem with it, is how to pass login information. the previous script simply did not allow this! it hard-coded the "admin" user, but left the password blank. this script uses gentoo's /etc/conf.d/mldonkey, which contains all the necessary login info (USERNAME, PASSWORD, SERVER, PORT). i like this option, as it provides a central location for such preferences, and makes security easier to manage. this way, anybody can execute the script, but only those with read permission to the config file can use it.

for other distributions, we can probably add an extra preference to specify which config file to use.

Dennis Nezic <dennisne>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

CC list is empty

 

There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

 

Follow 4 latest changes.

Date Changed by Updated Field Previous Value => Replaced by
2006-06-12 spiralvoice Reassign ItemFrom group mldonkey, a multi-networks file-sharing client, patch tracker To group mldonkey, a multi-networks file-sharing client, task tracker
2006-03-09 dennisne Attached File- Added my_mldonkey_submit, #6034
2005-10-28 dennisne Attached File- Added mldonkey-2.6.5.better_mldonkey_submit.patch, #5384
2005-10-19 dennisne Attached File- Added mldonkey-2.6.5.better_mldonkey_submit.patch, #5346

Back to the top

Powered by Savane 3.13-cf05.
Corresponding source code