patchmldonkey, a multi-networks file-sharing client - Patches: patch #5065, Improved CommonBlocking


You are not allowed to post comments on this tracker with your current authentification level.

patch #5065: Improved CommonBlocking

Submitted by:  pango <mlpango>
Submitted on:  Mon May 1 12:10:22 2006  
Category: NonePriority: 5 - Normal
Status: PostponedAssigned to: None
Open/Closed: Open

Tue May 23 20:35:53 2006, comment #1:

Attached an updated version of the patch for current CVS

CommonWeb.add_web_after_hook (fun _ ->
if !need_updating then update_bans ()

This code leads to the fact that !!ip_blocking file is loaded
as many times as web_infos-records are present on startup.

2006/05/23 22:27:29 Starting MLDonkey 2.7.6.CVS ...
2006/05/23 22:27:29 Language DE, locale UTF-8, ulimit for open files 1024
2006/05/23 22:27:29 MLDonkey is working in /root/.mldonkey
2006/05/23 22:27:29 [DNS] Resolving [gentoo] ...
2006/05/23 22:27:29 [DNS] Resolving ...
2006/05/23 22:27:30 [dMain] Libmagic file-type recognition database present
2006/05/23 22:27:30 [IPblock] loading ./
2006/05/23 22:27:30 [IPblock] guarding.p2p found in zip file
2006/05/23 22:27:31 [IPblock] 127405 ranges loaded - optimized to 111414
2006/05/23 22:27:32 [IPblock] loading ./
2006/05/23 22:27:32 [IPblock] guarding.p2p found in zip file
2006/05/23 22:27:34 [IPblock] 127405 ranges loaded - optimized to 111414
2006/05/23 22:27:35 [IPblock] loading ./
2006/05/23 22:27:35 [IPblock] guarding.p2p found in zip file
2006/05/23 22:27:37 [IPblock] 127405 ranges loaded - optimized to 111414
2006/05/23 22:27:38 [IPblock] loading ./
2006/05/23 22:27:38 [IPblock] guarding.p2p found in zip file
2006/05/23 22:27:40 [IPblock] 127405 ranges loaded - optimized to 111414
2006/05/23 22:27:40 [IPblock] loading ./
2006/05/23 22:27:40 [IPblock] guarding.p2p found in zip file
2006/05/23 22:27:43 [IPblock] 127405 ranges loaded - optimized to 111414
2006/05/23 22:27:43 Logging in /root/.mldonkey/mlnet.log

spiralvoice <spiralvoice>
Project Administrator
Mon May 1 12:10:22 2006, original submission:

That's a large and untested patch. Caution advised...
Merges blocking lists in memory; When one changes, others are reread from files to rebuild merged list, so it can have a performance impact if one is using lots of lists at once.
Hits are saved separately from lists, so they're not lost across lists updates.

CommonWeb: add support for several web ip blocking lists. Specifically, added support for hooks before and after web info resources fetching.

In CommonBlocking: creates a merged list of all blocked ranges, for improved efficiency, and for block_list output. Ready for several local lists, too. Keep hits separate from ranges, so they're not lost during changes.

ip_set: added a function to merge two blocking lists, with optimization.
removed merging feature from file loading

DriverCommands: "block_list": Display IP of hits instead of ranges. Replaced hackish html output with correct html_mods code. added "block_reset" to reset hits statistics.

TODO: Whitelists! Doable, but I think there's enough code to
test/debug for now ;)

pango <mlpango>
Project Member


Attached Files
file #10037:  5065_2.patch added by spiralvoice (20kB - application/octet-stream)


Depends on the following items: None found

Items that depend on this one: None found


CC list is empty


Do you think this task is very important?
If so, you can click here to add your encouragement to it.
This task has 0 encouragements so far.

Only logged-in users can vote.


Please enter the title of George Orwell's famous dystopian book (it's a date):



Follow 3 latest changes.

Date Changed By Updated Field Previous Value => Replaced By
Tue Jun 6 22:16:12 2006spiralvoiceStatusReady For Test=>Postponed
Tue May 23 20:35:53 2006spiralvoiceAttached File-=>Added 5065_2.patch, #10037
Mon May 1 12:10:22 2006mlpangoAttached File-=>Added commonBlocking_merge_fixes3.patch, #9865

Back to the top

Powered by Savane 3.1-cleanup1