patchSimulavr: an AVR simulator - Patches: patch #5182, Fix detection of edge triggered...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

patch #5182: Fix detection of edge triggered external IRQs

Submitter:  Meik Felser <mkfelser>
Submitted:  Tue 13 Jun 2006 12:55:13 PM UTC
   
 
Category:  bug fix Priority:  5 - Normal
Status:  Done Privacy:  Public
Assigned to:  zfrdh Open/Closed:  Closed
Component Version:  None

Tue 24 Feb 2009 02:26:44 PM UTC, comment #1: 

fix applied (years ago :-) Thanks! Only comment it while closing the entry now

Klaus Rudolph <zfrdh>
Group administrator
Tue 13 Jun 2006 12:55:13 PM UTC, original submission:  

Fixes the detection of edge triggered external interrupts.

Background: ATmega128: If the ISCn[0|1] bits in EICRx are set to either 1,0 or 1,1  the interrupt should be detected at a falling or rising edge.

Problem: HWMegaExtIrq::PinStateHasChanged (in hwmegaextirq.cpp) compares the old state of the pin with the current state to detect an edge. The bug is: the old state is just updated if an edge is detected. Thus just the first edge after a reset is detected.

Solution (=patch): the old state should be updated whenever the pin state changes (or always).

Meik Felser <mkfelser>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attached Files
file #10185:  ext_irq_ctrl_fix.diff added by mkfelser (1KiB - application/octet-stream - patch against simulavrxx-0.8.006 fixes detection of edge triggered external IRQs)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by zfrdh (Posted a comment)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

     

    Follow 5 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2009-02-24 zfrdh StatusIn Progress Done
        Open/ClosedOpen Closed
    2006-06-19 zfrdh StatusNone In Progress
        Assigned toNone zfrdh
    2006-06-13 mkfelser Attached File- Added ext_irq_ctrl_fix.diff, #10185

    Back to the top

    Powered by Savane 3.13-4b48.
    Corresponding source code