patchmldonkey, a multi-networks file-sharing client - Patches: patch #5421, Just adds "Users" to...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

patch #5421: Just adds "Users" to options frame...

Submitter:  unease <unease>
Submitted:  Mon 25 Sep 2006 07:41:38 AM UTC
   
 
Category:  Improved interfaces Priority:  5 - Normal
Status:  Done Assigned to:  None
Open/Closed:  Closed

Jump to the original submission

Sun 01 Oct 2006 05:50:57 PM UTC, comment #6: 

The webinterface code needs serious updating to make conditional stuff possible, until then I am applying this patch.

Applied 2006/10/01

spiralvoice <spiralvoice>
Group administrator
Sun 01 Oct 2006 12:08:47 AM UTC, comment #5: 

forget my post, after writing this i had looked at the source and find this

if user2_is_admin o.conn_user.ui_user_name then begin
.......

Schlumpf <schlumpf_>
Group Member
Sat 30 Sep 2006 11:54:39 PM UTC, comment #4: 


>>

only admin users should see the button
<<

imho is it not better to block this at command level for non_admin's in DriverCommands.ml ? if you only let the user not see the button they can nonetheless call it direct with the url like ...:4080/submit?q=users

Schlumpf <schlumpf_>
Group Member
Mon 25 Sep 2006 08:15:55 AM UTC, comment #3: 

sure... you are better on ocaml I don't know how to get active user so I will learn too...

unease <unease>
Mon 25 Sep 2006 08:06:15 AM UTC, comment #2: 

If you like, I can do that update

spiralvoice <spiralvoice>
Group administrator
Mon 25 Sep 2006 08:05:47 AM UTC, comment #1: 

This patch needs updating, only admin users should see the button.

spiralvoice <spiralvoice>
Group administrator
Mon 25 Sep 2006 07:41:38 AM UTC, original submission:  

This little patch just adds "Users" button to "Options" frame... After multiuser features it should be accesed easyly I think...

unease <unease>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attached Files
file #10840:  patch.txt added by unease (709B - text/plain - Users Patch)

 

Depends on the following items: None found

Items that depend on this one: None found

 

CC list is empty

 

There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

 

Follow 4 latest changes.

Date Changed by Updated Field Previous Value => Replaced by
2006-10-01 spiralvoice StatusPostponed Done
    Open/ClosedOpen Closed
2006-09-25 spiralvoice StatusNone Postponed
2006-09-25 unease Attached File- Added patch.txt, #10840

Back to the top

Powered by Savane 3.13-4b48.
Corresponding source code