patchmldonkey, a multi-networks file-sharing client - Patches: patch #5444, BT: Correctly display client...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

patch #5444: BT: Correctly display client connected time, also allow correct upload speed calculation

Submitter:  SchAmane <schamane>
Submitted:  Sat 07 Oct 2006 04:05:34 PM UTC
   
 
Category:  None Priority:  5 - Normal
Status:  Done Assigned to:  None
Open/Closed:  Closed

Sun 08 Oct 2006 02:02:19 PM UTC, comment #4: 

Applied 2006/10/08

spiralvoice <spiralvoice>
Group administrator
Sat 07 Oct 2006 04:08:46 PM UTC, comment #3: 
spiralvoice <spiralvoice>
Group administrator
Sat 07 Oct 2006 04:05:34 PM UTC, comment #2: 

This item has been reassigned from the project mldonkey, a multi-networks file-sharing client bugs tracker to your tracker.

The original report is still available at bugs #16692

Following are the information included in the original report:

[field #0]                  Item ID: 16692
[field #1]                 Group ID: 1409
[field #2]              Open/Closed: Open
[field #3]                 Severity: 3 - Normal
[field #4]                  Privacy: Public
[field #6]                 Category: Bittorrent-Plugin
[field #7]             Submitted by: schamane
[field #8]              Assigned to: None
[field #9]             Submitted on: Montag 29.05.2006 um 15:31
[field #10]                  Summary: BT: Upload Slots shows wrong slot upload speed in tooltip
[field #11]      Original Submission: if you go in webgui to Transfers -> Uploaders and hold mouse on top of some upload slots it shows actual slot upload rate.
It seems to show wrong numbers. Actually it shows count of bytes in Kbyte uploaded to this client with Kb/s extension.
It should show speed, and not a count.

It happends with BT upload, no idea if other networks are affected.
[field #13]               Item Group: Program malfunction
[field #14]                   Status: In Progress
[field #15]        Component Version: None
[field #16]         Operating System: Linux
[field #17]          Reproducibility: None
[field #18]               Size (loc): None
[field #19]            Fixed Release: None
[field #20]          Planned Release: None
[field #21]                   Effort: 0.00
[field #25]                 Priority: 5 - Normal
[field #28]         Percent Complete: 0%
[field #30]                  Release: 2.8.1
[field #55]          Binaries Origin: CVS / Self compiled
[field #56]                 CPU type: Intel x86
[field #57]                      CPU: None
[field #58]     Custom Select Box #4: None
[field #59]     Custom Select Box #5: None
[field #60]     Custom Select Box #6: None
[field #61]     Custom Select Box #7: None
[field #62]     Custom Select Box #8: None
[field #63]     Custom Select Box #9: None
[field #64]    Custom Select Box #10: None

spiralvoice <spiralvoice>
Group administrator
Tue 30 May 2006 06:14:15 PM UTC, comment #1: 

driverCommands.ml:

( float_of_int (Int64.to_int i.client_uploaded / 1024) /.
  float_of_int (max 1 ((last_time ()) - i.client_connect_time)) )

At the moment a client has an upload slot for 21 minutes,
uploaded 32.9MB and an average displayed of 26.4 KB/s which
is not possible because max_hard_upload_rate is set to 11 kB/s.

The reason for this display problem is that those 32.9MB are
total upload, not from the current upload slot. That particular
client must have had an upload slot earlier already, checking
log file confirms this.

MLDonkey data structures do not have distinguished values for
total upload or total session upload so I would propose to
remove the average upload slot speed display.

spiralvoice <spiralvoice>
Group administrator
Sat 07 Oct 2006 04:05:34 PM UTC, original submission:  

if you go in webgui to Transfers -> Uploaders and hold mouse on top of some upload slots it shows actual slot upload rate.
It seems to show wrong numbers. Actually it shows count of bytes in Kbyte uploaded to this client with Kb/s extension.
It should show speed, and not a count.

It happends with BT upload, no idea if other networks are affected.

SchAmane <schamane>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attached Files
file #10914:  bt_speed.patch added by spiralvoice (3KiB - application/octet-stream)

 

Depends on the following items: None found

Items that depend on this one: None found

 

CC list is empty

 

There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

 

Follow 4 latest changes.

Date Changed by Updated Field Previous Value => Replaced by
2006-10-08 spiralvoice StatusNone Done
    Open/ClosedOpen Closed
2006-10-07 spiralvoice SummaryBT: Upload Slots shows wrong slot upload speed in tooltip BT: Correctly display client connected time, also allow correct upload speed calculation
2006-10-07 spiralvoice Reassign itemmldonkey, a multi-networks file-sharing client, bug #16692 mldonkey, a multi-networks file-sharing client, patch #5444

Back to the top

Powered by Savane 3.13-4b48.
Corresponding source code