patchmldonkey, a multi-networks file-sharing client - Patches: patch #5496, BT: Do not remove good clients...


You are not allowed to post comments on this tracker with your current authentication level.

patch #5496: BT: Do not remove good clients (experimental)

Submitted by:  spiralvoice <spiralvoice>
Submitted on:  Thu Oct 26 23:02:09 2006  
Category: Bug fixesPriority: 7 - High
Status: Ready For TestAssigned to: None
Open/Closed: Open

(Jump to the original submission Jump to the original submission)

Sat Apr 10 21:39:47 2010, comment #6:

Problem with memory usage - 4 days of uptime and RSS steadily grows, from 40M to 200M now.

ygrek <ygrek>
Project Member
Fri Apr 9 20:23:14 2010, comment #5:

With this patch it becomes pretty obvious that some pagination is needed when listing clients in html ui (and probably some way to limit the output in telnet interface?). This is also an easy way to resolve bug #17712

ygrek <ygrek>
Project Member
Mon Apr 5 20:37:30 2010, comment #4:

I didn't observe the error messages reported by bogeyman with this patch.
But got another message - exn Out_of_memory in disconnect_client. Solution - use List2.removeq instead of List2.remove, and probably List.remove should use compare instead of (=) ...

(file #20122)

ygrek <ygrek>
Project Member
Sun Apr 4 22:24:47 2010, comment #3:

Refreshed for current CVS.

(file #20117)

ygrek <ygrek>
Project Member
Fri Nov 17 15:42:10 2006, comment #2:

will try this:
- remove_client c;
+ current_uploaders := List2.remove c !current_uploaders;
+ c.client_received_peer_id <- false;

Another issue: I got ~25000 CommonClients but only 100 DonkeyClients, long after my bt download finished and i dont upload anymore to bt clients.

bogeyman <bogeyman>
Project Member
Fri Nov 17 15:29:24 2006, comment #1:

I got a lot of "BT: Unknown message" & "btprotocol.bt_handler: closed connection" and the dumps indicate that they send their ID but c.client_received_peer_id is set. have it to be set to false at some point, where we dont remove the peer?!

Cannot test it and hope this helps

bogeyman <bogeyman>
Project Member
Thu Oct 26 23:02:09 2006, original submission:

Please test this experimental patch.
Its aim is to solve the problem that BT clients disappear too quickly.
Some debug code is still present, please ignore its output in logfile.

spiralvoice <spiralvoice>
Project Administrator


Attached Files
file #20122:  good_clients2.diff added by ygrek (12kB - text/x-diff)
file #20117:  good_clients.diff added by ygrek (12kB - text/x-diff)
file #12227:  5496.patch added by spiralvoice (13kB - text/x-diff)


Depends on the following items: None found

Items that depend on this one: None found


Carbon-Copy List
  • -unavailable- added by ygrek (Updated the item)
  • -unavailable- added by spiralvoice (Updated the item)

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.


    Please enter the title of George Orwell's famous dystopian book (it's a date):



    Follow 10 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Thu Apr 8 19:13:43 2010spiralvoicePriority5 - Normal=>7 - High
      StatusPostponed=>Ready For Test
    Mon Apr 5 20:37:30 2010ygrekAttached File-=>Added good_clients2.diff, #20122
    Sun Apr 4 22:24:47 2010ygrekAttached File-=>Added good_clients.diff, #20117
    Wed Mar 21 19:56:41 2007spiralvoiceAttached File-=>Added 5496.patch, #12227
    Wed Mar 21 19:52:20 2007spiralvoiceAttached File#11094=>Removed
    Wed Nov 29 00:11:01 2006spiralvoiceStatusIn Progress=>Postponed
    Fri Oct 27 23:16:59 2006spiralvoiceAttached File-=>Added bt.patch, #11094
    Fri Oct 27 23:16:52 2006spiralvoiceAttached File#11084=>Removed
    Thu Oct 26 23:02:09 2006spiralvoiceAttached File-=>Added bt.patch, #11084

    Back to the top

    Powered by Savane 3.1-cleanup1