patchmldonkey, a multi-networks file-sharing client - Patches: patch #5699, Wrong file path in notification...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

patch #5699: Wrong file path in notification mail

Submitter:  btest <btest>
Submitted:  Sat 20 Jan 2007 01:05:01 PM UTC
   
 
Category:  None Priority:  5 - Normal
Status:  Done Assigned to:  None
Open/Closed:  Closed

Sun 21 Jan 2007 03:19:45 PM UTC, comment #5: 

Committed 2007/01/21

spiralvoice <spiralvoice>
Group administrator
Sat 20 Jan 2007 01:05:01 PM UTC, comment #4: 

This item has been reassigned from the project mldonkey, a multi-networks file-sharing client bugs tracker to your tracker.

The original report is still available at bugs #18584

Following are the information included in the original report:

[field #0]                  Item ID: 18584
[field #1]                 Group ID: 1409
[field #2]              Open/Closed: Open
[field #3]                 Severity: 3 - Normal
[field #4]                  Privacy: Public
[field #8]                         : Unknown bugs Field Display Type
[field #9]                 Category: Core
[field #10]             Submitted by: btest
[field #11]              Assigned to: None
[field #12]             Submitted on: Montag 25.12.2006 um 10:15
[field #13]                  Summary: Wrong file path in notification mail
[field #14]      Original Submission: Hi there,

I am using multi-user functionality to provide access for some users to mldonkey. "incoming_files" strategy is "incoming/files". Each user has its own commit directory inside that ("someuser" has "userdir" commit directory). Resulted path is "incoming/files/userdir". Downloaded files are committed correctly. I am using notification mails to notify my users. We have a wrong file path in that emails. The path is "incoming/files/somefile.ext" instead of "incoming/files/userdir/somefile.ext". Can this be fixed please?

Thanks.


[field #16]               Item Group: Feature request
[field #17]                   Status: Ready For Test
[field #18]        Component Version: None
[field #19]         Operating System: Linux
[field #20]          Reproducibility: None
[field #21]               Size (loc): None
[field #22]            Fixed Release: None
[field #23]          Planned Release: None
[field #24]                   Effort: 0.00
[field #28]                 Priority: 5 - Normal
[field #31]         Percent Complete: 0%
[field #33]                  Release: 2.8.2
[field #34]                  Release: 2.8.2
[field #58]          Binaries Origin: None
[field #59]                 CPU type: Intel x86
[field #60]                      CPU: None
[field #61]     Custom Select Box #4: None
[field #62]     Custom Select Box #5: None
[field #63]     Custom Select Box #6: None
[field #64]     Custom Select Box #7: None
[field #65]     Custom Select Box #8: None
[field #66]     Custom Select Box #9: None
[field #67]    Custom Select Box #10: None

spiralvoice <spiralvoice>
Group administrator
Sat 20 Jan 2007 12:23:45 PM UTC, comment #3: 

I had no time to test this before.

It works like a charm. Thanks.


btest <btest>
Fri 19 Jan 2007 07:08:46 PM UTC, comment #2: 

ping

Did you test the patch already?

spiralvoice <spiralvoice>
Group administrator
Tue 09 Jan 2007 10:42:13 PM UTC, comment #1: 

Current code does this:
- a file is finished 100%
- its moved from the download list to done_files (the list of files to be committed) and the notification mail is sent. This takes place without considering user_commit_dir, your observation is correct. Attached patch changes this, please test.
- at a later time file commit is initiated, manually or automatically does not matter
- the directory where the file should be moved to is computed now, here user_commit_dir is taken in account. This setting can be changed between the time the mail is sent and the commit is initiated, so even if sending the mail with user_commit_dir it can provide wrong information...

Solving this would require to change the time the mail is sent, this would lead to the fact that users do not get notified of finished downloads when auto_commit is false, not a good idea IMHO.

Any suggestions? IMHO the above case that user_commit_dir is changed between sending mail and commit is most unlikely, considering this case is not important.

(file #11718)

spiralvoice <spiralvoice>
Group administrator
Sat 20 Jan 2007 01:05:01 PM UTC, original submission:  

Hi there,

I am using multi-user functionality to provide access for some users to mldonkey. "incoming_files" strategy is "incoming/files". Each user has its own commit directory inside that ("someuser" has "userdir" commit directory). Resulted path is "incoming/files/userdir". Downloaded files are committed correctly. I am using notification mails to notify my users. We have a wrong file path in that emails. The path is "incoming/files/somefile.ext" instead of "incoming/files/userdir/somefile.ext". Can this be fixed please?

Thanks.


btest <btest>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attached Files

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by spiralvoice (Updated the item)
  • -email is unavailable- added by btest (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

     

    Follow 3 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2007-01-21 spiralvoice StatusNone Done
        Open/ClosedOpen Closed
    2007-01-20 spiralvoice Reassign itemmldonkey, a multi-networks file-sharing client, bug #18584 mldonkey, a multi-networks file-sharing client, patch #5699

    Back to the top

    Powered by Savane 3.13-4b48.
    Corresponding source code