patchmldonkey, a multi-networks file-sharing client - Patches: patch #5724, http_client: Retry GET request if...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

patch #5724: http_client: Retry GET request if HEAD request returns http error 400

Submitter:  Markus Tacker <tacker>
Submitted:  Sun 04 Feb 2007 05:26:35 PM UTC
   
 
Category:  None Priority:  5 - Normal
Status:  Done Assigned to:  None
Open/Closed:  Closed

Jump to the original submission

Sun 04 Feb 2007 05:27:58 PM UTC, comment #6: 

Committed 2007/02/04

spiralvoice <spiralvoice>
Group administrator
Sun 04 Feb 2007 05:26:35 PM UTC, comment #5: 

This item has been reassigned from the project mldonkey, a multi-networks file-sharing client bugs tracker to your tracker.

The original report is still available at bugs #18833

Following are the information included in the original report:

[field #0]                  Item ID: 18833
[field #1]                 Group ID: 1409
[field #2]              Open/Closed: Open
[field #3]                 Severity: 3 - Normal
[field #4]                  Privacy: Public
[field #8]                         : Unknown bugs Field Display Type
[field #9]                 Category: HTTP interface
[field #10]             Submitted by: tacker
[field #11]              Assigned to: None
[field #12]             Submitted on: Freitag 19.01.2007 um 14:37
[field #13]                  Summary: http_client: Retry GET request if HEAD request returns http error 400
[field #14]      Original Submission: Adding this URL als dllink does not work:
http://tracker.etn.fm:7979/torrent.html?info_hash=85d12bcc4839d1a1bcfc526dffce16f76c27efe5 />[field #15]                Closed on: Freitag 19.01.2007 um 20:08
[field #16]               Item Group: Program malfunction
[field #17]                   Status: Ready For Test
[field #18]        Component Version: None
[field #19]         Operating System: Linux
[field #20]          Reproducibility: None
[field #21]               Size (loc): None
[field #22]            Fixed Release: None
[field #23]          Planned Release: None
[field #24]                   Effort: 0.00
[field #28]                 Priority: 5 - Normal
[field #31]         Percent Complete: 0%
[field #33]                  Release: 2.8.2
[field #34]                  Release: 2.8.2
[field #58]          Binaries Origin: Gentoo ebuild
[field #59]                 CPU type: None
[field #60]                      CPU: None
[field #61]     Custom Select Box #4: None
[field #62]     Custom Select Box #5: None
[field #63]     Custom Select Box #6: None
[field #64]     Custom Select Box #7: None
[field #65]     Custom Select Box #8: None
[field #66]     Custom Select Box #9: None
[field #67]    Custom Select Box #10: None

spiralvoice <spiralvoice>
Group administrator
Fri 26 Jan 2007 02:18:56 PM UTC, comment #4: 

dllink http://....

loads HTTP headers with a HEAD request for further inspection.
The tracker mentioned here answers all HEAD requests with error
400 which stops the download process of the torrent file.
I tested this by sending the a GET and a HEAD request with Telnet.

Without a correct header answer MLDonkey does not know what
to do with the URL because dllink is a generic command for all
network modules. All networks are called with the received headers,
BT module has this code to analyze HTTP headers and find the
ones its responsible for:

    if (valid_torrent_extension real_url)
       || (String2.contains url "Content-Type: application/x-bittorrent")

But the error 400 stops the dllink process because it returns
no data worth analyzing.
I attached a patch which repeats a HEAD request as GET in the
lower network module http_client if a HEAD request returned
error 400, please test.

This will lead to the situation that dllink does a GET request
with this URL, BT module parses the headers, finds out that its
responsible for the URL and does a GET request again to get the
torrent file. Because of the generic structures of the common
and net modules in MLDonkey downloading the .torrent file twice
here can not be avoided. Using command "startbt" avoids
downloading the torrent file twice because its especially made
for BT and does a GET request right at away.

(file #11868)

spiralvoice <spiralvoice>
Group administrator
Fri 26 Jan 2007 01:05:30 PM UTC, comment #3: 


> The URL mentioned in this bug works with the command "startbt" which was created especially for BT downloads.

Confirmed. But it should also work with dllink, should'nt it?

Markus Tacker <tacker>
Fri 26 Jan 2007 12:56:01 PM UTC, comment #2: 

The URL mentioned in this bug works with the command "startbt" which was created especially for BT downloads.

spiralvoice <spiralvoice>
Group administrator
Fri 19 Jan 2007 07:08:08 PM UTC, comment #1: 

Closed, duplicate of bug #18750

spiralvoice <spiralvoice>
Group administrator
Sun 04 Feb 2007 05:26:35 PM UTC, original submission:  
Markus Tacker <tacker>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attached Files
file #11868:  http_400head.patch added by spiralvoice (633B - text/x-diff)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by spiralvoice (Posted a comment)
  • -email is unavailable- added by tacker (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

     

    Follow 3 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2007-02-04 spiralvoice StatusNone Done
        Open/ClosedOpen Closed
    2007-02-04 spiralvoice Reassign itemmldonkey, a multi-networks file-sharing client, bug #18833 mldonkey, a multi-networks file-sharing client, patch #5724

    Back to the top

    Powered by Savane 3.13-0329.
    Corresponding source code