patchmldonkey, a multi-networks file-sharing client - Patches: patch #5759, OV/KAD: improved stats command and...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

patch #5759: OV/KAD: improved stats command and misc

Submitter:  bogeyman <bogeyman>
Submitted:  Sat 24 Feb 2007 04:23:05 PM UTC
   
 
Category:  None Priority:  5 - Normal
Status:  Done Assigned to:  None
Open/Closed:  Closed

Thu 01 Mar 2007 12:27:38 AM UTC, comment #5: 

@spiralvoive: ah ok sorry, for some reason I thougt in ocaml functions are first called just when needed.

orbit <orbit>
Wed 28 Feb 2007 10:25:30 PM UTC, comment #4: 

Committed 5759.patch 2007/02/28

spiralvoice <spiralvoice>
Group administrator
Wed 28 Feb 2007 10:23:28 PM UTC, comment #3: 

Several years ago I posted a patch were I mixed code changes
with tab adjustments. Someone then said, the patch is hard to
read and difficult to debug, because code and stylistic changes
are mixed. It ended up with the advice to produce one patch
with code changes and one with tab cleanups.
In docs/Changelog.old you will find lots of "whitespace cleanups" entries.

I updated your patch and removed the tab stuff and
the obsolete options.

Also obsolete options can be removed at any time.
If you find options which can be hard-coded, because changing
them does not drastically influence MLDonkey: remove them.

(file #12071)

spiralvoice <spiralvoice>
Group administrator
Wed 28 Feb 2007 10:08:26 PM UTC, comment #2: 

@orbit: You are wrong;-)

For example:

!n_used_buckets = 10

let b = prebuckets.(!n_used_buckets) in
( stores prebuckets.10 into b )

incr n_used_buckets
( !n_used_buckets is increased by 1 )

if bucket >= !n_used_buckets then
  prebuckets.(!n_used_buckets)
( prebuckets.11 is used here )
else
  b
( b is used here, which still is prebuckets.10 )

This code makes a copy of a bucket to use it later.

spiralvoice <spiralvoice>
Group administrator
Sun 25 Feb 2007 12:55:22 AM UTC, comment #1: 

I'm just learning ocaml but these lines in donkeyOvernet.ml look awkward to me:

@ 855 , 861 @
              let b = prebuckets.(!n_used_buckets) in
              incr n_used_buckets;
              for i = 1 to Fifo.length b do
                let pp = Fifo.take b in
                let bucket = bucket_number p.peer_md4 in
                Fifo.put (if bucket >= !n_used_buckets then
                    prebuckets.(!n_used_buckets) else b) pp

in the if clause the then and else are quite the same or am I wrong?

orbit <orbit>
Sat 24 Feb 2007 04:23:05 PM UTC, original submission:  

o improved stats command:
  o tell weather the network is enabled or not
  o warn if there is a diff of 60 seconds and more between the last upd packet send and received
o mark some options as obsolete (not sure if they should really be removed)
o replaced some tabs by spaces
o save bandwidth: send max 10 peers in search results (overnet peers ask sometimes for 20 and more!)

bogeyman <bogeyman>
Group Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attached Files
file #12071:  5759.patch added by spiralvoice (9KiB - text/x-diff)
file #12033:  ov-misc.patch added by bogeyman (16KiB - text/x-patch)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by spiralvoice (Posted a comment)
  • -email is unavailable- added by orbit (Posted a comment)
  • -email is unavailable- added by bogeyman (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

     

    Follow 5 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2007-02-28 spiralvoice StatusReady For Test Done
        Open/ClosedOpen Closed
    2007-02-28 spiralvoice Attached File- Added 5759.patch, #12071
        StatusNone Ready For Test
    2007-02-24 bogeyman Attached File- Added ov-misc.patch, #12033

    Back to the top

    Powered by Savane 3.13-bb6a.
    Corresponding source code