patchmldonkey, a multi-networks file-sharing client - Patches: patch #5765, Change maximum value for...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

patch #5765: Change maximum value for client_buffer_size

Submitter:  spiralvoice <spiralvoice>
Submitted:  Wed 28 Feb 2007 11:14:08 PM UTC
   
 
Category:  Bug fixes Priority:  5 - Normal
Status:  Done Assigned to:  None
Open/Closed:  Closed

Sun 04 Mar 2007 10:18:25 PM UTC, comment #1: 

Committed 2007/03/04

spiralvoice <spiralvoice>
Group administrator
Wed 28 Feb 2007 11:14:08 PM UTC, original submission:  

http://mldonkey.sourceforge.net/forums/viewtopic.php?p=25414#25414

Initial value was 50000
http://cvs.savannah.nongnu.org/viewcvs/mldonkey/src/daemon/common/commonOptions.ml?annotate=1.15&root=mldonkey

It was updated to 1.000.000 in July 2005, why it was raised?
Maybe during implementation of GD stats? I do not know...
http://savannah.nongnu.org/patch/?4167
http://cvs.savannah.nongnu.org/viewcvs/mldonkey/src/daemon/common/commonOptions.ml?root=mldonkey&r1=1.66&r2=1.67

In December 2005 it was raised again to 10.000.000
http://cvs.savannah.nongnu.org/viewcvs/mldonkey/src/daemon/common/commonOptions.ml?root=mldonkey&r1=1.103&r2=1.104
http://savannah.nongnu.org/patch/?4670
"Increase max_buffer_size limit for high-volume connections"

At least the last update was bad, for high-volume connections
the option client_buffer_size should have been raised, not
the option_hook...

This patch introduces again a normal maximum value of 50000, it
also prints this value in mem_stats and removes an unneeded function.

Users of high-volume connections now must raise the option
client_buffer_size to 1.000.000 or more if they see buffer
overflows in their MLDonkey logs.

spiralvoice <spiralvoice>
Group administrator

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attached Files
file #12110:  5765.patch added by spiralvoice (3KiB - text/x-diff)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by spiralvoice (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

     

    Follow 5 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2007-03-04 spiralvoice StatusWorks For Me Done
        Open/ClosedOpen Closed
    2007-03-04 spiralvoice Attached File- Added 5765.patch, #12110
    2007-03-04 spiralvoice Attached File#12073 Removed
    2007-02-28 spiralvoice Attached File- Added buffers.patch, #12073

    Back to the top

    Powered by Savane 3.13-0329.
    Corresponding source code