patchmldonkey, a multi-networks file-sharing client - Patches: patch #6337, Fix inequality test for option...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

patch #6337: Fix inequality test for option html_mods_theme

Submitter:  spiralvoice <spiralvoice>
Submitted:  Sun 09 Dec 2007 08:38:44 PM UTC
   
 
Category:  Bug fixes Priority:  5 - Normal
Status:  Done Assigned to:  None
Open/Closed:  Closed

Sun 09 Dec 2007 08:40:22 PM UTC, comment #1: 

Committed 2007/12/09

spiralvoice <spiralvoice>
Group administrator
Sun 09 Dec 2007 08:38:44 PM UTC, original submission:  

thx to pango

[21:31:55] <pango> [18:30:02] btw there's a (small) bug, in several place there's !!html_mods_theme != ""
[21:31:55] <pango> [18:30:22] != is physical equality, so this test is always true
[21:31:55] <pango> [18:30:33] (physical inequality, rather)
[21:31:55] <pango> [18:30:45] # "" != "" ;;
[21:31:55] <pango> [18:30:45] - : bool = true
[21:31:55] <pango> [18:31:01] it should be !!html_mods_theme <> ""
[21:31:55] <pango> [18:31:11] (structural inequality)
[21:31:55] <pango> [18:31:42] consequence is that mlnet looks for overriding pages in the filesystem, even when no theme is set
[21:31:55] <pango> [18:32:26] so there's just a small performance hit

spiralvoice <spiralvoice>
Group administrator

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attached Files

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by spiralvoice (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

     

    Follow 3 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2007-12-09 spiralvoice StatusWorks For Me Done
        Open/ClosedOpen Closed
    2007-12-09 spiralvoice Attached File- Added html_mods_theme_fix_inequality.patch, #14599

    Back to the top

    Powered by Savane 3.13-4b48.
    Corresponding source code