patchmldonkey, a multi-networks file-sharing client - Patches: patch #6364, MinGW: Fix share priorities

 
 

You are not allowed to post comments on this tracker with your current authentication level.

patch #6364: MinGW: Fix share priorities

Submitter:  vbnuy6 <gyhu94t>
Submitted:  Mon 07 Jan 2008 12:08:24 AM UTC
   
 
Category:  Bug fixes Priority:  7 - High
Status:  Done Assigned to:  None
Open/Closed:  Closed

Mon 07 Jan 2008 08:01:45 PM UTC, comment #4: 

Committed 2008/01/07

spiralvoice <spiralvoice>
Group administrator
Mon 07 Jan 2008 12:08:24 AM UTC, comment #3: 

This item has been reassigned from the project mldonkey, a multi-networks file-sharing client bugs tracker to your tracker.

The original report is still available at bugs #19818

Following are the information included in the original report:

[field #0]                  Item ID: 19818
[field #1]                 Group ID: 1409
[field #2]              Open/Closed: Open
[field #3]                 Severity: 3 - Normal
[field #4]                  Privacy: Public
[field #8]                         : Unknown bugs Field Display Type
[field #9]                 Category: Core
[field #10]             Submitted by: gyhu94t
[field #11]              Assigned to: None
[field #12]             Submitted on: Dienstag 08.05.2007 um 04:38
[field #13]                  Summary: Share priorities do not work on MinGW
[field #14]      Original Submission: I was trying to write a patch (at
http://mldonkey.sourceforge.net/phpBB2/viewtopic.php?p=24608#24608
not that it matters).  Is it true that
shared_prio
shared_dir
in src/daemon/common/commonShared.ml never actually work, at least when called from src/daemon/common/commonUploads.ml?
If so does it means share priorities never have any effect?

Experiment:
-Change "with Not_found -> " return values to make it obvious. 
-set verbosity favoured
 (patch attached)
-findstr "favoured" "C:\Program Files\mlnet\mlnet.log"

Result: ("pri" and "cdir" are the relevant ones)
2007/05/08 02:30:06 [cUp] favoured str= fav=0 pri=999 cdir=phytoplankton  (....
2007/05/08 02:30:07 [cUp] favoured str= fav=0 pri=999 cdir=phytoplankton  F....
2007/05/08 02:30:10 [cUp] favoured str= fav=0 pri=999 cdir=phytoplankton  [....
2007/05/08 02:30:22 [cUp] favoured str= fav=0 pri=999 cdir=phytoplankton  H....
2007/05/08 02:30:23 [cUp] favoured str= fav=0 pri=999 cdir=phytoplankton  (....
2007/05/08 02:30:28 [cUp] favoured str= fav=0 pri=999 cdir=phytoplankton  m....
2007/05/08 02:30:30 [cUp] favoured str= fav=0 pri=999 cdir=phytoplankton  [....
2007/05/08 02:30:42 [cUp] favoured str= fav=0 pri=999 cdir=phytoplankton  [....
2007/05/08 02:30:44 [cUp] favoured str= fav=0 pri=999 cdir=phytoplankton  (....
2007/05/08 02:30:48 [cUp] favoured str= fav=0 pri=999 cdir=phytoplankton  [....
2007/05/08 02:30:48 [cUp] favoured str= fav=0 pri=999 cdir=phytoplankton  (....
2007/05/08 02:30:49 [cUp] favoured str= fav=0 pri=999 cdir=phytoplankton  (....
2007/05/08 02:30:50 [cUp] favoured str= fav=0 pri=999 cdir=phytoplankton  [....
2007/05/08 02:30:51 [cUp] favoured str= fav=0 pri=999 cdir=phytoplankton  A....
2007/05/08 02:30:52 [cUp] favoured str= fav=0 pri=999 cdir=phytoplankton  [....
2007/05/08 02:31:03 [cUp] favoured str= fav=0 pri=999 cdir=phytoplankton  綵....
2007/05/08 02:31:17 [cUp] favoured str= fav=0 pri=999 cdir=phytoplankton  b....
2007/05/08 02:31:17 [cUp] favoured str= fav=0 pri=999 cdir=phytoplankton  C....
2007/05/08 02:31:17 [cUp] favoured str= fav=0 pri=999 cdir=phytoplankton  [....
2007/05/08 02:31:18 [cUp] favoured str= fav=0 pri=999 cdir=phytoplankton  [....
2007/05/08 02:31:19 [cUp] favoured str= fav=0 pri=999 cdir=phytoplankton  0....
2007/05/08 02:31:21 [cUp] favoured str= fav=0 pri=999 cdir=phytoplankton  (....
2007/05/08 02:31:24 [cUp] favoured str= fav=0 pri=999 cdir=phytoplankton  [....
2007/05/08 02:31:44 [cUp] favoured str= fav=0 pri=999 cdir=phytoplankton  (....
2007/05/08 02:31:50 [cUp] favoured str= fav=0 pri=999 cdir=phytoplankton  (....
2007/05/08 02:31:50 [cUp] favoured str= fav=0 pri=999 cdir=phytoplankton  (....
2007/05/08 02:31:51 [cUp] favoured str= fav=0 pri=999 cdir=phytoplankton  0....
2007/05/08 02:32:01 [cUp] favoured str= fav=0 pri=999 cdir=phytoplankton  [....
2007/05/08 02:32:06 [cUp] favoured str= fav=0 pri=999 cdir=phytoplankton  [....
2007/05/08 02:32:12 [cUp] favoured str= fav=0 pri=999 cdir=phytoplankton  J....
2007/05/08 02:32:17 [cUp] favoured str= fav=0 pri=999 cdir=phytoplankton  綵....
etc.

Thanks for all your work.


[field #16]               Item Group: Program malfunction
[field #17]                   Status: Ready For Test
[field #18]        Component Version: None
[field #19]         Operating System: MinGW W2K/WinXP
[field #20]          Reproducibility: None
[field #21]               Size (loc): None
[field #22]            Fixed Release: None
[field #23]          Planned Release: None
[field #24]                   Effort: 0.00
[field #28]                 Priority: 5 - Normal
[field #31]         Percent Complete: 0%
[field #33]                  Release: 2.9.2
[field #58]          Binaries Origin: CVS / Self compiled
[field #59]                 CPU type: Intel x86
[field #60]                      CPU: None
[field #61]     Custom Select Box #4: None
[field #62]     Custom Select Box #5: None
[field #63]     Custom Select Box #6: None
[field #64]     Custom Select Box #7: None
[field #65]     Custom Select Box #8: None
[field #66]     Custom Select Box #9: None
[field #67]    Custom Select Box #10: None

spiralvoice <spiralvoice>
Group administrator
Mon 07 Jan 2008 12:08:23 AM UTC, comment #2: 

First of all, this is really a bug, code was introduced to commonShared.ml in September 2002...

Your fix is correct, but it solves only the symptom, not the reason for this bug.

impl.impl_shared_codedname is filled in function commonShared.new_shared

  let codedname = Filename.concat dirname filename in

Example: dirname = "shared2", filename "some_file.txt"
Result: on Unix: "shared2/some_file.txt", on MinGW: "shared2\\some_file.txt"

Its a bad idea to use hard-coded seperators, like

String.index codedname '/'

in commonShared.ml anyway, but as it dates back to a time
where MinGW support was not present (it was started in Dec 2002)
I guess no one thought about it. It assumed "/" as seperator,
but this code fails on MinGW due to usage of "\\" as seperator
in Ocaml´s Filename.concat function.

Ocaml has a special function to seperate Filename.concat strings
using Filename.dirname while taking care of the correct seperator.

Please try the attached patch. It works for me.
In HTML, upstats you can see the patch working when you look
at the slot column.

(file #14758)

spiralvoice <spiralvoice>
Group administrator
Fri 18 May 2007 01:49:04 PM UTC, comment #1: 

Possible fix [2007-05-18-14-47-37-54].

(file #12795)

vbnuy6 <gyhu94t>
Mon 07 Jan 2008 12:08:24 AM UTC, original submission:  

I was trying to write a patch (at
http://mldonkey.sourceforge.net/phpBB2/viewtopic.php?p=24608#24608
not that it matters).  Is it true that
shared_prio
shared_dir
in src/daemon/common/commonShared.ml never actually work, at least when called from src/daemon/common/commonUploads.ml?
If so does it means share priorities never have any effect?

Experiment:
-Change "with Not_found -> " return values to make it obvious. 
-set verbosity favoured
 (patch attached)
-findstr "favoured" "C:\Program Files\mlnet\mlnet.log"

Result: ("pri" and "cdir" are the relevant ones)
2007/05/08 02:30:06 [cUp] favoured str= fav=0 pri=999 cdir=phytoplankton  (....
2007/05/08 02:30:07 [cUp] favoured str= fav=0 pri=999 cdir=phytoplankton  F....
2007/05/08 02:30:10 [cUp] favoured str= fav=0 pri=999 cdir=phytoplankton  [....
2007/05/08 02:30:22 [cUp] favoured str= fav=0 pri=999 cdir=phytoplankton  H....
2007/05/08 02:30:23 [cUp] favoured str= fav=0 pri=999 cdir=phytoplankton  (....
2007/05/08 02:30:28 [cUp] favoured str= fav=0 pri=999 cdir=phytoplankton  m....
2007/05/08 02:30:30 [cUp] favoured str= fav=0 pri=999 cdir=phytoplankton  [....
2007/05/08 02:30:42 [cUp] favoured str= fav=0 pri=999 cdir=phytoplankton  [....
2007/05/08 02:30:44 [cUp] favoured str= fav=0 pri=999 cdir=phytoplankton  (....
2007/05/08 02:30:48 [cUp] favoured str= fav=0 pri=999 cdir=phytoplankton  [....
2007/05/08 02:30:48 [cUp] favoured str= fav=0 pri=999 cdir=phytoplankton  (....
2007/05/08 02:30:49 [cUp] favoured str= fav=0 pri=999 cdir=phytoplankton  (....
2007/05/08 02:30:50 [cUp] favoured str= fav=0 pri=999 cdir=phytoplankton  [....
2007/05/08 02:30:51 [cUp] favoured str= fav=0 pri=999 cdir=phytoplankton  A....
2007/05/08 02:30:52 [cUp] favoured str= fav=0 pri=999 cdir=phytoplankton  [....
2007/05/08 02:31:03 [cUp] favoured str= fav=0 pri=999 cdir=phytoplankton  綵....
2007/05/08 02:31:17 [cUp] favoured str= fav=0 pri=999 cdir=phytoplankton  b....
2007/05/08 02:31:17 [cUp] favoured str= fav=0 pri=999 cdir=phytoplankton  C....
2007/05/08 02:31:17 [cUp] favoured str= fav=0 pri=999 cdir=phytoplankton  [....
2007/05/08 02:31:18 [cUp] favoured str= fav=0 pri=999 cdir=phytoplankton  [....
2007/05/08 02:31:19 [cUp] favoured str= fav=0 pri=999 cdir=phytoplankton  0....
2007/05/08 02:31:21 [cUp] favoured str= fav=0 pri=999 cdir=phytoplankton  (....
2007/05/08 02:31:24 [cUp] favoured str= fav=0 pri=999 cdir=phytoplankton  [....
2007/05/08 02:31:44 [cUp] favoured str= fav=0 pri=999 cdir=phytoplankton  (....
2007/05/08 02:31:50 [cUp] favoured str= fav=0 pri=999 cdir=phytoplankton  (....
2007/05/08 02:31:50 [cUp] favoured str= fav=0 pri=999 cdir=phytoplankton  (....
2007/05/08 02:31:51 [cUp] favoured str= fav=0 pri=999 cdir=phytoplankton  0....
2007/05/08 02:32:01 [cUp] favoured str= fav=0 pri=999 cdir=phytoplankton  [....
2007/05/08 02:32:06 [cUp] favoured str= fav=0 pri=999 cdir=phytoplankton  [....
2007/05/08 02:32:12 [cUp] favoured str= fav=0 pri=999 cdir=phytoplankton  J....
2007/05/08 02:32:17 [cUp] favoured str= fav=0 pri=999 cdir=phytoplankton  綵....
etc.

Thanks for all your work.


vbnuy6 <gyhu94t>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attached Files
file #12795:  share_priorities_mingw.patch added by gyhu94t (785B - application/octet-stream - Possible fix [2007-05-18-14-47-37-54])
file #12715:  bug-commonShared.patch.txt added by gyhu94t (3KiB - text/plain - patch for experiment)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by spiralvoice (Updated the item)
  • -email is unavailable- added by gyhu94t (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

     

    Follow 7 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2008-01-07 spiralvoice StatusReady For Test Done
        Open/ClosedOpen Closed
    2008-01-07 spiralvoice CategoryNone Bug fixes
        Priority5 - Normal 7 - High
        StatusNone Ready For Test
        SummaryShare priorities do not work on MinGW MinGW: Fix share priorities
    2008-01-07 spiralvoice Reassign itemmldonkey, a multi-networks file-sharing client, bug #19818 mldonkey, a multi-networks file-sharing client, patch #6364

    Back to the top

    Powered by Savane 3.13-02a9.
    Corresponding source code