patchAVR C Runtime Library - Patches: patch #6649, sqrt.s in libm changes

 
 

You are not allowed to post comments on this tracker with your current authentication level.

patch #6649: sqrt.s in libm changes

Submitter:  Ruud <ruud62>
Submitted:  Mon 13 Oct 2008 06:42:08 AM UTC
   
 
Category:  None Priority:  5 - Normal
Status:  Done Privacy:  Public
Assigned to:  dmix Open/Closed:  Closed

Jump to the original submission

Tue 25 Nov 2008 04:21:40 PM UTC, comment #6: 

Contributed to HEAD and 1_6 branches.

Dmitry Xmelkov <dmix>
Group administrator
Mon 24 Nov 2008 07:26:56 AM UTC, comment #5: 

Smart MOVE on the short version of sqrt !!! I can't see anything wrong with it..

Ruud <ruud62>
Group Member
Mon 24 Nov 2008 04:57:00 AM UTC, comment #4: 

Thanks, Ruud!
This is fine improvements.

I have make a few changes (sqrt.S is attached):
1. low() is replaced to lo8() (to avoid compile error).
2. Optimize to size variant is slightly modifed to save 4 code words
(look, please).
3. _OptimizeSize_ is replaced to OPTIMIZE_SPEED, as last
is used in Avr-libc a long time.
4. Others are cosmetic: roll lines to 80 symbols, remove assembler
style comments from CPP statements.

In result (avr4, clocks are average for sqrt-500 test suite):
Optimize for size: 234 bytes, 541 clocks.
Optimize for speed: 252 bytes, 474 clocks.

Older versions:
Avr-libc 1.6:  276 bytes, 706 clocks.
Avr-libc 1.4:  606 bytes, 2354 clocks.

Testing in progress...



(file #16910)

Dmitry Xmelkov <dmix>
Group administrator
Fri 21 Nov 2008 04:18:31 AM UTC, comment #3: 

Thanks, Joerg.
Yes, it was a misreading. "In Progress" is the closest match.

Dmitry Xmelkov <dmix>
Group administrator
Sun 19 Oct 2008 01:33:23 PM UTC, comment #2: 

I guess Dmitry simply misread the "Wont do" (which should be
"Won't do" as "Want [to] do". ;-)

I guess "In Progress" is the closest match to indicate that
he intends to do it.

Joerg Wunsch <joerg_wunsch>
Group administrator
Sun 19 Oct 2008 12:35:37 PM UTC, comment #1: 

Thanks, Ruud!
The improvement is very fine. I shall view it in details
and commit at November, when I will return into routine
city life.
Regards, Dmitry.

Dmitry Xmelkov <dmix>
Group administrator
Mon 13 Oct 2008 06:42:08 AM UTC, original submission:  

I have attached a new sqrt.s file which I propose for libm. Tested for all 23 bits mantissa, for both odd and even exponent.

Statistics relative to version 1.8 if _Optimizesize_ defined:
17 code words shorter, 120-244 cycles faster (average 169)

Statistics relative to version 1.8 if _Optimizesize_ not defined:
12 code words shorter, 184-294 cycles faster (average 231)

Regards
Ruud

Ruud <ruud62>
Group Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attached Files
file #16910:  sqrt.S added by dmix (5KiB - text/x-csrc)
file #16664:  sqrt.S added by ruud62 (5KiB - text/plain)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by joerg_wunsch (Posted a comment)
  • -email is unavailable- added by dmix (Posted a comment)
  • -email is unavailable- added by ruud62 (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

     

    Follow 7 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2008-11-25 dmix StatusIn Progress Done
        Open/ClosedOpen Closed
    2008-11-24 dmix Attached File- Added sqrt.S, #16910
    2008-10-19 joerg_wunsch StatusWont Do In Progress
    2008-10-19 dmix StatusNone Wont Do
        Assigned toNone dmix
    2008-10-13 ruud62 Attached File- Added sqrt.S, #16664

    Back to the top

    Powered by Savane 3.13-bb6a.
    Corresponding source code