patchSimulavr: an AVR simulator - Patches: patch #6800, pin state can be signed char and...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

patch #6800: pin state can be signed char and avoid casts

Submitter:  Joel Sherrill <joelsherrill>
Submitted:  Tue 07 Apr 2009 08:54:29 PM UTC
   
 
Category:  bug fix Priority:  5 - Normal
Status:  Done Privacy:  Public
Assigned to:  None Open/Closed:  Closed
Component Version:  simulavrxx

Sat 29 Jan 2011 10:17:26 PM UTC, comment #1: 

Marking as Done, on 2009-04-10 commited in http://git.savannah.gnu.org/cgit/simulavr.git/commit/?id=18c79e8c58720b83247fcdccd94a9c6d90695ed8

Geez, it has been almost 2 years.

Petr Hluzin <petrh>
Group Member
Tue 07 Apr 2009 08:54:29 PM UTC, original submission:  

Hi,

When looking into something else, I noticed that the assignments to pin were always character constants and there was no apparent reason for the type to be unsigned.

Attached patch changes it from unsigned to signed char. 

Comments appreciated.

Joel Sherrill <joelsherrill>
Group administrator

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attached Files
file #17882:  pin-uchar.diff added by joelsherrill (2KiB - application/octet-stream)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by petrh (Posted a comment)
  • -email is unavailable- added by joelsherrill (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

     

    Follow 3 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2011-01-29 petrh StatusNone Done
        Open/ClosedOpen Closed
    2009-04-07 joelsherrill Attached File- Added pin-uchar.diff, #17882

    Back to the top

    Powered by Savane 3.13-4b48.
    Corresponding source code