patchmldonkey, a multi-networks file-sharing client - Patches: patch #6804, EDK: Log incoming chat messages...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

patch #6804: EDK: Log incoming chat messages with ip:port info

Submitter:  Dennis Nezic <dennisne>
Submitted:  Sat 11 Apr 2009 02:25:57 AM UTC
   
 
Category:  Improved interfaces Priority:  5 - Normal
Status:  Done Assigned to:  None
Open/Closed:  Closed

Thu 22 Oct 2009 07:58:57 PM UTC, comment #1: 

committed 2009/10/22

spiralvoice <spiralvoice>
Group administrator
Sat 11 Apr 2009 02:25:57 AM UTC, original submission:  

Currently, when incoming chat messages are received, only the Ip address is logged... so I made this tiny patch to also include the port number. Why? Well, since incoming chatters aren't automatically included to our friends list, we have to add them manually to be able to chat with them later (otherwise the chat session will expire--or rather the client id-number will expire*), and to do that we need their port number, which is not always the default.

  • Is there a way to preserve (ed2k) clients/peers (ie. as identified by the Client number) longer, for those who send us (non-spam) messages? Adding them as friends keeps them indefinitely, but should not have to be necessary--ie. I just want to quickly chat with them, not necessarily give them higher priority over my shares.


In the future, we should probably make an "Add as friend" button/link somewhere in the messaging interface to make things easier, as it is already done when you click on most Client numbers.

Dennis Nezic <dennisne>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attached Files
file #17901:  message_log_include_ip_and_port.patch added by dennisne (1KiB - application/octet-stream)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by spiralvoice (Posted a comment)
  • -email is unavailable- added by dennisne (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

     

    Follow 4 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2009-10-22 spiralvoice StatusNone Done
        Open/ClosedOpen Closed
        SummarySmall tweak to log incoming chat messages with ip:port info EDK: Log incoming chat messages with ip:port info
    2009-04-11 dennisne Attached File- Added message_log_include_ip_and_port.patch, #17901

    Back to the top

    Powered by Savane 3.13-bb6a.
    Corresponding source code