Simulavr: an AVR simulator - Patches: patch #6831, Remove superfluous cycle list logic
You are not allowed to post comments on this tracker with your current authentication level.
patch #6831: Remove superfluous cycle list logic
Submitter: | Onno Kortmann <onnokort> | ||
Submitted: | Sun 17 May 2009 09:50:54 PM UTC | ||
Category: | None | Priority: | 5 - Normal |
Status: | None | Privacy: | Public |
Assigned to: | None | Open/Closed: | Closed |
Component Version: | simulavrxx |
Attached Files
Depends on the following items: None found
Items that depend on this one: None found
Carbon-Copy List
There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.
Follow 3 latest changes.
Date | Changed by | Updated Field | Previous Value | => | Replaced by |
---|---|---|---|---|---|
2009-05-22 | onnokort | Attached File | - | Added cyclelist-patch.patch, #18185 | |
2009-05-22 | joelsherrill | Open/Closed | Open | Closed | |
2009-05-17 | onnokort | Attached File | - | Added cyclelist-sanity.patch, #18157 |
Powered by Savane 3.13-4b48.
Corresponding source code
This patch simplifies the logic for adding to/removing from the CycleList. (See current ML posts about the SPI interface, the timer etc, to see how much headache this may cause).
The current code gives an 'internal error' when any object is added twice to the cycle list. This behaviour needs state-keeping code in the various objects.
A much simpler solution, proposed with this patch, is to simply ensure that an object is in or out of the cycle list with the avrdevice method calls. All the state-keeping code becomes superfluous.