patchAVR C Runtime Library - Patches: patch #6878, eewr_byte.S update for patch #6718

 
 

You are not allowed to post comments on this tracker with your current authentication level.

patch #6878: eewr_byte.S update for patch #6718

Submitter:  Bob Paddock <bpaddock>
Submitted:  Fri 24 Jul 2009 05:33:23 PM UTC
   
 
Category:  None Priority:  5 - Normal
Status:  Done Privacy:  Public
Assigned to:  dmix Open/Closed:  Closed

Thu 10 Sep 2009 05:50:05 AM UTC, comment #4: 

Bob and Simone, thanks for doing this!
Now the patch for 'eewr_byte.S' is commited without any
severe changes to both HEAD and 1_6 branches.
As I understand, it is not needed to change the 'eerd_byte.S'
(at least the file #18546 does not contain any differences with CVS).

Dmitry Xmelkov <dmix>
Group administrator
Tue 11 Aug 2009 02:22:52 PM UTC, comment #3: 

With Simone's help via email we got a couple of more cycles
out of the XMega byte write, and no longer trashing registers
of the callers.


(file #18555)

Bob Paddock <bpaddock>
Thu 06 Aug 2009 03:18:07 PM UTC, comment #2: 

There is a problem using r20 register: it is used to count bytes to write in eewr_block (look in eedef.h) that uses eewr_byte function. If you use that register you will overwrite the counter and the eeprom_write_block function will not work anymore.

There is another point: there's no need to look for NVM busy after a buffer erase, it will not erase eeprom locations but only the buffer.

I tested the eewr_byte function with all the write/update functions (word/dword/block) because they all uses the byte write function.

I suggest to update the CVS with this file, no need to change the other write and update functions.

P.S. The function 'eeprom_write_r18' uses one more scratch register, r17. Update "readme_eeprom.txt" accordingly.

(file #18534)

Simone Zamboni <zsimon>
Wed 05 Aug 2009 04:39:18 PM UTC, comment #1: 

No longer push/pop r18, use r20 instead.
Replaced XL with correct r19.
Corrected spelling.



(file #18531)

Bob Paddock <bpaddock>
Fri 24 Jul 2009 05:33:23 PM UTC, original submission:  

I was not sure if you could attach a patch to a closed patch (#6718)?

Attached is eewr_byte.S that has been tested in a XMega128A1.

Bob Paddock <bpaddock>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attached Files
file #18555:  eewr_byte.S added by bpaddock (5KiB - text/plain)
file #18546:  eerd_byte.S added by bpaddock (3KiB - application/octet-stream - Use _tmp_reg_ in place of r20. r0 is already covered in readme_eeprom.txt so no need to update there as well.)
file #18534:  eewr_byte.S added by zsimon (4KiB - text/plain - Tested for XMega on byte, word, dword and block write/update.)
file #18531:  eewr_byte.S added by bpaddock (5KiB - text/plain)
file #18468:  eewr_byte.S added by bpaddock (5KiB - text/plain - XMega tested eewr_byte.S)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by dmix (Updated the item)
  • -email is unavailable- added by zsimon (Updated the item)
  • -email is unavailable- added by bpaddock (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

     

    Follow 8 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2009-09-10 dmix StatusNone Done
        Open/ClosedOpen Closed
    2009-09-08 dmix Assigned toNone dmix
    2009-08-11 bpaddock Attached File- Added eewr_byte.S, #18555
    2009-08-09 bpaddock Attached File- Added eerd_byte.S, #18546
    2009-08-06 zsimon Attached File- Added eewr_byte.S, #18534
    2009-08-05 bpaddock Attached File- Added eewr_byte.S, #18531
    2009-07-24 bpaddock Attached File- Added eewr_byte.S, #18468

    Back to the top

    Powered by Savane 3.13-f8d8.
    Corresponding source code