patchAVR C Runtime Library - Patches: patch #6951, Time posix patch.

 
 

You are not allowed to post comments on this tracker with your current authentication level.

patch #6951: Time posix patch.

Submitter:  Daniele Basile <asterix>
Submitted:  Mon 19 Oct 2009 02:04:59 PM UTC
   
 
Category:  None Priority:  5 - Normal
Status:  Wont Do Privacy:  Public
Assigned to:  arcanum Open/Closed:  Closed

Jump to the original submission

Thu 12 May 2011 07:42:52 PM UTC, comment #12: 

If someone is interested in the matter, I suggest taking a
look at some resource with a clear licensing statement
which is compatible with avr-libc's.  Things like the
original (or modified) BSD system libraries come to mind ...
Please remember to also add the respective avr-libc
compatible (doxygen) documentation.

Joerg Wunsch <joerg_wunsch>
Group administrator
Thu 12 May 2011 07:17:53 PM UTC, comment #11: 

Due to the lack of clarity surrounding the licensing of this code, we cannot accept this patch. Closing patch tracker item.

Eric Weddington <arcanum>
Group administrator
Sun 02 Jan 2011 04:58:17 PM UTC, comment #10: 

I agree with you, and if you don't have hurry I can rewrite the patch to round on to the license trouble.

Let me now what do you think.

Daniele Basile <asterix>
Tue 21 Dec 2010 12:11:02 PM UTC, comment #9: 

As someone interested in using the patch in a project I took it upon me to check the copyright of the NEWLIB files.

Unfortunately the situation isn't clear. The time files I checked in NEWLIB all had a simple statement like

 "Original Author:    G. Haley"

in the code. E.g. http://sourceware.org/cgi-bin/cvsweb.cgi/src/newlib/libc/time/gmtime.c?annotate=1.4&cvsroot=src I didn't check all libc/time files.

NEWLIB itself points to http://sourceware.org/newlib/COPYING.NEWLIB for license details. But that file doesn't contain any reference to a "G. Haley".

Googleing produces a document about NEWLIB http://www.gnuarm.com/pdf/libc.pdf where a certain Graham Haley is mentioned:

"'libc' includes software developed by Martin Jackson, Graham Haley and Steve Chamberlain of Tadpole Technology and released to Cygnus."

But COPYING.NEWLIB doesn't mention Tadpole or Cygnus. I have no idea what "released to" means. For me that code is to hot to touch. I guess I have to write my own time functions.

Frank Ennert <timeuser>
Wed 21 Jul 2010 08:21:12 AM UTC, comment #8: 


> There are some news on my patch?


It would definitely speed up the acceptance of the patch if
you were digging up the licenses of all newly added files,
and place an appropriate copyright+license statement on top
of each file.  Ideally, they should be licensable under the
standard avr-libc license (which is a BSD-style 3-clause one).

Please don't forget to add your own copyright for those
things you changed yourself (like rewriting the external
source to use progmem strings).

Joerg Wunsch <joerg_wunsch>
Group administrator
Wed 21 Jul 2010 08:08:53 AM UTC, comment #7: 

There are some news on my patch?

Daniele Basile <asterix>
Thu 05 Nov 2009 10:44:44 PM UTC, comment #6: 

OK, I shall not hurry.

Dmitry Xmelkov <dmix>
Group administrator
Wed 04 Nov 2009 11:41:50 PM UTC, comment #5: 

Hi Dmitry,

We cannot commit this code until we verify that the licenses for these specific modules match the license of avr-libc.

Eric Weddington <arcanum>
Group administrator
Wed 04 Nov 2009 10:42:43 PM UTC, comment #4: 

After a few obvious changes (merge day/month names in one
string, replace macroses to normal functions) the size is reduced
(without called library functions):
  asctime(): 104 --> 69 words
  gmtime(): 339 --> 280 words
  mktime(): 632 --> 461 words
(Note, the sprintf() usage in asctime() is doubtful.)
In progress...

Dmitry Xmelkov <dmix>
Group administrator
Mon 02 Nov 2009 09:51:10 AM UTC, comment #3: 

there are some updates on mine time.h posix patch proposal?

Daniele Basile <asterix>
Tue 20 Oct 2009 01:30:21 PM UTC, comment #2: 

The code was taken from these files:
newlib/libc/time/
- asctime.c
- asctime_r.c
- local.h
- gmtime_r.c
- gmtime.c
- mktm_r.c
- mktime.c
newlib/libc/include
- time.h

the newlib version is: 2008-12-22: newlib-1.17.0

The licenses of newlib is:
http://sources.redhat.com/newlib/COPYING.NEWLIB

Daniele Basile <asterix>
Tue 20 Oct 2009 01:41:42 AM UTC, comment #1: 

Please point out which code was taken from newlib, and from which files in newlib. We will need to double-check the license to make sure that it matches and that it can be used in avr-libc.

Eric Weddington <arcanum>
Group administrator
Mon 19 Oct 2009 02:04:59 PM UTC, original submission:  

I ported some posix time library functions on avr target, like:
- mktime
- asctime
- gmtime

This patch could be apply to this version:
avr-libc-1.6.7.tar.bz2                 01-Jul-2009 17:33  1.2M


Note: patch's code license is BSD modified, but most code I have taken form the newlib (BSD modified to) and adapted for avr target. If this is a problem I can rewrite the code to not have any license issue.

Daniele Basile <asterix>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attached Files
file #18901:  time.patch added by asterix (141KiB - text/x-diff)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by timeuser (Posted a comment)
  • -email is unavailable- added by joerg_wunsch (Posted a comment)
  • -email is unavailable- added by dmix (Posted a comment)
  • -email is unavailable- added by arcanum (Posted a comment)
  • -email is unavailable- added by asterix (Submitted the item)
  • -email is unavailable- added by asterix
  • -email is unavailable- added by asterix
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

     

    Follow 8 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2011-05-12 arcanum StatusIn Progress Wont Do
        Assigned todmix arcanum
        Open/ClosedOpen Closed
    2009-11-04 dmix StatusNone In Progress
        Assigned toNone dmix
    2009-10-19 asterix Attached File- Added time.patch, #18901
        Carbon-Copy- Added -email is unavailable-
        Carbon-Copy- Added -email is unavailable-

    Back to the top

    Powered by Savane 3.13-f8d8.
    Corresponding source code