patchmldonkey, a multi-networks file-sharing client - Patches: patch #6959, DC: Fix invalid XML

 
 

You are not allowed to post comments on this tracker with your current authentication level.

patch #6959: DC: Fix invalid XML

Submitter:  Lucas <lucasn>
Submitted:  Thu 22 Oct 2009 08:00:49 PM UTC
   
 
Category:  None Priority:  5 - Normal
Status:  Done Assigned to:  None
Open/Closed:  Closed

Thu 08 Apr 2010 07:02:25 PM UTC, comment #4: 

committed dcXmpEscape2.patch 2010/04/08

spiralvoice <spiralvoice>
Group administrator
Tue 06 Apr 2010 09:35:54 PM UTC, comment #3: 

Enhanced patch (use Xml.escape and properly escape attributes in Xml.to_string)


(file #20140)

ygrek <ygrek>
Group Member
Thu 22 Oct 2009 08:02:33 PM UTC, comment #2: 

committed 2009/10/22

spiralvoice <spiralvoice>
Group administrator
Thu 22 Oct 2009 08:00:49 PM UTC, comment #1: 

This item has been reassigned from the project mldonkey, a multi-networks file-sharing client task tracker to your tracker.

The original report is still available at task #9357

Following are the information included in the original report:

[field #0]                  Item ID: 9357
[field #1]                 Group ID: 1409
[field #2]              Open/Closed: Open
[field #3]                 Severity: 3 - Normal
[field #4]                  Privacy: Public
[field #8]                         : Unknown task Field Display Type
[field #9]                 Category: DirectConnect-plugin
[field #10]             Submitted by: lucasn
[field #11]              Assigned to: None
[field #12]             Submitted on: Mo 04 Mai 2009 15:05:11 CEST
[field #13]                  Summary: DC: Fix invalid XML
[field #14]      Original Submission: Some days ago I stumpled about a bug in MLD's DC module: I used a C# based DC++ client called dcsharp and tried to download a user's filelist, but it would always trow an error about invalid characters in the XML i received from the client (he was using MLDC).
I looked into MLD's source and found the XML is generated without the use of any XML classes (if there are any in OCaml, which I suppose). So attribute values don't get escaped properly when generating the filelist.
With my limited (none) knowledge of OCaml I wrote a quick patch for the problem.
I used simple replace instead of generating the XML with a proper generator, as that would have exceeded my OCaml skills.
[field #16]               Item Group: None
[field #17]                   Status: None
[field #18]        Component Version: None
[field #19]         Operating System: None
[field #20]          Reproducibility: None
[field #21]               Size (loc): None
[field #22]            Fixed Release: None
[field #23]          Planned Release: None
[field #24]                   Effort: 0.00
[field #28]                 Priority: 5 - Normal
[field #29]          Should Start On: Mo 04 Mai 2009 02:00:00 CEST
[field #30]    Should be Finished on: Mo 04 Mai 2009 02:00:00 CEST
[field #31]         Percent Complete: 0%
[field #33]                  Release: None
[field #58]     Custom Select Box #1: None
[field #59]     Custom Select Box #2: None
[field #60]     Custom Select Box #3: None
[field #61]     Custom Select Box #4: None
[field #62]     Custom Select Box #5: None
[field #63]     Custom Select Box #6: None
[field #64]     Custom Select Box #7: None
[field #65]     Custom Select Box #8: None
[field #66]     Custom Select Box #9: None
[field #67]    Custom Select Box #10: None

spiralvoice <spiralvoice>
Group administrator
Thu 22 Oct 2009 08:00:49 PM UTC, original submission:  

Some days ago I stumpled about a bug in MLD's DC module: I used a C# based DC++ client called dcsharp and tried to download a user's filelist, but it would always trow an error about invalid characters in the XML i received from the client (he was using MLDC).
I looked into MLD's source and found the XML is generated without the use of any XML classes (if there are any in OCaml, which I suppose). So attribute values don't get escaped properly when generating the filelist.
With my limited (none) knowledge of OCaml I wrote a quick patch for the problem.
I used simple replace instead of generating the XML with a proper generator, as that would have exceeded my OCaml skills.

Lucas <lucasn>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attached Files
file #20140:  dcXmpEscape2.patch added by ygrek (5KiB - text/x-diff)
file #18082:  dcXmlEscape.patch added by lucasn (1KiB - application/octet-stream)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by ygrek (Updated the item)
  • -email is unavailable- added by spiralvoice (Updated the item)
  • -email is unavailable- added by lucasn (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

     

    Follow 8 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2010-04-08 spiralvoice StatusIn Progress Done
        Open/ClosedOpen Closed
    2010-04-07 spiralvoice StatusDone In Progress
        Open/ClosedClosed Open
    2010-04-06 ygrek Attached File- Added dcXmpEscape2.patch, #20140
    2009-10-22 spiralvoice StatusNone Done
        Open/ClosedOpen Closed
    2009-10-22 spiralvoice Reassign itemmldonkey, a multi-networks file-sharing client, task #9357 mldonkey, a multi-networks file-sharing client, patch #6959

    Back to the top

    Powered by Savane 3.13-02a9.
    Corresponding source code